[Enhancement](brpc)Added enable_brpc_builtin_services parameter in be.conf by hubgeter · Pull Request #40718 · apache/doris

hubgeter · 2024-09-12T06:06:34Z

Proposed changes

Since brpc's built-in services will expose some internal server status, for security reasons, add the parameter enable_brpc_builtin_services in be.conf. When the parameter is false, this built-in service can be disabled.

doris-robot · 2024-09-12T06:06:38Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

hubgeter · 2024-09-12T06:06:48Z

run buildall

morningman

LGTM

github-actions · 2024-09-12T06:44:50Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-12T06:44:52Z

PR approved by anyone and no changes requested.

doris-robot · 2024-09-12T07:46:32Z

TPC-H: Total hot run time: 40017 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 16a274eaf31b4bc201fba7a61dfd911a87a5ead3, data reload: false
------ Round 1 ----------------------------------
q1	17606	4591	4212	4212
q2	2020	185	191	185
q3	10578	1260	1426	1260
q4	10299	1050	1088	1050
q5	7700	3241	3191	3191
q6	228	137	139	137
q7	1031	642	621	621
q8	9476	2046	2091	2046
q9	6848	6313	6313	6313
q10	7014	2531	2498	2498
q11	431	260	255	255
q12	414	225	237	225
q13	17744	3012	3034	3012
q14	282	254	255	254
q15	565	503	496	496
q16	519	428	421	421
q17	997	952	943	943
q18	7953	6830	6910	6830
q19	1387	1251	1242	1242
q20	618	337	322	322
q21	3937	3510	3530	3510
q22	1079	994	1008	994
Total cold run time: 108726 ms
Total hot run time: 40017 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4227	4314	4186	4186
q2	350	239	231	231
q3	2883	2865	2895	2865
q4	1965	1939	2056	1939
q5	5734	5709	5804	5709
q6	231	137	136	136
q7	2180	1770	1792	1770
q8	3372	3402	3483	3402
q9	8849	8883	8836	8836
q10	3588	3640	3538	3538
q11	579	462	484	462
q12	813	665	659	659
q13	8839	3135	3199	3135
q14	338	304	271	271
q15	542	496	488	488
q16	520	467	472	467
q17	1813	1779	1795	1779
q18	8483	8093	8184	8093
q19	1783	1766	1754	1754
q20	2144	1872	1879	1872
q21	5887	5724	5808	5724
q22	1118	1014	1007	1007
Total cold run time: 66238 ms
Total hot run time: 58323 ms

doris-robot · 2024-09-12T07:46:48Z

TeamCity be ut coverage result:
Function Coverage: 36.88% (9453/25629)
Line Coverage: 28.25% (77783/275306)
Region Coverage: 27.65% (40148/145195)
Branch Coverage: 24.26% (20395/84084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/16a274eaf31b4bc201fba7a61dfd911a87a5ead3_16a274eaf31b4bc201fba7a61dfd911a87a5ead3/report/index.html

doris-robot · 2024-09-12T07:58:52Z

TPC-DS: Total hot run time: 199461 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 16a274eaf31b4bc201fba7a61dfd911a87a5ead3, data reload: false
query1	1245	887	873	873
query2	6307	1720	1743	1720
query3	10695	3956	3854	3854
query4	58277	25944	23893	23893
query5	4988	559	528	528
query6	329	175	170	170
query7	5522	321	301	301
query8	292	232	223	223
query9	5865	2482	2467	2467
query10	401	290	282	282
query11	15961	15511	15538	15511
query12	158	103	101	101
query13	1353	439	403	403
query14	10571	7441	7270	7270
query15	217	185	189	185
query16	7170	509	498	498
query17	1186	612	604	604
query18	1912	326	313	313
query19	210	162	169	162
query20	123	115	113	113
query21	225	107	110	107
query22	4720	4615	4363	4363
query23	34721	33908	33600	33600
query24	6159	3140	3093	3093
query25	537	431	416	416
query26	621	164	165	164
query27	1557	287	288	287
query28	2775	2019	2006	2006
query29	690	444	441	441
query30	230	160	149	149
query31	946	813	788	788
query32	74	59	58	58
query33	448	310	316	310
query34	894	485	483	483
query35	874	756	727	727
query36	1025	897	916	897
query37	142	85	86	85
query38	4007	3953	3883	3883
query39	1440	1415	1399	1399
query40	204	119	120	119
query41	50	49	47	47
query42	121	101	102	101
query43	497	440	442	440
query44	1207	781	755	755
query45	197	172	169	169
query46	1101	839	819	819
query47	1942	1783	1767	1767
query48	373	296	293	293
query49	732	451	457	451
query50	958	449	445	445
query51	7030	6793	6944	6793
query52	98	89	88	88
query53	264	183	186	183
query54	570	468	472	468
query55	77	79	78	78
query56	290	269	260	260
query57	1206	1071	1066	1066
query58	231	257	239	239
query59	2704	2590	2391	2391
query60	299	278	283	278
query61	103	100	99	99
query62	793	656	682	656
query63	249	199	195	195
query64	1617	673	674	673
query65	3241	3143	3168	3143
query66	667	339	342	339
query67	15978	15603	15349	15349
query68	2157	580	585	580
query69	414	294	288	288
query70	1170	1111	1108	1108
query71	361	289	287	287
query72	6191	4130	4020	4020
query73	771	329	333	329
query74	9417	9011	9048	9011
query75	3351	2750	2738	2738
query76	1371	1349	1380	1349
query77	522	326	332	326
query78	9935	9323	9618	9323
query79	1197	926	890	890
query80	1133	870	860	860
query81	540	268	268	268
query82	1187	266	268	266
query83	228	197	199	197
query84	277	107	106	106
query85	788	443	402	402
query86	332	314	321	314
query87	4540	4313	4460	4313
query88	4237	4154	4127	4127
query89	403	372	380	372
query90	1861	322	314	314
query91	123	125	121	121
query92	78	77	77	77
query93	1317	1106	1102	1102
query94	751	378	385	378
query95	502	449	443	443
query96	479	480	474	474
query97	3146	3090	3141	3090
query98	238	246	236	236
query99	1714	1324	1321	1321
Total cold run time: 298397 ms
Total hot run time: 199461 ms

doris-robot · 2024-09-12T08:04:23Z

ClickBench: Total hot run time: 31.27 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 16a274eaf31b4bc201fba7a61dfd911a87a5ead3, data reload: false
query1	0.05	0.05	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.73	0.07	0.07
query5	0.49	0.49	0.48
query6	1.26	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.57	0.52	0.54
query10	0.57	0.57	0.56
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.61	0.60	0.61
query14	1.48	1.45	1.48
query15	0.89	0.86	0.87
query16	0.35	0.35	0.35
query17	1.03	0.98	1.07
query18	0.17	0.16	0.16
query19	1.86	1.89	1.87
query20	0.01	0.00	0.01
query21	15.38	0.66	0.65
query22	4.61	7.51	1.78
query23	18.08	1.34	1.37
query24	2.28	0.22	0.22
query25	0.18	0.08	0.07
query26	0.29	0.18	0.17
query27	0.07	0.08	0.09
query28	13.15	1.00	0.97
query29	12.61	3.31	3.28
query30	0.24	0.05	0.06
query31	2.89	0.41	0.40
query32	3.22	0.49	0.49
query33	3.00	3.02	3.07
query34	15.43	4.30	4.31
query35	4.34	4.32	4.33
query36	0.69	0.48	0.49
query37	0.20	0.17	0.16
query38	0.17	0.14	0.14
query39	0.05	0.04	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.06
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 108.99 s
Total hot run time: 31.27 s

hubgeter · 2024-09-12T15:01:59Z

run buildall

doris-robot · 2024-09-12T16:31:36Z

TPC-H: Total hot run time: 43546 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9797ea3b9616b823998c863209191db260586c7, data reload: false
------ Round 1 ----------------------------------
q1	18294	7421	7286	7286
q2	2829	198	187	187
q3	10758	2010	1435	1435
q4	10637	1063	1062	1062
q5	7814	3333	3239	3239
q6	248	156	156	156
q7	1058	664	630	630
q8	9462	2025	2064	2025
q9	6752	6326	6323	6323
q10	7035	2527	2568	2527
q11	430	257	260	257
q12	419	239	236	236
q13	17772	3050	3089	3050
q14	292	254	260	254
q15	577	527	540	527
q16	520	432	440	432
q17	1012	963	962	962
q18	7581	6768	6847	6768
q19	1390	1251	1247	1247
q20	631	355	340	340
q21	4014	3593	3604	3593
q22	1115	1010	1030	1010
Total cold run time: 110640 ms
Total hot run time: 43546 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7175	7158	7181	7158
q2	348	233	233	233
q3	2974	2971	2904	2904
q4	2000	1943	1968	1943
q5	5466	5460	5488	5460
q6	238	146	150	146
q7	2101	1721	1696	1696
q8	3276	3343	3361	3343
q9	8446	8428	8483	8428
q10	3429	3474	3430	3430
q11	570	476	467	467
q12	768	567	612	567
q13	5627	3111	3058	3058
q14	304	266	285	266
q15	582	521	522	521
q16	489	459	457	457
q17	1786	1745	1737	1737
q18	7965	7483	7525	7483
q19	1738	1708	1713	1708
q20	2040	1826	1814	1814
q21	5666	5514	5552	5514
q22	1089	1007	1008	1007
Total cold run time: 64077 ms
Total hot run time: 59340 ms

doris-robot · 2024-09-12T16:43:28Z

TPC-DS: Total hot run time: 196167 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9797ea3b9616b823998c863209191db260586c7, data reload: false
query1	917	382	382	382
query2	6507	1773	1785	1773
query3	6664	220	221	220
query4	26139	23862	23872	23862
query5	4873	560	574	560
query6	248	188	168	168
query7	4591	318	325	318
query8	288	240	234	234
query9	8491	2629	2616	2616
query10	449	278	272	272
query11	16302	15635	15639	15635
query12	157	98	101	98
query13	1672	404	388	388
query14	11170	7058	7220	7058
query15	225	179	172	172
query16	7428	456	493	456
query17	1552	577	596	577
query18	1896	292	293	292
query19	199	156	155	155
query20	124	111	114	111
query21	216	109	106	106
query22	4610	4329	4245	4245
query23	34442	33582	33769	33582
query24	10119	3101	3130	3101
query25	681	411	420	411
query26	1125	166	162	162
query27	2404	291	295	291
query28	6577	2120	2093	2093
query29	923	431	454	431
query30	298	158	156	156
query31	1018	809	784	784
query32	106	58	60	58
query33	729	318	309	309
query34	928	501	483	483
query35	903	741	723	723
query36	1082	904	927	904
query37	159	90	87	87
query38	4072	3925	4007	3925
query39	1452	1388	1429	1388
query40	211	126	124	124
query41	50	49	49	49
query42	137	105	101	101
query43	538	438	447	438
query44	1251	796	781	781
query45	203	176	175	175
query46	1125	842	827	827
query47	1919	1774	1810	1774
query48	365	293	290	290
query49	1133	472	462	462
query50	927	436	447	436
query51	7145	7003	6995	6995
query52	105	91	95	91
query53	278	193	195	193
query54	819	487	485	485
query55	83	77	82	77
query56	316	290	289	289
query57	1239	1099	1083	1083
query58	260	262	255	255
query59	2785	2639	2672	2639
query60	328	297	294	294
query61	125	122	125	122
query62	930	691	676	676
query63	235	196	195	195
query64	5470	720	671	671
query65	3299	3209	3220	3209
query66	1404	300	323	300
query67	15979	15536	15441	15441
query68	3464	876	850	850
query69	451	340	338	338
query70	1145	1118	1128	1118
query71	368	356	357	356
query72	6167	3376	3426	3376
query73	601	586	587	586
query74	9301	9282	9170	9170
query75	3241	3037	3036	3036
query76	2519	883	886	883
query77	498	422	432	422
query78	9872	9287	9319	9287
query79	936	897	871	871
query80	877	875	853	853
query81	451	270	272	270
query82	270	264	263	263
query83	206	192	194	192
query84	236	112	111	111
query85	682	410	410	410
query86	308	298	322	298
query87	4378	4420	4479	4420
query88	4255	4182	4149	4149
query89	389	376	385	376
query90	1197	320	324	320
query91	126	124	124	124
query92	80	80	78	78
query93	1072	1098	1052	1052
query94	478	404	358	358
query95	471	426	423	423
query96	480	479	482	479
query97	3168	3120	3157	3120
query98	231	233	232	232
query99	1555	1288	1335	1288
Total cold run time: 279868 ms
Total hot run time: 196167 ms

doris-robot · 2024-09-12T16:43:49Z

TeamCity be ut coverage result:
Function Coverage: 36.89% (9462/25647)
Line Coverage: 28.25% (77785/275352)
Region Coverage: 27.66% (40179/145241)
Branch Coverage: 24.28% (20422/84110)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f9797ea3b9616b823998c863209191db260586c7_f9797ea3b9616b823998c863209191db260586c7/report/index.html

github-actions · 2024-09-13T03:54:33Z

PR approved by at least one committer and no changes requested.

….conf (apache#40718) ## Proposed changes Since [brpc's built-in services](https://brpc.apache.org/zh/docs/builtin-services/buildin_services/) will expose some internal server status, for security reasons, add the parameter `enable_brpc_builtin_services` in `be.conf`. When the parameter is false, this built-in service can be disabled.

….conf (#40718) (#41047) bp #40718 ## Proposed changes Since [brpc's built-in services](https://brpc.apache.org/zh/docs/builtin-services/buildin_services/) will expose some internal server status, for security reasons, add the parameter `enable_brpc_builtin_services` in `be.conf`. When the parameter is false, this built-in service can be disabled.

….conf (#40718) ## Proposed changes Since [brpc's built-in services](https://brpc.apache.org/zh/docs/builtin-services/buildin_services/) will expose some internal server status, for security reasons, add the parameter `enable_brpc_builtin_services` in `be.conf`. When the parameter is false, this built-in service can be disabled.

….conf (apache#40718) ## Proposed changes Since [brpc's built-in services](https://brpc.apache.org/zh/docs/builtin-services/buildin_services/) will expose some internal server status, for security reasons, add the parameter `enable_brpc_builtin_services` in `be.conf`. When the parameter is false, this built-in service can be disabled.

morningman previously approved these changes Sep 12, 2024
View reviewed changes

morningman added the dev/2.1.x label Sep 12, 2024

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 12, 2024

morningman added dev/3.0.x and removed approved Indicates a PR has been approved by one committer. labels Sep 12, 2024

github-actionsBot added the reviewed label Sep 12, 2024

hubgeter dismissed morningman’s stale review via 15d1a9eSeptember 12, 2024 15:01

hubgeter added 2 commits September 12, 2024 23:01

[Enhancement](brpc)Added parameter
1e84591

unset pipeline be.conf
f9797ea

hubgeter force-pushed the disable_brpc_builtin_services branch from 15d1a9e to f9797eaCompare September 12, 2024 15:01

BePPPower approved these changes Sep 13, 2024
View reviewed changes

morningman approved these changes Sep 13, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 13, 2024

morningman merged commit 0cff225 into apache:masterSep 14, 2024

hubgeter mentioned this pull request Sep 20, 2024
[Enhancement](brpc)Added enable_brpc_builtin_services parameter in be.conf (#40718) #41047
Merged

yiguolei added dev/2.1.7-merged and removed dev/2.1.x labels Sep 21, 2024

morningman added dev/3.0.3-merged and removed dev/3.0.x labels Oct 9, 2024

Uh oh!

Conversation

hubgeter commented Sep 12, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

hubgeter commented Sep 12, 2024

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

hubgeter commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

github-actionsBot commented Sep 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hubgeter commented Sep 12, 2024•
edited
Loading