Skip to content

[fix](scanner) Fix incorrect _max_thread_num in scanner context #40569 - #40760

Closed
RoanHeNaN wants to merge 2 commits into
apache:branch-2.1from
RoanHeNaN:pick_40569_to_upstream_branch-2.1
Closed

[fix](scanner) Fix incorrect _max_thread_num in scanner context #40569#40760
RoanHeNaN wants to merge 2 commits into
apache:branch-2.1from
RoanHeNaN:pick_40569_to_upstream_branch-2.1

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Sep 12, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

cherry pick from #40569 and do modification on branch-2.1

  1. Since constructor changed, so modified code of non-pipeline and old pipeline
  2. The _max_thread_num calculation of old pipeline is not changed.

@RoanHeNaN

RoanHeNaN commented Sep 12, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 12, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@RoanHeNaN
RoanHeNaNforce-pushed the pick_40569_to_upstream_branch-2.1 branch from bf447d4 to b5b3d64CompareSeptember 12, 2024 12:17
@github-actions

github-actionsBot commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@RoanHeNaN
RoanHeNaNforce-pushed the pick_40569_to_upstream_branch-2.1 branch from b5b3d64 to e39b1b2CompareSeptember 12, 2024 13:47
@github-actions

github-actionsBot commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@RoanHeNaN

RoanHeNaN commented Sep 12, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 12, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.15% (9320/25778)
Line Coverage: 27.72% (76468/275904)
Region Coverage: 26.51% (39276/148180)
Branch Coverage: 23.34% (20040/85860)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ead4a5d9455318cc6bc3027542fd627affa2aaf0_ead4a5d9455318cc6bc3027542fd627affa2aaf0/report/index.html

@RoanHeNaN

RoanHeNaN commented Sep 13, 2024

Copy link
Copy Markdown
ContributorAuthor

failed on known problem

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RoanHeNaN@doris-robot@yiguolei