Skip to content

Fix be may core dump when linked schema change - #4079

Merged
yangzhg merged 3 commits into
apache:masterfrom
yangzhg:fix_zone_map_core
Jul 15, 2020
Merged

Fix be may core dump when linked schema change#4079
yangzhg merged 3 commits into
apache:masterfrom
yangzhg:fix_zone_map_core

Conversation

@yangzhg

@yangzhgyangzhg commented Jul 10, 2020

Copy link
Copy Markdown
Member

fixes#4078
If the server upgrade from 0.11 and has a duplicate table. After upgrade we add a column by linked schema change, this will be cause a core dump
this is becase of the zone map in duplcate table in 0.11 does not contains the value column, so that the vector may out of boundary

Comment threadbe/src/olap/rowset/segment_group.cpp Outdated
Co-authored-by: wutiangan <wutiangan@gmail.com>
@chaoyli

Copy link
Copy Markdown
Contributor

You can elaborate the commit message explicitly not like fix xxx.
It will be better to read.

@yangzhg
yangzhg requested a review from morningmanJuly 13, 2020 08:24

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added approved Indicates a PR has been approved by one committer. area/schema-change Issues or PRs related to schema change labels Jul 14, 2020
@yangzhg
yangzhg merged commit 14ac49d into apache:masterJul 15, 2020
@yangzhg
yangzhg deleted the fix_zone_map_core branch July 15, 2020 02:23
morningman pushed a commit to morningman/doris that referenced this pull request Jul 16, 2020
* fix a core
* Update be/src/olap/rowset/segment_group.cpp
Change-Id: I3d2e560581bca420e0437030b8bdd7286418cca4
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/schema-changeIssues or PRs related to schema change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] be may be core dump if the server upgrade from 0.11

4 participants

@yangzhg@chaoyli@morningman@wutiangan