Skip to content

[Feature][Meta]Update/Read/Write VisibleVersionTime for Partition#4076 - #4086

Merged
morningman merged 2 commits into
apache:masterfrom
marising:partition_visibleversiontime
Jul 26, 2020
Merged

[Feature][Meta]Update/Read/Write VisibleVersionTime for Partition#4076#4086
morningman merged 2 commits into
apache:masterfrom
marising:partition_visibleversiontime

Conversation

@marising

@marisingmarising commented Jul 13, 2020

Copy link
Copy Markdown

#4076

  1. The visibleVersionTime is updated when insert data to partition
  2. GlobalTransactionMgr call partition.updateVisibleVersionAndVersionHash(version, versionHash) when fe is restarted
  3. If fe restart, VisibleVersionTime may be changed, but the changed value is newer than the old value

morningman
morningman requested changes Jul 15, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/catalog/Partition.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Partition.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Partition.java Outdated
@morningmanmorningman self-assigned this Jul 15, 2020
@morningmanmorningman added area/catalog Issues or PRs related to catalog management kind/meta-version-change Categorizes issue or PR as related to changing meta version labels Jul 15, 2020
morningman
morningman previously approved these changes Jul 22, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

morningman commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Hi @marising the FE code structure has been changed, please rebase the code the solve the conflicts.

@marising
marisingforce-pushed the partition_visibleversiontime branch from 6f1f1ea to 6bc385fCompareJuly 23, 2020 06:36
morningman
morningman approved these changes Jul 25, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jul 25, 2020
@morningman
morningman merged commit ed8cb6a into apache:masterJul 26, 2020
This was referenced Jul 29, 2020
Closed
Merged
morningman pushed a commit that referenced this pull request Jul 30, 2020
@caiconghui
[Bug] Fix fe meta version problem, make drop meta check code easy to …
237271c
…read and add doc content for drop meta check (#4205)
This PR is mainly do three things:
1. Fix fe meta version bug introduced by #4029 , when fix conflict with #4086 2. Make drop check code easy to read
3. Add doc content for drop meta check
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
@Yukang-Lian
[Enhancement](Compaction) Make base compaction use the same tablet se…
1a906b8
…lection strategy as cumulative compaction apache#51649 (apache#4086)
Pick doris apache#51649
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.area/catalogIssues or PRs related to catalog managementkind/meta-version-changeCategorizes issue or PR as related to changing meta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marising@morningman