Skip to content

Fix some problem related with publish version task - #4089

Merged
chaoyli merged 9 commits into
apache:masterfrom
caiconghui:fix-warn
Jul 23, 2020
Merged

Fix some problem related with publish version task#4089
chaoyli merged 9 commits into
apache:masterfrom
caiconghui:fix-warn

Conversation

@caiconghui

@caiconghuicaiconghui commented Jul 13, 2020•
edited by morningman
Loading

Copy link
Copy Markdown
Contributor

This PR is mainly do following three things:

  1. Add thread name in fe log to make trace problem more easy.
  2. Add agent_task_resend_wait_time_ms config to escape sending duplicate agent task to be.
  3. Skip to continue to update replica version when new version is lower than replica version in fe.

@caiconghui

caiconghui commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

fix #4090

yangzhg
yangzhg reviewed Jul 15, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/catalog/Replica.java
@yangzhgyangzhg added the kind/fix Categorizes issue or PR as related to a bug. label Jul 15, 2020
morningman
morningman reviewed Jul 15, 2020
View reviewed changes
Comment threaddocs/en/administrator-guide/config/fe_config.md Outdated
Comment threadfe/src/main/java/org/apache/doris/common/Config.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Replica.java
@morningmanmorningman self-assigned this Jul 15, 2020
morningman
morningman previously approved these changes Jul 22, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

morningman commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Hi @caiconghui , the FE code structure has been changed, please rebase the code to solve the conflicts

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jul 23, 2020
@chaoyli
chaoyli merged commit 2334f5d into apache:masterJul 23, 2020
@caiconghui
caiconghui deleted the fix-warn branch July 30, 2020 02:21
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
@Yukang-Lian
[Enhancement](Compaction) Add some metrics for compaction (apache#51649…
8f59cd7
…) (apache#4089)
Pick from doris apache#51649
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhgyangzhgyangzhg left review comments
@chaoylichaoylichaoyli approved these changes
@morningmanmorningmanmorningman left review comments

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.kind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@caiconghui@morningman@yangzhg@chaoyli