Skip to content

[fix](function) fix Substring/SubReplace error result with input utf8… - #40954

Merged
yiguolei merged 4 commits into
apache:branch-2.1from
Mryange:branch-2.1-pick-40929
Sep 23, 2024
Merged

[fix](function) fix Substring/SubReplace error result with input utf8…#40954
yiguolei merged 4 commits into
apache:branch-2.1from
Mryange:branch-2.1-pick-40929

Conversation

@Mryange

Copy link
Copy Markdown
Contributor

… string (#40929)
#40929


mysql [(none)]>select sub_replace("你好世界","a",1);
+-------------------------------------+
| sub_replace('你好世界', 'a', 1) |
+-------------------------------------+
| �a�好世界 |
+-------------------------------------+
mysql [(none)]>select SUBSTRING('中文测试',5);
+------------------------------------------+
| substring('中文测试', 5, 2147483647) |
+------------------------------------------+
| 中文测试 |
+------------------------------------------+
1 row in set (0.04 sec)
now
mysql [(none)]>select sub_replace("你好世界","a",1);
+-------------------------------------+
| sub_replace('你好世界', 'a', 1) |
+-------------------------------------+
| 你a世界 |
+-------------------------------------+
1 row in set (0.05 sec)
mysql [(none)]>select SUBSTRING('中文测试',5);
+------------------------------------------+
| substring('中文测试', 5, 2147483647) |
+------------------------------------------+
| |
+------------------------------------------+
1 row in set (0.13 sec)

Proposed changes

Issue Number: close #xxx

… string (apache#40929)
```
mysql [(none)]>select sub_replace("你好世界","a",1);
+-------------------------------------+
| sub_replace('你好世界', 'a', 1) |
+-------------------------------------+
| �a�好世界 |
+-------------------------------------+
mysql [(none)]>select SUBSTRING('中文测试',5);
+------------------------------------------+
| substring('中文测试', 5, 2147483647) |
+------------------------------------------+
| 中文测试 |
+------------------------------------------+
1 row in set (0.04 sec)
now
mysql [(none)]>select sub_replace("你好世界","a",1);
+-------------------------------------+
| sub_replace('你好世界', 'a', 1) |
+-------------------------------------+
| 你a世界 |
+-------------------------------------+
1 row in set (0.05 sec)
mysql [(none)]>select SUBSTRING('中文测试',5);
+------------------------------------------+
| substring('中文测试', 5, 2147483647) |
+------------------------------------------+
| |
+------------------------------------------+
1 row in set (0.13 sec)
```
@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Mryange

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.18% (9335/25803)
Line Coverage: 27.72% (76686/276642)
Region Coverage: 26.49% (39374/148625)
Branch Coverage: 23.29% (20053/86088)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2d23ca650f738be2454412d9ea13ea831b5f9f4c_2d23ca650f738be2454412d9ea13ea831b5f9f4c/report/index.html

@Mryange

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.15% (9331/25815)
Line Coverage: 27.70% (76667/276744)
Region Coverage: 26.49% (39381/148669)
Branch Coverage: 23.28% (20049/86112)
Coverage Report: http://coverage.selectdb-in.cc/coverage/80512d3a70322232d91b12de3096edf3ed165cf8_80512d3a70322232d91b12de3096edf3ed165cf8/report/index.html

@Mryange
Mryangeforce-pushed the branch-2.1-pick-40929 branch from 80512d3 to 346b644CompareSeptember 21, 2024 15:14
@Mryange

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.14% (9330/25815)
Line Coverage: 27.69% (76643/276744)
Region Coverage: 26.47% (39360/148669)
Branch Coverage: 23.27% (20041/86112)
Coverage Report: http://coverage.selectdb-in.cc/coverage/33aeeb9f211820022d7bcbca10982a53eadec792_33aeeb9f211820022d7bcbca10982a53eadec792/report/index.html

@yiguolei
yiguolei merged commit 0e5c428 into apache:branch-2.1Sep 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Mryange@doris-robot@yiguolei