Skip to content

[feat](profile) Print changed session var in profile - #41016

Merged
yiguolei merged 15 commits into
apache:masterfrom
RoanHeNaN:feat-profile-session-var
Sep 23, 2024
Merged

[feat](profile) Print changed session var in profile#41016
yiguolei merged 15 commits into
apache:masterfrom
RoanHeNaN:feat-profile-session-var

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Sep 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Add changed session var like follow:

Changed Session Variables:
VarName | CurrentValue | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results | NULL | utf8mb4
enable_profile | true | false
enable_auto_analyze | false | true
max_scan_key_num | -1 | 48
enable_prepared_stmt_audit_log | true | false
sql_mode | STRICT_TRANS_TABLES |
wait_timeout | 31000 | 28800
parallel_pipeline_task_num | 8 | 0
num_scanner_threads | 10 | 0
experimental_enable_agg_state | true | false
max_pushdown_conditions_per_column | -1 | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384 | 2097152
max_allowed_packet | 1048576 | 16777216

@doris-robot

doris-robot commented Sep 19, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@RoanHeNaN
RoanHeNaNforce-pushed the feat-profile-session-var branch from db2164b to 56d54b9CompareSeptember 19, 2024 12:12
@RoanHeNaN

RoanHeNaN commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@RoanHeNaN

RoanHeNaN commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN
RoanHeNaN marked this pull request as ready for review September 19, 2024 13:20
@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

yiguolei
yiguolei reviewed Sep 20, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/common/profile/Profile.java
}

if (profileHasBeenStored()) {
LOG.info("Profile {} has been stored to storage, reading it from storage", id);

@yiguoleiyiguoleiSep 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么改这个？

@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Sep 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 23, 2024
@github-actions

github-actionsBot commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

zclllyybb
zclllyybb approved these changes Sep 23, 2024
View reviewed changes

@zclllyybbzclllyybb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 7c9c0e0 into apache:masterSep 23, 2024
@RoanHeNaN
RoanHeNaN deleted the feat-profile-session-var branch September 23, 2024 07:07
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Sep 25, 2024
@RoanHeNaN
[feat](profile) Print changed session var in profile (apache#41016)
0094e70
Add changed session var like follow:
```
Changed Session Variables:
VarName | CurrentValue | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results | NULL | utf8mb4
enable_profile | true | false
enable_auto_analyze | false | true
max_scan_key_num | -1 | 48
enable_prepared_stmt_audit_log | true | false
sql_mode | STRICT_TRANS_TABLES |
wait_timeout | 31000 | 28800
parallel_pipeline_task_num | 8 | 0
num_scanner_threads | 10 | 0
experimental_enable_agg_state | true | false
max_pushdown_conditions_per_column | -1 | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384 | 2097152
max_allowed_packet | 1048576 | 16777216
```
@RoanHeNaNRoanHeNaN mentioned this pull request Sep 25, 2024
Merged
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Sep 25, 2024
@RoanHeNaN
[feat](profile) Print changed session var in profile (apache#41016)
59cef88
Add changed session var like follow:
```
Changed Session Variables:
VarName | CurrentValue | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results | NULL | utf8mb4
enable_profile | true | false
enable_auto_analyze | false | true
max_scan_key_num | -1 | 48
enable_prepared_stmt_audit_log | true | false
sql_mode | STRICT_TRANS_TABLES |
wait_timeout | 31000 | 28800
parallel_pipeline_task_num | 8 | 0
num_scanner_threads | 10 | 0
experimental_enable_agg_state | true | false
max_pushdown_conditions_per_column | -1 | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384 | 2097152
max_allowed_packet | 1048576 | 16777216
```
@RoanHeNaNRoanHeNaN mentioned this pull request Sep 25, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 27, 2024
@RoanHeNaN
[feat](profile) Print changed session var in profile#41016(#41317)
21b8887
cherry pick from #41016
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Sep 27, 2024
@RoanHeNaN
[feat](profile) Print changed session var in profile (apache#41016)
9583b86
Add changed session var like follow:
```
Changed Session Variables:
VarName | CurrentValue | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results | NULL | utf8mb4
enable_profile | true | false
enable_auto_analyze | false | true
max_scan_key_num | -1 | 48
enable_prepared_stmt_audit_log | true | false
sql_mode | STRICT_TRANS_TABLES |
wait_timeout | 31000 | 28800
parallel_pipeline_task_num | 8 | 0
num_scanner_threads | 10 | 0
experimental_enable_agg_state | true | false
max_pushdown_conditions_per_column | -1 | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384 | 2097152
max_allowed_packet | 1048576 | 16777216
```
yiguolei pushed a commit that referenced this pull request Oct 18, 2024
@RoanHeNaN
[feat](profile) Print changed session var in profile#41016(#41318)
21af64b
cherry pick from #41016
@yiguoleiyiguolei mentioned this pull request Nov 6, 2024
Closed
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
@yiguoleiyiguolei mentioned this pull request Jan 19, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@RoanHeNaN@HappenLee
[feat](profile) Print changed session var in profile (apache#41016)
2e7d8e9
Add changed session var like follow:
```
Changed Session Variables:
VarName | CurrentValue | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results | NULL | utf8mb4
enable_profile | true | false
enable_auto_analyze | false | true
max_scan_key_num | -1 | 48
enable_prepared_stmt_audit_log | true | false
sql_mode | STRICT_TRANS_TABLES |
wait_timeout | 31000 | 28800
parallel_pipeline_task_num | 8 | 0
num_scanner_threads | 10 | 0
experimental_enable_agg_state | true | false
max_pushdown_conditions_per_column | -1 | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384 | 2097152
max_allowed_packet | 1048576 | 16777216
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@jacktenggjacktenggjacktengg approved these changes
@zclllyybbzclllyybbzclllyybb approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RoanHeNaN@doris-robot@yiguolei@jacktengg@zclllyybb