Skip to content

[Opt](load) Optimize the error messages of -235 and -238 for loading - #41048

Merged
liaoxin01 merged 2 commits into
apache:masterfrom
liaoxin01:opt_error
Sep 28, 2024
Merged

[Opt](load) Optimize the error messages of -235 and -238 for loading#41048
liaoxin01 merged 2 commits into
apache:masterfrom
liaoxin01:opt_error

Conversation

@liaoxin01

@liaoxin01liaoxin01 commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@doris-robot

doris-robot commented Sep 20, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@liaoxin01

liaoxin01 commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.28% (9597/25744)
Line Coverage: 28.67% (79322/276704)
Region Coverage: 28.13% (41053/145961)
Branch Coverage: 24.75% (20912/84508)
Coverage Report: http://coverage.selectdb-in.cc/coverage/be8de68427c171384457cd7425da1c0026c9892f_be8de68427c171384457cd7425da1c0026c9892f/report/index.html

dataroaring
dataroaring reviewed Sep 24, 2024
View reviewed changes
Comment threadbe/src/cloud/cloud_delete_task.cpp
dataroaring
dataroaring approved these changes Sep 25, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring

dataroaring commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.31% (9635/25823)
Line Coverage: 28.72% (79746/277663)
Region Coverage: 28.14% (41226/146504)
Branch Coverage: 24.76% (20989/84764)
Coverage Report: http://coverage.selectdb-in.cc/coverage/405d5693fc837aa89d8dcf168f41a697affea846_405d5693fc837aa89d8dcf168f41a697affea846/report/index.html

sollhui
sollhui approved these changes Sep 26, 2024
View reviewed changes

@sollhuisollhui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01

liaoxin01 commented Sep 27, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 27, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.30% (9627/25811)
Line Coverage: 28.71% (79689/277600)
Region Coverage: 28.13% (41188/146435)
Branch Coverage: 24.74% (20968/84748)
Coverage Report: http://coverage.selectdb-in.cc/coverage/405d5693fc837aa89d8dcf168f41a697affea846_405d5693fc837aa89d8dcf168f41a697affea846/report/index.html

@liaoxin01
liaoxin01 merged commit b6b8e4f into apache:masterSep 28, 2024
@liaoxin01
liaoxin01 deleted the opt_error branch September 28, 2024 11:33
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@liaoxin01@dataroaring
[Opt](load) Optimize the error messages of -235 and -238 for loading (#…
66c4d1f
…41048)
@liaoxin01liaoxin01 mentioned this pull request Oct 10, 2024
Merged
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
cd746fa
…pache#41048)
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
41e93af
…pache#41048)
@liaoxin01liaoxin01 mentioned this pull request Oct 10, 2024
Merged
dataroaring pushed a commit that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading#…
49b1ada
…41048 (#41645)
cherry pick from #41048
@dataroaringdataroaring added dev/2.0.16-merged-deprecated 2.0.16 is NOT and will NOT be released and removed dev/2.0.x labels Oct 10, 2024
dataroaring pushed a commit that referenced this pull request Oct 10, 2024
@liaoxin01
[Opt](load) Optimize the error messages of -235 and -238 for loading#…
a26079c
…41048 (#41638)
cherry pick from #41048
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@liaoxin01@cjj2010
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
d88c56c
…pache#41048)
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@liaoxin01amorynan
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
0db0831
…pache#41048)
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@liaoxin01@HappenLee
[Opt](load) Optimize the error messages of -235 and -238 for loading (a…
33c1526
…pache#41048)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sollhuisollhuisollhui approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.16-merged-deprecated2.0.16 is NOT and will NOT be releaseddev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liaoxin01@doris-robot@dataroaring@sollhui