[fix](schema change) fix delete predicate incorrect comparisons result with empty strings during schema change by luwei16 · Pull Request #41064 · apache/doris

luwei16 · 2024-09-20T08:59:03Z

problem

insert into t1 (k1, k2, v1) value(1, '', 2);
delete form t1 where k1 = 1 and k2 = '';
alter table modify column v1 string
select * from t1 // expect 0 rows in return, but get 1 row.

…t with empty strings during schema change

doris-robot · 2024-09-20T08:59:08Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

luwei16 · 2024-09-20T09:07:06Z

run buildall

doris-robot · 2024-09-20T10:02:54Z

TeamCity be ut coverage result:
Function Coverage: 37.25% (9598/25769)
Line Coverage: 28.62% (79291/277031)
Region Coverage: 28.09% (41045/146100)
Branch Coverage: 24.72% (20910/84588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ebd04dbb901706c73de6256524d8907603d85a75_ebd04dbb901706c73de6256524d8907603d85a75/report/index.html

dataroaring · 2024-09-21T01:32:34Z

run buildall

doris-robot · 2024-09-21T02:11:37Z

TeamCity be ut coverage result:
Function Coverage: 37.28% (9607/25772)
Line Coverage: 28.67% (79483/277234)
Region Coverage: 28.12% (41107/146197)
Branch Coverage: 24.75% (20950/84640)
Coverage Report: http://coverage.selectdb-in.cc/coverage/80ce5b9bae03f59a1cce76683d5dd634ef47e1e6_80ce5b9bae03f59a1cce76683d5dd634ef47e1e6/report/index.html

gavinchou · 2024-09-21T03:21:10Z

no need to add an empty file, just use result = sql """ to check result.

gavinchou · 2024-09-21T03:21:29Z

+ time 600
+ }
+
+ qt_select "select * from ${tableName}"


use result = sql """ to get rid of empty .out file.

luwei16 · 2024-09-24T08:57:23Z

run p0

luwei16 · 2024-09-25T07:07:29Z

run buildall

doris-robot · 2024-09-25T07:37:54Z

TeamCity be ut coverage result:
Function Coverage: 37.29% (9623/25808)
Line Coverage: 28.70% (79642/277488)
Region Coverage: 28.11% (41160/146427)
Branch Coverage: 24.75% (20973/84728)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6e93479bdc4debee2b5072b17f5882116bdb753e_6e93479bdc4debee2b5072b17f5882116bdb753e/report/index.html

luwei16 · 2024-09-25T11:34:38Z

run cloud_p0

dataroaring

LGTM

github-actions · 2024-09-26T02:34:14Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-26T02:34:16Z

PR approved by anyone and no changes requested.

…t with empty strings during schema change (#41064) ### problem ``` insert into t1 (k1, k2, v1) value(1, '', 2); delete form t1 where k1 = 1 and k2 = ''; alter table modify column v1 string select * from t1 // expect 0 rows in return, but get 1 row. ```

…t with empty strings during schema change (apache#41064) ``` insert into t1 (k1, k2, v1) value(1, '', 2); delete form t1 where k1 = 1 and k2 = ''; alter table modify column v1 string select * from t1 // expect 0 rows in return, but get 1 row. ```

…t with empty strings during schema change (#41064) (#42427) ``` insert into t1 (k1, k2, v1) value(1, '', 2); delete form t1 where k1 = 1 and k2 = ''; alter table modify column v1 string select * from t1 // expect 0 rows in return, but get 1 row. ```

…t with empty strings during schema change (apache#41064) ### problem ``` insert into t1 (k1, k2, v1) value(1, '', 2); delete form t1 where k1 = 1 and k2 = ''; alter table modify column v1 string select * from t1 // expect 0 rows in return, but get 1 row. ```

[fix](schema change) fix delete predicate incorrect comparisons resul…
ebd04db
…t with empty strings during schema change

fix
80ce5b9

gavinchou requested changes Sep 21, 2024
View reviewed changes

luwei16 added 2 commits September 25, 2024 11:29

Merge remote-tracking branch 'doris-origin/master' into luwei/fix-sc-del
c5c932c

fix
6e93479

dataroaring approved these changes Sep 26, 2024
View reviewed changes

dataroaring added dev/2.1.x dev/2.0.x dev/3.0.x p0_b labels Sep 26, 2024

gavinchou approved these changes Sep 26, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024

github-actionsBot added the reviewed label Sep 26, 2024

gavinchou merged commit b0c41df into apache:masterSep 26, 2024

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Sep 26, 2024

gavinchou mentioned this pull request Oct 13, 2024
Release Note 3.0.2 #41558
Closed

yiguolei added dev/2.1.7-merged and removed dev/2.1.x labels Oct 24, 2024

dataroaring removed the dev/2.0.x label Oct 30, 2024

Uh oh!

Conversation

luwei16 commented Sep 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

problem

Uh oh!

doris-robot commented Sep 20, 2024

Uh oh!

luwei16 commented Sep 20, 2024

Uh oh!

doris-robot commented Sep 20, 2024

Uh oh!

dataroaring commented Sep 21, 2024

Uh oh!

doris-robot commented Sep 21, 2024

Uh oh!

gavinchouSep 21, 2024

Choose a reason for hiding this comment

Uh oh!

gavinchouSep 21, 2024

Choose a reason for hiding this comment

Uh oh!

luwei16 commented Sep 24, 2024

Uh oh!

luwei16 commented Sep 25, 2024

Uh oh!

doris-robot commented Sep 25, 2024

Uh oh!

luwei16 commented Sep 25, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 26, 2024

Uh oh!

github-actionsBot commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luwei16 commented Sep 20, 2024•
edited
Loading