Skip to content

[opt](blacklist) Backend should not be added to blacklist easily - #41170

Merged
yiguolei merged 6 commits into
apache:masterfrom
RoanHeNaN:opt-blacklist
Oct 9, 2024
Merged

[opt](blacklist) Backend should not be added to blacklist easily#41170
yiguolei merged 6 commits into
apache:masterfrom
RoanHeNaN:opt-blacklist

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Sep 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

To avoid false negative, backend will be added to black list when:

  • Try to add this backend multiple times(10) in do_add_backend_black_list_threshold_secs.

Backend will stay in black list in stay_in_backend_black_list_threshold_secs or it is alive.

@doris-robot

doris-robot commented Sep 23, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@RoanHeNaN

RoanHeNaN commented Sep 23, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaNRoanHeNaN changed the title [opt](coordinator) Choose random be if all backends are in black list[opt](blacklist) Backend should not be added to blacklist easilySep 25, 2024
@RoanHeNaN

RoanHeNaN commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN
RoanHeNaN marked this pull request as ready for review September 25, 2024 14:22
@RoanHeNaN

RoanHeNaN commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java Outdated
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java Outdated
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java Outdated
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java Outdated
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SimpleScheduler.java
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-common/src/main/java/org/apache/doris/common/Config.java Outdated
yiguolei
yiguolei reviewed Sep 26, 2024
View reviewed changes
Comment threadfe/fe-common/src/main/java/org/apache/doris/common/Config.java Outdated
@RoanHeNaN

RoanHeNaN commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

yiguolei
yiguolei previously approved these changes Sep 26, 2024
View reviewed changes
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@RoanHeNaN

RoanHeNaN commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run feut

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@RoanHeNaN

RoanHeNaN commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@RoanHeNaN

RoanHeNaN commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@yiguolei

yiguolei commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
yiguolei merged commit 35c47a8 into apache:masterOct 9, 2024
@RoanHeNaN
RoanHeNaN deleted the opt-blacklist branch October 9, 2024 12:16
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@RoanHeNaN@eldenmoon
[opt](blacklist) Backend should not be added to blacklist easily (apa…
be9e3fb
…che#41170)
To avoid false negative, backend will be added to black list when:
* Try to add this backend multiple times(10) in
`do_add_backend_black_list_threshold_secs`.
Backend will stay in black list in
`stay_in_backend_black_list_threshold_secs` or it is alive.
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@RoanHeNaN@cjj2010
[opt](blacklist) Backend should not be added to blacklist easily (apa…
61362f3
…che#41170)
To avoid false negative, backend will be added to black list when:
* Try to add this backend multiple times(10) in
`do_add_backend_black_list_threshold_secs`.
Backend will stay in black list in
`stay_in_backend_black_list_threshold_secs` or it is alive.
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@RoanHeNaNamorynan
[opt](blacklist) Backend should not be added to blacklist easily (apa…
0a51d95
…che#41170)
To avoid false negative, backend will be added to black list when:
* Try to add this backend multiple times(10) in
`do_add_backend_black_list_threshold_secs`.
Backend will stay in black list in
`stay_in_backend_black_list_threshold_secs` or it is alive.
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Oct 16, 2024
@RoanHeNaN
[opt](blacklist) Backend should not be added to blacklist easily (apa…
0c8c44e
…che#41170)
To avoid false negative, backend will be added to black list when:
* Try to add this backend multiple times(10) in
`do_add_backend_black_list_threshold_secs`.
Backend will stay in black list in
`stay_in_backend_black_list_threshold_secs` or it is alive.
@RoanHeNaNRoanHeNaN mentioned this pull request Oct 16, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 17, 2024
@RoanHeNaN
[opt](blacklist) Backend should not be added to blacklist easily#41170…
9103d77
… (#41957)
cherry pick from #41170
@RoanHeNaNRoanHeNaN mentioned this pull request Mar 17, 2025
Closed
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Mar 17, 2025
@RoanHeNaN
[opt](blacklist) Backend should not be added to blacklist easily (apa…
91492f9
…che#41170)
To avoid false negative, backend will be added to black list when:
* Try to add this backend multiple times(10) in
`do_add_backend_black_list_threshold_secs`.
Backend will stay in black list in
`stay_in_backend_black_list_threshold_secs` or it is alive.
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@RoanHeNaN@HappenLee
[opt](blacklist) Backend should not be added to blacklist easily (apa…
8bb14b7
…che#41170)
To avoid false negative, backend will be added to black list when:
* Try to add this backend multiple times(10) in
`do_add_backend_black_list_threshold_secs`.
Backend will stay in black list in
`stay_in_backend_black_list_threshold_secs` or it is alive.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@hello-stephenhello-stephenhello-stephen approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RoanHeNaN@doris-robot@yiguolei@hello-stephen