Skip to content

[fix](cloud) cloud group commit should skip repaly wal if label is already used and the txn state is committed or visible - #41262

Merged
gavinchou merged 2 commits into
apache:masterfrom
mymeiyi:fix-cloud-abort-txn
Sep 29, 2024
Merged

[fix](cloud) cloud group commit should skip repaly wal if label is already used and the txn state is committed or visible#41262
gavinchou merged 2 commits into
apache:masterfrom
mymeiyi:fix-cloud-abort-txn

Conversation

@mymeiyi

@mymeiyimymeiyi commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
[fix](cloud) cloud group commit should skip repaly wal if label is al…
3a8edec
…ready used and the txn state is committed or visible
@mymeiyi

mymeiyi commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.32% (9623/25786)
Line Coverage: 28.72% (79630/277288)
Region Coverage: 28.16% (41189/146252)
Branch Coverage: 24.79% (20990/84656)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3a8edec8dd2d46c4985c3b145368f59bf74ebc7c_3a8edec8dd2d46c4985c3b145368f59bf74ebc7c/report/index.html

gavinchou
gavinchou previously approved these changes Sep 25, 2024
View reviewed changes
@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@mymeiyi

mymeiyi commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

@mymeiyi

mymeiyi commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.29% (9624/25808)
Line Coverage: 28.71% (79676/277491)
Region Coverage: 28.13% (41191/146434)
Branch Coverage: 24.77% (20985/84736)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5a565380a2173fc44852159ac3f90ddc91a4f546_5a565380a2173fc44852159ac3f90ddc91a4f546/report/index.html

dataroaring
dataroaring approved these changes Sep 27, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 27, 2024
@github-actions

github-actionsBot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou
gavinchou merged commit 645268e into apache:masterSep 29, 2024
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Sep 29, 2024
@mymeiyi
[fix](cloud) cloud group commit should skip repaly wal if label is al…
6627c62
…ready used and the txn state is committed or visible (apache#41262)
@mymeiyimymeiyi mentioned this pull request Sep 29, 2024
Merged
gavinchou pushed a commit that referenced this pull request Sep 29, 2024
@mymeiyi@gavinchou
[fix](cloud) cloud group commit should skip repaly wal if label is al…
0d9cf32
…ready used and the txn state is committed or visible (#41262)
dataroaring pushed a commit to mymeiyi/doris that referenced this pull request Oct 10, 2024
@mymeiyi@dataroaring
[fix](cloud) cloud group commit should skip repaly wal if label is al…
dc09402
…ready used and the txn state is committed or visible (apache#41262)
dataroaring pushed a commit that referenced this pull request Oct 10, 2024
@mymeiyi
[fix](cloud) cloud group commit should skip repaly wal if label is al…
4c9ebbb
…ready used and the txn state is committed or visible (#41262) (#41461)
pick #41262
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@mymeiyi@cjj2010
[fix](cloud) cloud group commit should skip repaly wal if label is al…
ec0351a
…ready used and the txn state is committed or visible (apache#41262)
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@mymeiyiamorynan
[fix](cloud) cloud group commit should skip repaly wal if label is al…
81b2cad
…ready used and the txn state is committed or visible (apache#41262)
@gavinchougavinchou mentioned this pull request Oct 13, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@mymeiyi@HappenLee
[fix](cloud) cloud group commit should skip repaly wal if label is al…
748d18e
…ready used and the txn state is committed or visible (apache#41262)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01liaoxin01liaoxin01 approved these changes
@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchougavinchou left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mymeiyi@doris-robot@gavinchou@liaoxin01@dataroaring