Skip to content

[fix](cloud) abortTransaction does not handle response code - #41275

Merged
dataroaring merged 2 commits into
apache:masterfrom
mymeiyi:fix-cloud-fe-abort-txn
Sep 26, 2024
Merged

[fix](cloud) abortTransaction does not handle response code#41275
dataroaring merged 2 commits into
apache:masterfrom
mymeiyi:fix-cloud-fe-abort-txn

Conversation

@mymeiyi

@mymeiyimymeiyi commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
mymeiyiforce-pushed the fix-cloud-fe-abort-txn branch from 3dbda50 to 7333641CompareSeptember 25, 2024 07:20
dataroaring
dataroaring previously approved these changes Sep 25, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@mymeiyi

mymeiyi commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@mymeiyimymeiyi changed the title [fix](cloud) abortTransaction does not handle reponse code[fix](cloud) abortTransaction does not handle response codeSep 25, 2024
@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40665 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7333641dbc91e9a85e2bc9742793e247fe4a64ff, data reload: false
------ Round 1 ----------------------------------
q1	17623	7404	7261	7261
q2	2009	287	286	286
q3	12231	1082	1164	1082
q4	10564	786	688	688
q5	7782	2900	2800	2800
q6	232	152	146	146
q7	981	602	605	602
q8	9363	1955	1963	1955
q9	6977	6467	6359	6359
q10	6969	2248	2330	2248
q11	434	248	243	243
q12	411	216	204	204
q13	17773	3023	2941	2941
q14	245	222	225	222
q15	577	543	526	526
q16	670	631	608	608
q17	989	566	558	558
q18	7201	6589	6729	6589
q19	1423	998	1111	998
q20	587	287	273	273
q21	4202	3230	3080	3080
q22	1102	996	997	996
Total cold run time: 110345 ms
Total hot run time: 40665 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7248	7208	7211	7208
q2	326	228	224	224
q3	3034	2929	2979	2929
q4	2095	1829	1772	1772
q5	5663	5654	5775	5654
q6	225	144	142	142
q7	2239	1844	1826	1826
q8	3344	3509	3507	3507
q9	9047	9026	8908	8908
q10	3578	3575	3594	3575
q11	590	483	478	478
q12	806	633	610	610
q13	8727	3191	3142	3142
q14	309	267	284	267
q15	587	540	521	521
q16	692	677	676	676
q17	1841	1647	1617	1617
q18	8371	7909	7746	7746
q19	1726	1669	1481	1481
q20	2111	1872	1925	1872
q21	5521	5327	5387	5327
q22	1134	1075	1016	1016
Total cold run time: 69214 ms
Total hot run time: 60498 ms

@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191895 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7333641dbc91e9a85e2bc9742793e247fe4a64ff, data reload: false
query1	962	398	385	385
query2	6351	2074	2037	2037
query3	8689	197	204	197
query4	33934	23687	23607	23607
query5	3403	479	486	479
query6	261	170	160	160
query7	4190	320	311	311
query8	289	213	207	207
query9	9633	2676	2667	2667
query10	460	291	274	274
query11	17924	15224	15235	15224
query12	147	97	97	97
query13	1538	429	422	422
query14	9547	7129	7533	7129
query15	241	172	176	172
query16	7824	465	481	465
query17	1672	610	607	607
query18	2123	325	332	325
query19	382	161	164	161
query20	123	113	125	113
query21	217	106	113	106
query22	4770	4647	4498	4498
query23	36946	34730	34335	34335
query24	11176	2854	2847	2847
query25	522	408	419	408
query26	731	166	161	161
query27	2205	299	305	299
query28	7301	2466	2461	2461
query29	650	442	428	428
query30	256	159	160	159
query31	1047	784	797	784
query32	90	54	56	54
query33	748	297	299	297
query34	925	522	485	485
query35	878	731	725	725
query36	1105	935	982	935
query37	150	96	88	88
query38	4039	3958	3942	3942
query39	1506	1417	1400	1400
query40	218	98	100	98
query41	53	44	49	44
query42	123	96	95	95
query43	521	480	491	480
query44	1232	799	786	786
query45	197	165	163	163
query46	1141	697	737	697
query47	1941	1835	1863	1835
query48	454	370	386	370
query49	882	421	408	408
query50	816	417	424	417
query51	6959	6899	6798	6798
query52	99	92	88	88
query53	261	185	202	185
query54	1248	458	474	458
query55	81	74	76	74
query56	269	262	252	252
query57	1200	1093	1107	1093
query58	236	246	241	241
query59	3122	3055	2936	2936
query60	303	260	270	260
query61	107	105	108	105
query62	820	673	663	663
query63	221	198	189	189
query64	4055	661	651	651
query65	3285	3174	3189	3174
query66	785	306	329	306
query67	16143	15674	15431	15431
query68	5072	567	567	567
query69	544	298	307	298
query70	1214	1148	1140	1140
query71	369	284	269	269
query72	7135	3957	3966	3957
query73	773	335	354	335
query74	10339	9152	8985	8985
query75	3522	2672	2688	2672
query76	3251	978	951	951
query77	524	297	295	295
query78	10254	9366	9153	9153
query79	1645	602	594	594
query80	1247	471	467	467
query81	587	241	241	241
query82	627	143	138	138
query83	297	146	139	139
query84	265	75	80	75
query85	1569	315	300	300
query86	471	314	303	303
query87	4471	4303	4386	4303
query88	4023	2412	2364	2364
query89	407	293	285	285
query90	1992	185	181	181
query91	175	142	145	142
query92	62	49	50	49
query93	2299	531	559	531
query94	988	301	296	296
query95	365	259	255	255
query96	639	285	286	285
query97	3272	3116	3146	3116
query98	225	198	189	189
query99	1688	1296	1272	1272
Total cold run time: 302038 ms
Total hot run time: 191895 ms

@doris-robot

doris-robot commented Sep 25, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 32.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7333641dbc91e9a85e2bc9742793e247fe4a64ff, data reload: false
query1	0.04	0.05	0.04
query2	0.06	0.03	0.02
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.51	0.52	0.52
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.03	0.03	0.04
query9	0.57	0.52	0.51
query10	0.55	0.57	0.55
query11	0.13	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.58	0.60
query14	2.94	2.98	3.11
query15	0.91	0.82	0.81
query16	0.39	0.39	0.38
query17	1.05	1.08	1.05
query18	0.20	0.20	0.20
query19	1.98	1.87	2.02
query20	0.01	0.01	0.01
query21	15.35	0.58	0.58
query22	2.78	1.65	1.11
query23	17.01	0.87	0.81
query24	2.96	0.93	1.60
query25	0.23	0.14	0.03
query26	0.58	0.14	0.14
query27	0.04	0.04	0.04
query28	10.33	1.09	1.06
query29	12.61	3.31	3.28
query30	0.25	0.06	0.06
query31	2.86	0.37	0.39
query32	3.27	0.47	0.46
query33	3.00	3.03	3.05
query34	16.72	4.44	4.47
query35	4.50	4.43	4.55
query36	0.67	0.50	0.48
query37	0.09	0.05	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.15	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.75 s
Total hot run time: 32.2 s

gavinchou
gavinchou previously approved these changes Sep 25, 2024
View reviewed changes
@mymeiyi
mymeiyi dismissed stale reviews from gavinchou and dataroaring via 49b1b4dSeptember 26, 2024 02:35
@mymeiyi

mymeiyi commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40938 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 49b1b4d4bf6c3e91c7c962735db20feb563f5d57, data reload: false
------ Round 1 ----------------------------------
q1	17767	7482	7313	7313
q2	2018	298	269	269
q3	12281	1100	1199	1100
q4	10561	713	795	713
q5	7747	2916	2823	2823
q6	243	150	148	148
q7	972	631	614	614
q8	9363	1942	1979	1942
q9	6563	6443	6430	6430
q10	6957	2291	2348	2291
q11	434	252	250	250
q12	411	220	216	216
q13	17804	2974	3018	2974
q14	237	209	224	209
q15	566	537	515	515
q16	674	631	617	617
q17	981	516	511	511
q18	7318	6683	6801	6683
q19	1404	1095	1004	1004
q20	483	212	201	201
q21	4076	3346	3106	3106
q22	1096	1029	1009	1009
Total cold run time: 109956 ms
Total hot run time: 40938 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7228	7273	7208	7208
q2	330	230	222	222
q3	3095	3003	2974	2974
q4	2080	1810	1804	1804
q5	5713	5679	5788	5679
q6	239	148	151	148
q7	2283	1819	1877	1819
q8	3403	3571	3549	3549
q9	8998	9014	9050	9014
q10	3542	3566	3587	3566
q11	590	501	464	464
q12	829	670	634	634
q13	9743	3160	3186	3160
q14	297	268	277	268
q15	572	530	526	526
q16	712	660	683	660
q17	1845	1634	1624	1624
q18	8301	7713	7727	7713
q19	1721	1579	1609	1579
q20	2165	1926	1887	1887
q21	5486	5489	5452	5452
q22	1135	1047	1024	1024
Total cold run time: 70307 ms
Total hot run time: 60974 ms

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192955 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 49b1b4d4bf6c3e91c7c962735db20feb563f5d57, data reload: false
query1	949	391	380	380
query2	6260	2084	2099	2084
query3	8694	199	204	199
query4	33548	23599	23529	23529
query5	4058	476	462	462
query6	290	180	167	167
query7	4209	323	315	315
query8	303	238	236	236
query9	9582	2669	2668	2668
query10	482	298	298	298
query11	17953	15365	15285	15285
query12	146	105	96	96
query13	1548	441	414	414
query14	8924	7732	7538	7538
query15	253	176	176	176
query16	8113	475	521	475
query17	1655	608	608	608
query18	2156	346	331	331
query19	387	164	162	162
query20	121	111	119	111
query21	223	112	135	112
query22	4826	4456	4609	4456
query23	35396	34808	34602	34602
query24	11296	2816	2850	2816
query25	593	407	414	407
query26	723	172	165	165
query27	2019	305	309	305
query28	6615	2447	2427	2427
query29	757	446	438	438
query30	254	162	155	155
query31	1015	818	782	782
query32	100	53	59	53
query33	759	309	300	300
query34	927	492	519	492
query35	866	741	737	737
query36	1116	939	995	939
query37	157	83	85	83
query38	4049	3967	3907	3907
query39	1511	1432	1416	1416
query40	219	101	102	101
query41	53	50	52	50
query42	124	96	97	96
query43	542	510	515	510
query44	1298	808	791	791
query45	197	167	171	167
query46	1147	719	709	709
query47	1926	1828	1852	1828
query48	508	372	375	372
query49	843	399	385	385
query50	841	426	408	408
query51	7089	6977	6870	6870
query52	101	89	86	86
query53	259	178	187	178
query54	1137	463	476	463
query55	82	73	80	73
query56	287	285	275	275
query57	1211	1095	1096	1095
query58	235	225	234	225
query59	3112	3120	2866	2866
query60	301	263	267	263
query61	110	105	106	105
query62	813	674	657	657
query63	223	196	188	188
query64	3687	663	640	640
query65	3249	3207	3181	3181
query66	751	311	308	308
query67	16258	15694	15561	15561
query68	4590	579	572	572
query69	578	308	317	308
query70	1197	1088	1139	1088
query71	404	288	286	286
query72	7577	4007	3818	3818
query73	767	358	355	355
query74	10471	9126	9035	9035
query75	4264	2694	2669	2669
query76	3477	973	853	853
query77	697	302	286	286
query78	10506	9640	9551	9551
query79	3887	606	596	596
query80	2882	455	469	455
query81	606	239	246	239
query82	716	142	141	141
query83	323	141	144	141
query84	291	79	89	79
query85	1523	300	302	300
query86	412	311	284	284
query87	4579	4252	4312	4252
query88	4515	2413	2384	2384
query89	412	291	285	285
query90	2124	191	190	190
query91	179	145	141	141
query92	63	50	52	50
query93	3137	565	553	553
query94	1138	308	269	269
query95	369	275	265	265
query96	648	282	287	282
query97	3291	3145	3135	3135
query98	231	202	200	200
query99	1563	1316	1331	1316
Total cold run time: 306853 ms
Total hot run time: 192955 ms

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.98 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 49b1b4d4bf6c3e91c7c962735db20feb563f5d57, data reload: false
query1	0.05	0.05	0.05
query2	0.06	0.02	0.03
query3	0.23	0.07	0.06
query4	1.66	0.10	0.10
query5	0.52	0.49	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.56	0.51	0.49
query10	0.56	0.56	0.56
query11	0.14	0.11	0.10
query12	0.13	0.11	0.11
query13	0.60	0.60	0.60
query14	3.03	2.95	2.96
query15	0.89	0.82	0.82
query16	0.38	0.39	0.39
query17	1.08	0.99	1.05
query18	0.19	0.20	0.20
query19	1.95	1.84	2.03
query20	0.01	0.01	0.01
query21	15.36	0.63	0.59
query22	2.93	2.17	1.52
query23	17.34	0.90	0.71
query24	2.83	0.38	0.75
query25	0.20	0.07	0.10
query26	0.44	0.14	0.13
query27	0.06	0.05	0.05
query28	11.66	1.10	1.08
query29	12.59	3.32	3.32
query30	0.24	0.06	0.05
query31	2.88	0.38	0.38
query32	3.27	0.48	0.47
query33	3.02	3.02	3.08
query34	16.89	4.47	4.43
query35	4.49	4.52	4.47
query36	0.68	0.49	0.47
query37	0.09	0.07	0.06
query38	0.04	0.03	0.03
query39	0.03	0.03	0.02
query40	0.15	0.12	0.12
query41	0.07	0.03	0.02
query42	0.04	0.03	0.02
query43	0.03	0.02	0.02
Total cold run time: 108.57 s
Total hot run time: 31.98 s

dataroaring
dataroaring approved these changes Sep 26, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2024
@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring
dataroaring merged commit f4c4b27 into apache:masterSep 26, 2024
gavinchou pushed a commit that referenced this pull request Sep 28, 2024
@mymeiyi@gavinchou
[fix](cloud) abortTransaction does not handle response code (#41275)
dce84b2
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@mymeiyi@cjj2010
[fix](cloud) abortTransaction does not handle response code (apache#4…
2e43d90
…1275)
@gavinchougavinchou mentioned this pull request Oct 13, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@mymeiyi@HappenLee
[fix](cloud) abortTransaction does not handle response code (apache#4…
1c8ed47
…1275)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobhan1bobhan1bobhan1 approved these changes
@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchougavinchou left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.2-mergedp0_creviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mymeiyi@doris-robot@gavinchou@bobhan1@dataroaring