Uh oh!
There was an error while loading. Please reload this page.
[improve](array-funcs) accelerate arrays_overlap by inverted index (#41161) - #41286
Merged
Merged
Conversation
…he#41161) support arrays_overlap with invertedIndex ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
doris-robot
commented
Sep 25, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
amorynan
commented
Sep 25, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
| ColumnPtr arg_column = arguments[0].column; | ||
| DataTypePtr arg_type = arguments[0].type; | ||
| if ((is_column_nullable(*arg_column) && !is_column_const(*remove_nullable(arg_column))) || | ||
| !is_column_const(*arg_column)) { |
Contributor
There was a problem hiding this comment.
logic error: if arg_column is nullable , it's always true.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
amorynan
commented
Sep 28, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
amorynan pushed a commit
to amorynan/doris
that referenced
this pull request
Oct 18, 2024
…pache#41161) (apache#41286) support arrays_overlap with invertedIndex
eldenmoon pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support arrays_overlap with invertedIndex
Proposed changes
Issue Number: close #xxx
Proposed changes
Issue Number: close #xxx