Skip to content

[cherry-pick](branch-21) fix tablet sink shuffle without project not match the output tuple (#40299)(#41293) - #41327

Merged
yiguolei merged 3 commits into
apache:branch-2.1from
zhangstar333:branch-2.1
Oct 14, 2024
Merged

[cherry-pick](branch-21) fix tablet sink shuffle without project not match the output tuple (#40299)(#41293)#41327
yiguolei merged 3 commits into
apache:branch-2.1from
zhangstar333:branch-2.1

Conversation

@zhangstar333

@zhangstar333zhangstar333 commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

cherry-pick from master (#40299)(#41293)

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333

zhangstar333 commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.15% (9345/25853)
Line Coverage: 27.68% (76787/277454)
Region Coverage: 26.43% (39399/149066)
Branch Coverage: 23.23% (20061/86376)
Coverage Report: http://coverage.selectdb-in.cc/coverage/379180b6d748e1e745f77a6a3d34941cf96a0b68_379180b6d748e1e745f77a6a3d34941cf96a0b68/report/index.html

@yiguolei

yiguolei commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

github-actionsBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 10, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.08% (9340/25889)
Line Coverage: 27.65% (76726/277481)
Region Coverage: 26.44% (39385/148956)
Branch Coverage: 23.23% (20035/86264)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9431202f949f983c5d3dfeee3b93156cc5dedff6_9431202f949f983c5d3dfeee3b93156cc5dedff6/report/index.html

zhangstar333and others added 3 commits October 12, 2024 11:41
@zhangstar333
[Bug](exchange) fix tablet sink shuffle without project not match the…
5c91126
… output tuple (apache#40299)
```
INSERT INTO tbl_4 SELECT k1, k2, k2 FROM tbl_1;
the tbl_1 have k1,k2 columns
the tbl_4 have k1,k2,v columns
if without project expr, will be only two columns not match the output tuple.
```
the co-auther of FE code from @starocean999
@zhangstar333
[Bug](tablet-shuffle) tablet shuffle sink data should use input block…
bc0d1e5
… rather than convert_block (apache#41293)
## Proposed changes
the convert_block is empty firstly, after execute exprs will be filled.
so convert_block maybe different with block.
so when send data we still need use block.
<!--Describe your changes.-->
@zhangstar333
update
2bd700d
@zhangstar333

zhangstar333 commented Oct 12, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 12, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.02% (9337/25919)
Line Coverage: 27.61% (76717/277857)
Region Coverage: 26.41% (39396/149178)
Branch Coverage: 23.21% (20051/86404)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2bd700d38a70b70d43a1c6695baacf81aed63a2b_2bd700d38a70b70d43a1c6695baacf81aed63a2b/report/index.html

@yiguolei
yiguolei merged commit d97642e into apache:branch-2.1Oct 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangstar333@doris-robot@yiguolei