Skip to content

[fix](snapshot) Link binlog files according to consistent rowsets #41319 - #41344

Merged
w41ter merged 2 commits into
apache:branch-2.0from
w41ter:pick_41319_to_origin_branch-2.0
Sep 30, 2024
Merged

[fix](snapshot) Link binlog files according to consistent rowsets #41319#41344
w41ter merged 2 commits into
apache:branch-2.0from
w41ter:pick_41319_to_origin_branch-2.0

Conversation

@w41ter

@w41terw41ter commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

cherry pick from #41319

@w41ter
[fix](snapshot) Link binlog files according to consistent rowsets (ap…
5536505
…ache#41319)
In previous implementations, binlog files would be linked according to
making snapshot requests. However, sometimes not all requests can be
executed directly. For example, when a certain version in
missing_version does not exist, it will fallback to the full snapshot.
Therefore, it is correct to link binlog files according to consistent
rowsets.
@w41ter

w41ter commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.81% (8146/21545)
Line Coverage: 29.55% (67055/226934)
Region Coverage: 29.02% (34560/119108)
Branch Coverage: 24.93% (17805/71430)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5536505f1a82726175c498bb9ca3d39fd60633d0_5536505f1a82726175c498bb9ca3d39fd60633d0/report/index.html

@w41ter

w41ter commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Sep 26, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.81% (8146/21545)
Line Coverage: 29.55% (67062/226934)
Region Coverage: 29.02% (34564/119108)
Branch Coverage: 24.93% (17808/71430)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bd0890adcde9500e1edf48a4ecbddefa2e5947d6_bd0890adcde9500e1edf48a4ecbddefa2e5947d6/report/index.html

@hello-stephen

hello-stephen commented Sep 29, 2024

Copy link
Copy Markdown
Contributor

run external

@w41ter
w41ter merged commit 4058860 into apache:branch-2.0Sep 30, 2024
@w41ter
w41ter deleted the pick_41319_to_origin_branch-2.0 branch September 30, 2024 02:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@w41ter@doris-robot@hello-stephen