Uh oh!
There was an error while loading. Please reload this page.
[fix](bloom filter)Fix drop column with bloom filter - #41369
Merged
Conversation
doris-robot
commented
Sep 26, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
qidaye
commented
Sep 26, 2024
ContributorAuthor
run buildall |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
doris-robot
commented
Sep 26, 2024
TPC-H: Total hot run time: 40697 ms |
doris-robot
commented
Sep 26, 2024
TPC-DS: Total hot run time: 192543 ms |
doris-robot
commented
Sep 26, 2024
ClickBench: Total hot run time: 32.72 s |
qidayeforce-pushed
the
fix_drop_column_with_bf
branch
from
October 8, 2024 02:45
96977a4 to
c80fe25Compareqidaye
commented
Oct 8, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Oct 8, 2024
TPC-H: Total hot run time: 40724 ms |
doris-robot
commented
Oct 8, 2024
TPC-DS: Total hot run time: 192771 ms |
doris-robot
commented
Oct 8, 2024
ClickBench: Total hot run time: 32.31 s |
qidaye added a commit
to qidaye/incubator-doris
that referenced
this pull request
Oct 11, 2024
qidaye added a commit
to qidaye/incubator-doris
that referenced
this pull request
Oct 11, 2024
| } | ||
| } | ||
| olapTable.setBloomFilterInfo(newBfCols, olapTable.getBfFpp()); | ||
| } |
Member
There was a problem hiding this comment.
may be this can be better
Set<String> bfCols = olapTable.getCopiedBfColumns();
if (bfCols != null) {
Set<String> newBfCols = bfCols.stream()
.filter(bfCol -> !bfCol.equalsIgnoreCase(dropColName))
.collect(Collectors.toSet());
olapTable.setBloomFilterInfo(newBfCols, olapTable.getBfFpp());
}
yiguolei pushed a commit
that referenced
this pull request
Oct 12, 2024
xiaokang pushed a commit
that referenced
this pull request
Oct 14, 2024
qidaye added a commit
to qidaye/incubator-doris
that referenced
this pull request
Nov 6, 2024
airborne12 pushed a commit
that referenced
this pull request
Nov 6, 2024
16 tasks
qidaye pushed a commit
that referenced
this pull request
Nov 22, 2024
Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: #41369 ### Release note Fix drop column with bloom filter index
qidaye pushed a commit
to qidaye/incubator-doris
that referenced
this pull request
Nov 22, 2024
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 Fix drop column with bloom filter index
qidaye pushed a commit
to qidaye/incubator-doris
that referenced
this pull request
Nov 22, 2024
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 Fix drop column with bloom filter index
qidaye pushed a commit
to qidaye/incubator-doris
that referenced
this pull request
Nov 22, 2024
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 Fix drop column with bloom filter index
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
) Problem Summary: 1. When drop column with bloom filter, we modify the bloom filter column info 2. When replay editLog, we rebuild bloom filter info by table schema. Related PR: apache#41369 ### Release note Fix drop column with bloom filter index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close#41368