Uh oh!
There was an error while loading. Please reload this page.
[feat](job)Implementing Job in Nereids - #41391
Conversation
doris-robot
commented
Sep 27, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
CalvinKirs
commented
Oct 6, 2024
run buildall |
doris-robot
commented
Oct 6, 2024
TPC-H: Total hot run time: 40888 ms |
doris-robot
commented
Oct 6, 2024
TPC-DS: Total hot run time: 192017 ms |
doris-robot
commented
Oct 6, 2024
ClickBench: Total hot run time: 32.76 s |
CalvinKirs
commented
Oct 6, 2024
run buildall |
doris-robot
commented
Oct 6, 2024
TPC-H: Total hot run time: 40872 ms |
doris-robot
commented
Oct 6, 2024
TPC-DS: Total hot run time: 191587 ms |
doris-robot
commented
Oct 6, 2024
ClickBench: Total hot run time: 33.02 s |
8ddd998 to
2f13bb9CompareCalvinKirs
commented
Oct 6, 2024
run buildall |
doris-robot
commented
Oct 6, 2024
TPC-H: Total hot run time: 40702 ms |
doris-robot
commented
Oct 6, 2024
TPC-DS: Total hot run time: 192290 ms |
doris-robot
commented
Oct 6, 2024
ClickBench: Total hot run time: 33.36 s |
CalvinKirs
commented
Oct 6, 2024
run buildall |
doris-robot
commented
Oct 6, 2024
TPC-H: Total hot run time: 40382 ms |
doris-robot
commented
Oct 6, 2024
TPC-DS: Total hot run time: 192027 ms |
| | SHOW CREATE MATERIALIZED VIEW mvName=multipartIdentifier #showCreateMTMV | ||
| ; | ||
| jobScheduleStatement |
There was a problem hiding this comment.
| jobScheduleStatement | |
| supportedJobStatement |
| long base = TimeUnit.MINUTES.toMillis(connectionAgeBase); | ||
| long now = System.currentTimeMillis(); | ||
| long rand = random.nextLong(base); | ||
| long rand = random.nextLong() % base; |
There was a problem hiding this comment.
already fixed, please rebase to newest master
| Optional<Long> interval = ctx.timeInterval == null ? Optional.empty() : | ||
| Optional.of(Long.valueOf(ctx.timeInterval.getText())); | ||
| Optional<String> intervalUnit = ctx.timeUnit == null ? Optional.empty() : Optional.of(ctx.timeUnit.getText()); | ||
| String commentSpec = ctx.commentSpec() == null ? "''" : ctx.commentSpec().STRING_LITERAL().getText(); |
There was a problem hiding this comment.
could u have add override visitCommentSpec, let it return processed comment string?
| sql """ | ||
| SET enable_fallback_to_original_planner=false; | ||
| """ |
There was a problem hiding this comment.
this variable has been removed and u do not need to add it
| ; | ||
| jobScheduleStatement | ||
| : CREATE JOB label=multipartIdentifier ON SCHEDULE |
There was a problem hiding this comment.
remove create job syntax in sql_parser.cup and remove CreateJobStmt.java
There was a problem hiding this comment.
I want to directly pick to 2.1, as 2.1 allows for a rollback. Therefore, this change will be provided in the next PR.:)
morningman
commented
Oct 11, 2024
run buildall |
PR approved by at least one committer and no changes requested. |
CalvinKirs
commented
Oct 11, 2024
run feut |
CalvinKirs
commented
Oct 11, 2024
run cloud_p0 |
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency.
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency. (cherry picked from commit 334b473)
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency. (cherry picked from commit 334b473)
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency. (cherry picked from commit 334b473) #41391
## Proposed changes The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency.
Proposed changes
The JOB's execution SQL is currently defined by an older CUP file, which causes some issues with lexical analysis in the new optimizer as it doesn't pass under the old optimizer. Since the JOB's underlying execution already uses the new optimizer, we're planning to fully migrate to ANTLR4 for consistency.