Skip to content

[opt](compile) ensure fe-core compile with language level 8 - #41417

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:ensure_jdk8
Sep 30, 2024
Merged

[opt](compile) ensure fe-core compile with language level 8#41417
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:ensure_jdk8

Conversation

@morrySnow

@morrySnowmorrySnow commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

not change all project to level 8 because java-common use sun.misc.unsafe cannot compile with level 8

@doris-robot

doris-robot commented Sep 27, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow

morrySnow commented Sep 27, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 27, 2024
@github-actions

github-actionsBot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Sep 27, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40626 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ee01886b0769ccf60dbd3eff25abf692e7cc7aaa, data reload: false
------ Round 1 ----------------------------------
q1	17629	7482	7264	7264
q2	2019	278	292	278
q3	11976	1046	1161	1046
q4	10549	747	809	747
q5	7742	2844	2709	2709
q6	243	151	147	147
q7	960	621	612	612
q8	9362	1919	1989	1919
q9	6998	6424	6383	6383
q10	6969	2296	2304	2296
q11	450	244	244	244
q12	430	222	224	222
q13	17785	2990	2989	2989
q14	243	211	208	208
q15	558	523	519	519
q16	656	593	579	579
q17	973	522	547	522
q18	7297	6524	6782	6524
q19	1400	1099	1070	1070
q20	459	209	204	204
q21	3945	3186	3151	3151
q22	1097	1002	993	993
Total cold run time: 109740 ms
Total hot run time: 40626 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7203	7269	7173	7173
q2	332	226	230	226
q3	2942	2929	2964	2929
q4	2118	1880	1842	1842
q5	5791	5740	5741	5740
q6	232	144	146	144
q7	2205	1853	1818	1818
q8	3369	3593	3425	3425
q9	8945	8854	8905	8854
q10	3580	3564	3542	3542
q11	596	493	476	476
q12	846	635	623	623
q13	9467	3185	3157	3157
q14	311	294	279	279
q15	584	513	546	513
q16	691	655	647	647
q17	1817	1626	1598	1598
q18	8355	7817	7711	7711
q19	1700	1366	1390	1366
q20	2093	1866	1910	1866
q21	5600	5458	5301	5301
q22	1121	1071	1041	1041
Total cold run time: 69898 ms
Total hot run time: 60271 ms

@doris-robot

doris-robot commented Sep 27, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191644 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ee01886b0769ccf60dbd3eff25abf692e7cc7aaa, data reload: false
query1	945	388	396	388
query2	6258	2064	1997	1997
query3	8683	200	206	200
query4	33577	23482	23331	23331
query5	3514	472	467	467
query6	272	168	169	168
query7	4204	291	304	291
query8	271	216	220	216
query9	9526	2639	2635	2635
query10	461	291	293	291
query11	17950	15108	15142	15108
query12	175	97	101	97
query13	1526	428	429	428
query14	9556	7555	7448	7448
query15	250	175	175	175
query16	8012	476	444	444
query17	1669	619	600	600
query18	2149	335	313	313
query19	386	161	157	157
query20	126	113	120	113
query21	214	107	109	107
query22	4893	4580	4493	4493
query23	35184	34036	34092	34036
query24	11068	2841	2939	2841
query25	631	410	410	410
query26	1337	162	166	162
query27	2571	296	299	296
query28	7692	2404	2394	2394
query29	865	454	433	433
query30	280	161	153	153
query31	1060	795	788	788
query32	93	56	54	54
query33	767	304	294	294
query34	900	500	515	500
query35	836	728	722	722
query36	1077	930	948	930
query37	152	91	88	88
query38	4007	3916	3918	3916
query39	1459	1454	1415	1415
query40	248	98	97	97
query41	52	50	46	46
query42	122	98	97	97
query43	524	502	475	475
query44	1213	782	789	782
query45	194	163	167	163
query46	1174	714	715	714
query47	1943	1791	1810	1791
query48	454	373	370	370
query49	932	445	432	432
query50	844	403	418	403
query51	7150	6981	6871	6871
query52	105	87	90	87
query53	255	183	184	183
query54	1290	474	472	472
query55	77	78	76	76
query56	276	275	270	270
query57	1207	1085	1085	1085
query58	232	229	241	229
query59	3251	3036	2831	2831
query60	283	260	259	259
query61	101	98	105	98
query62	882	664	679	664
query63	215	188	183	183
query64	4995	661	622	622
query65	3514	3198	3227	3198
query66	1417	309	315	309
query67	15977	15576	15715	15576
query68	4379	585	566	566
query69	518	284	293	284
query70	1177	1083	1118	1083
query71	370	288	265	265
query72	7269	4079	4032	4032
query73	760	346	351	346
query74	10325	9070	9123	9070
query75	3375	2683	2695	2683
query76	2906	846	921	846
query77	473	309	290	290
query78	10579	9695	9522	9522
query79	1512	580	597	580
query80	2317	448	456	448
query81	567	240	243	240
query82	745	131	139	131
query83	291	141	138	138
query84	281	77	87	77
query85	1558	294	282	282
query86	400	301	305	301
query87	4592	4398	4253	4253
query88	3616	2371	2351	2351
query89	405	282	280	280
query90	2272	186	184	184
query91	191	141	140	140
query92	67	46	47	46
query93	1082	533	534	533
query94	1176	296	292	292
query95	363	263	257	257
query96	608	281	288	281
query97	3263	3121	3081	3081
query98	219	200	192	192
query99	1671	1288	1292	1288
Total cold run time: 302850 ms
Total hot run time: 191644 ms

@doris-robot

doris-robot commented Sep 27, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 32.15 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee01886b0769ccf60dbd3eff25abf692e7cc7aaa, data reload: false
query1	0.05	0.05	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.65	0.10	0.10
query5	0.53	0.52	0.52
query6	1.14	0.74	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.55	0.51	0.49
query10	0.57	0.59	0.54
query11	0.13	0.10	0.10
query12	0.14	0.11	0.10
query13	0.61	0.60	0.59
query14	2.72	2.73	2.80
query15	0.90	0.83	0.82
query16	0.38	0.38	0.40
query17	1.05	0.99	1.00
query18	0.21	0.20	0.19
query19	1.94	1.82	1.97
query20	0.02	0.01	0.01
query21	15.35	0.62	0.57
query22	2.45	2.66	1.49
query23	17.02	1.02	0.82
query24	3.05	1.00	0.72
query25	0.31	0.10	0.08
query26	0.40	0.14	0.14
query27	0.05	0.05	0.04
query28	11.05	1.10	1.07
query29	12.55	3.32	3.35
query30	0.24	0.07	0.06
query31	2.89	0.38	0.37
query32	3.28	0.47	0.46
query33	2.96	3.01	3.00
query34	16.90	4.48	4.49
query35	4.54	4.48	4.52
query36	0.67	0.48	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.09	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 107.14 s
Total hot run time: 32.15 s

@morrySnow

morrySnow commented Sep 27, 2024

Copy link
Copy Markdown
ContributorAuthor

run p0

@morrySnow

morrySnow commented Sep 27, 2024

Copy link
Copy Markdown
ContributorAuthor

run external

@morrySnow

morrySnow commented Sep 30, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

CalvinKirs
CalvinKirs reviewed Sep 30, 2024
View reviewed changes
Comment threadfe/fe-core/pom.xml
@morrySnow
morrySnow merged commit e8fb88f into apache:masterSep 30, 2024
@morrySnow
morrySnow deleted the ensure_jdk8 branch September 30, 2024 08:06
@zy-kkkzy-kkk mentioned this pull request Oct 8, 2024
Closed
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@morrySnow@dataroaring
[opt](compile) ensure fe-core compile with language level 8 (#41417)
3325c96
not change all module to level 8 because java-common use
sun.misc.unsafe that cannot compile with level 8
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@morrySnow@eldenmoon
[opt](compile) ensure fe-core compile with language level 8 (apache#4…
5407244
…1417)
not change all module to level 8 because java-common use
sun.misc.unsafe that cannot compile with level 8
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@morrySnow@cjj2010
[opt](compile) ensure fe-core compile with language level 8 (apache#4…
b442f47
…1417)
not change all module to level 8 because java-common use
sun.misc.unsafe that cannot compile with level 8
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@morrySnowamorynan
[opt](compile) ensure fe-core compile with language level 8 (apache#4…
9f81361
…1417)
not change all module to level 8 because java-common use
sun.misc.unsafe that cannot compile with level 8
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morrySnow@HappenLee
[opt](compile) ensure fe-core compile with language level 8 (apache#4…
422f13a
…1417)
not change all module to level 8 because java-common use
sun.misc.unsafe that cannot compile with level 8
@heguanhuiheguanhui mentioned this pull request May 28, 2026
Merged
morrySnow pushed a commit that referenced this pull request Jun 11, 2026
@heguanhui
[fix](fe) Update fe-core compiler release level from 8 to 17 (#63843)
ca20f0d
### What problem does this PR solve?
Issue Number: close#63728
Problem Summary: FE depends on JDK 17 for compilation (parent pom set
`maven.compiler.source/target=17` since PR #62221), but fe-core's
`maven-compiler-plugin` still had `<release>8</release>` as a leftover
from PR #41417. This caused FE unit tests using JDK 17 APIs (e.g.,
`Random.nextLong(long)`) to fail at compile time. Additionally,
`PatternDescribableProcessor` declared
`@SupportedSourceVersion(SourceVersion.RELEASE_8)`, which is
inconsistent with the JDK 17 compilation target.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@CalvinKirsCalvinKirsCalvinKirs approved these changes
@morningmanmorningmanAwaiting requested review from morningmanmorningman is a code owner

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow@doris-robot@gavinchou@CalvinKirs