Skip to content

[fix](mtmv) Fix enable_materialized_view_nest_rewrite session variable is useless in some scene - #41472

Merged
morrySnow merged 2 commits into
apache:masterfrom
seawinde:fix_nest_mv_rewrite_variable_fail
Oct 11, 2024
Merged

[fix](mtmv) Fix enable_materialized_view_nest_rewrite session variable is useless in some scene#41472
morrySnow merged 2 commits into
apache:masterfrom
seawinde:fix_nest_mv_rewrite_variable_fail

Conversation

@seawinde

@seawindeseawinde commented Sep 29, 2024

Copy link
Copy Markdown
Member

Proposed changes

This is brought by #34050

if set enable_materialized_view_nest_rewrite = false, as expected, top level materialized view should rewritten fail, but now successfully.

Such as first level materialized view def is

 CREATE MATERIALIZED VIEW level1
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num'='1') ASSELECT l_orderkey, l_linenumber, l_partkey, o_orderkey, o_custkey
FROM lineitem_2 INNER JOIN orders_2
ON l_orderkey = o_orderkey;

second level materialized view def is

 CREATE MATERIALIZED VIEW level2
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num'='1') ASSELECT
l_orderkey,
l_linenumber,
o_orderkey,
sum(l_partkey) AS total_revenue,
max(o_custkey) AS max_discount
FROM join_mv1
GROUP BY l_orderkey, l_linenumber, o_orderkey;

if set enable_materialized_view_nest_rewrite = false, only level1 can rewriten succesfully and chosen by cbo
if set enable_materialized_view_nest_rewrite = true, both level1 and level2 can rewriten succesfully and level2 should be chosen by cbo.

This pr fixed this

@doris-robot

doris-robot commented Sep 29, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@seawinde

seawinde commented Sep 29, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@seawinde
seawindeforce-pushed the fix_nest_mv_rewrite_variable_fail branch from 9327087 to a6b1df7CompareSeptember 30, 2024 08:52
@seawinde

seawinde commented Sep 30, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@seawinde
seawindeforce-pushed the fix_nest_mv_rewrite_variable_fail branch from a6b1df7 to 9e968a1CompareOctober 8, 2024 12:34
@seawinde

seawinde commented Oct 8, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@github-actions

github-actionsBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow
morrySnow merged commit 2745e04 into apache:masterOct 11, 2024
seawinde added a commit to seawinde/doris that referenced this pull request Oct 21, 2024
@seawinde
[fix](mtmv) Fix enable_materialized_view_nest_rewrite session variabl…
477e0cf
…e is useless in some scene (apache#41472)
This is brought by apache#34050
if set `enable_materialized_view_nest_rewrite = false`, as expected, top
level materialized view should rewritten fail, but now successfully.
Such as first level materialized view def is
CREATE MATERIALIZED VIEW level1
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1')
AS
SELECT l_orderkey, l_linenumber, l_partkey, o_orderkey, o_custkey
FROM lineitem_2 INNER JOIN orders_2
ON l_orderkey = o_orderkey;
second level materialized view def is
CREATE MATERIALIZED VIEW level2
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1')
AS
SELECT
l_orderkey,
l_linenumber,
o_orderkey,
sum(l_partkey) AS total_revenue,
max(o_custkey) AS max_discount
FROM join_mv1
GROUP BY l_orderkey, l_linenumber, o_orderkey;
if set `enable_materialized_view_nest_rewrite = false`, only `level1`
can rewriten succesfully and chosen by cbo
if set `enable_materialized_view_nest_rewrite = true`, both `level1` and
`level2` can rewriten succesfully and `level2` should be chosen by cbo.
This pr fixed this
@seawindeseawinde mentioned this pull request Oct 21, 2024
Merged
seawinde added a commit to seawinde/doris that referenced this pull request Oct 23, 2024
@seawinde
[fix](mtmv) Fix enable_materialized_view_nest_rewrite session variabl…
f82e51d
…e is useless in some scene (apache#41472)
This is brought by apache#34050
if set `enable_materialized_view_nest_rewrite = false`, as expected, top
level materialized view should rewritten fail, but now successfully.
Such as first level materialized view def is
CREATE MATERIALIZED VIEW level1
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1')
AS
SELECT l_orderkey, l_linenumber, l_partkey, o_orderkey, o_custkey
FROM lineitem_2 INNER JOIN orders_2
ON l_orderkey = o_orderkey;
second level materialized view def is
CREATE MATERIALIZED VIEW level2
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1')
AS
SELECT
l_orderkey,
l_linenumber,
o_orderkey,
sum(l_partkey) AS total_revenue,
max(o_custkey) AS max_discount
FROM join_mv1
GROUP BY l_orderkey, l_linenumber, o_orderkey;
if set `enable_materialized_view_nest_rewrite = false`, only `level1`
can rewriten succesfully and chosen by cbo
if set `enable_materialized_view_nest_rewrite = true`, both `level1` and
`level2` can rewriten succesfully and `level2` should be chosen by cbo.
This pr fixed this
seawinde added a commit to seawinde/doris that referenced this pull request Oct 23, 2024
@seawinde
[fix](mtmv) Fix enable_materialized_view_nest_rewrite session variabl…
2752e77
…e is useless in some scene (apache#41472)
This is brought by apache#34050
if set `enable_materialized_view_nest_rewrite = false`, as expected, top
level materialized view should rewritten fail, but now successfully.
Such as first level materialized view def is
CREATE MATERIALIZED VIEW level1
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1') AS
SELECT l_orderkey, l_linenumber, l_partkey, o_orderkey, o_custkey
FROM lineitem_2 INNER JOIN orders_2
ON l_orderkey = o_orderkey;
second level materialized view def is
CREATE MATERIALIZED VIEW level2
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1') AS
SELECT
l_orderkey,
l_linenumber,
o_orderkey,
sum(l_partkey) AS total_revenue,
max(o_custkey) AS max_discount
FROM join_mv1
GROUP BY l_orderkey, l_linenumber, o_orderkey;
if set `enable_materialized_view_nest_rewrite = false`, only `level1`
can rewriten succesfully and chosen by cbo
if set `enable_materialized_view_nest_rewrite = true`, both `level1` and
`level2` can rewriten succesfully and `level2` should be chosen by cbo.
This pr fixed this
@seawindeseawinde mentioned this pull request Oct 23, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 24, 2024
@seawinde
Pick some fix from master to 21(#41472) (#40106)(#40173) (#42212)
44e9368
## Proposed changes
pr: #41472
commitId: 2745e04
pr: #40106
commitId: 0fdb1ee
pr: #40173
commitId: 0d07e3d
morrySnow pushed a commit that referenced this pull request Oct 24, 2024
@seawinde
[pick](mtmv) pick 4 PR from master#41472#40106#40173#42206(#42325)
a1690f0
pick from master
pr: #41472
commitId: 2745e04
pr: #40106
commitId: 0fdb1ee
pr: #40173
commitId: 0d07e3d
pr: #42206
commitId: 2bcaa5b
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@seawinde@HappenLee
[fix](mtmv) Fix enable_materialized_view_nest_rewrite session variabl…
a0c7e2e
…e is useless in some scene (apache#41472)
This is brought by apache#34050
if set `enable_materialized_view_nest_rewrite = false`, as expected, top
level materialized view should rewritten fail, but now successfully.
Such as first level materialized view def is
CREATE MATERIALIZED VIEW level1
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1') AS
SELECT l_orderkey, l_linenumber, l_partkey, o_orderkey, o_custkey
FROM lineitem_2 INNER JOIN orders_2
ON l_orderkey = o_orderkey;
second level materialized view def is
CREATE MATERIALIZED VIEW level2
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1') AS
SELECT
l_orderkey,
l_linenumber,
o_orderkey,
sum(l_partkey) AS total_revenue,
max(o_custkey) AS max_discount
FROM join_mv1
GROUP BY l_orderkey, l_linenumber, o_orderkey;
if set `enable_materialized_view_nest_rewrite = false`, only `level1`
can rewriten succesfully and chosen by cbo
if set `enable_materialized_view_nest_rewrite = true`, both `level1` and
`level2` can rewriten succesfully and `level2` should be chosen by cbo.
This pr fixed this
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zddrzddrzddr approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seawinde@doris-robot@zddr@morrySnow@yiguolei