Skip to content

[enhance](parquet) support decimal256 for parquet reader - #41526

Merged
morningman merged 4 commits into
apache:masterfrom
suxiaogang223:support_decimal256
Oct 9, 2024
Merged

[enhance](parquet) support decimal256 for parquet reader#41526
morningman merged 4 commits into
apache:masterfrom
suxiaogang223:support_decimal256

Conversation

@suxiaogang223

@suxiaogang223suxiaogang223 commented Oct 6, 2024

Copy link
Copy Markdown
Member

Proposed changes

Implemented reading parqeut files with decimal256 type

@doris-robot

doris-robot commented Oct 6, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

morningman
morningman reviewed Oct 7, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need regression test case for parquet decimal 256 and BE unit test for [bit_util.h]

github-actions[bot]
github-actionsBot reviewed Oct 8, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/exec/format/parquet/parquet_column_convert.h
@suxiaogang223

suxiaogang223 commented Oct 8, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.31% (9640/25836)
Line Coverage: 28.69% (79919/278607)
Region Coverage: 28.10% (41333/147069)
Branch Coverage: 24.73% (21056/85142)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5beb621f57f9393fefeb608d668c9f0168bfda5b_5beb621f57f9393fefeb608d668c9f0168bfda5b/report/index.html

morningman
morningman approved these changes Oct 8, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2024
@github-actions

github-actionsBot commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@wm1581066wm1581066 added dev/2.1.x usercase Important user case type label labels Oct 9, 2024
morningman
morningman approved these changes Oct 9, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit 3c5a98e into apache:masterOct 9, 2024
@suxiaogang223
suxiaogang223 deleted the support_decimal256 branch October 10, 2024 08:02
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@suxiaogang223@eldenmoon
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
c329c45
## Proposed changes
Implemented reading parqeut files with decimal256 type
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@suxiaogang223@cjj2010
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
fd93f87
## Proposed changes
Implemented reading parqeut files with decimal256 type
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@suxiaogang223amorynan
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
f936b3d
## Proposed changes
Implemented reading parqeut files with decimal256 type
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 16, 2024
@suxiaogang223
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
cfe8c96
## Proposed changes
Implemented reading parqeut files with decimal256 type
@suxiaogang223suxiaogang223 mentioned this pull request Oct 16, 2024
Merged
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 16, 2024
@suxiaogang223
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
3ff7697
## Proposed changes
Implemented reading parqeut files with decimal256 type
@suxiaogang223suxiaogang223 mentioned this pull request Oct 16, 2024
Merged
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 17, 2024
@suxiaogang223
Revert "[enhance](parquet) support decimal256 for parquet reader (apa…
26132b1
…che#41526)"
This reverts commit 3ff7697.
morningman added a commit that referenced this pull request Oct 17, 2024
@suxiaogang223@morningman
[cherry-pick](branch-3.0) fix parquet cases (#41506#41526#41683#41816
e634f0d
) (#41923)
## Proposed changes
pick prs:
#41506#41526#41683#41816
---------
Co-authored-by: morningman <morningman@163.com>
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 22, 2024
@suxiaogang223
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
86e2b28
## Proposed changes
Implemented reading parqeut files with decimal256 type
@suxiaogang223suxiaogang223 mentioned this pull request Oct 22, 2024
Merged
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 22, 2024
@suxiaogang223
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
4d38546
Implemented reading parqeut files with decimal256 type
morningman pushed a commit that referenced this pull request Oct 22, 2024
@suxiaogang223
[cherry-pick](branch-2.1) support decimal256 for parquet reader (#42241)
38e529c
## Proposed changes
pick pr: #41526
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@suxiaogang223@HappenLee
[enhance](parquet) support decimal256 for parquet reader (apache#41526)
e9180db
## Proposed changes
Implemented reading parqeut files with decimal256 type
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@morningmanmorningmanmorningman approved these changes
@CalvinKirsCalvinKirsCalvinKirs approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suxiaogang223@doris-robot@morningman@CalvinKirs@wm1581066