Skip to content

[chore](scan) remove useless enable_scan_node_run_serial - #41559

Merged
yiguolei merged 3 commits into
apache:masterfrom
RoanHeNaN:chore-unused-code
Oct 9, 2024
Merged

[chore](scan) remove useless enable_scan_node_run_serial#41559
yiguolei merged 3 commits into
apache:masterfrom
RoanHeNaN:chore-unused-code

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

enable_scan_node_run_serial is not working after #39927

@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@RoanHeNaN

RoanHeNaN commented Oct 8, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.29% (9632/25831)
Line Coverage: 28.67% (79869/278573)
Region Coverage: 28.11% (41307/146926)
Branch Coverage: 24.74% (21048/85084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/aa9d6e709be7cbf676d7d41b97b5910589b79f94_aa9d6e709be7cbf676d7d41b97b5910589b79f94/report/index.html

@RoanHeNaN

RoanHeNaN commented Oct 8, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@RoanHeNaNRoanHeNaN changed the title [chore] remove useless enable_scan_node_run_serial[chore](scan) remove useless enable_scan_node_run_serialOct 8, 2024
@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.28% (9630/25833)
Line Coverage: 28.68% (79887/278580)
Region Coverage: 28.11% (41298/146930)
Branch Coverage: 24.73% (21042/85086)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f7db82b6bef8fcaa4fe70da781601e8206f86529_f7db82b6bef8fcaa4fe70da781601e8206f86529/report/index.html

@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40754 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f7db82b6bef8fcaa4fe70da781601e8206f86529, data reload: false
------ Round 1 ----------------------------------
q1	17973	7913	7290	7290
q2	2051	292	275	275
q3	12202	1065	1116	1065
q4	10545	710	759	710
q5	7738	2889	2810	2810
q6	242	149	146	146
q7	1021	627	605	605
q8	9364	1903	1939	1903
q9	6533	6427	6437	6427
q10	6982	2274	2269	2269
q11	444	247	242	242
q12	420	219	223	219
q13	17777	2978	2993	2978
q14	248	206	210	206
q15	576	527	534	527
q16	662	601	586	586
q17	986	536	537	536
q18	7271	6715	6672	6672
q19	1374	1007	901	901
q20	511	201	195	195
q21	4017	3220	3237	3220
q22	1108	998	972	972
Total cold run time: 110045 ms
Total hot run time: 40754 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7297	7280	7234	7234
q2	330	237	231	231
q3	3084	2899	2943	2899
q4	2059	1854	1768	1768
q5	5727	5757	5693	5693
q6	231	142	142	142
q7	2278	1844	1810	1810
q8	3387	3600	3504	3504
q9	8882	8873	8874	8873
q10	3597	3556	3522	3522
q11	590	480	486	480
q12	852	583	640	583
q13	8964	3187	3166	3166
q14	325	302	272	272
q15	583	576	519	519
q16	694	640	646	640
q17	1840	1638	1660	1638
q18	8268	7818	7755	7755
q19	1735	1441	1475	1441
q20	2149	1893	1877	1877
q21	5577	5368	5509	5368
q22	1097	1072	1051	1051
Total cold run time: 69546 ms
Total hot run time: 60466 ms

@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192433 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f7db82b6bef8fcaa4fe70da781601e8206f86529, data reload: false
query1	921	392	402	392
query2	6272	2145	2028	2028
query3	8676	198	201	198
query4	34373	23415	23407	23407
query5	3487	461	458	458
query6	286	168	171	168
query7	4192	306	309	306
query8	290	233	226	226
query9	9724	2715	2705	2705
query10	465	282	295	282
query11	17642	15220	15149	15149
query12	153	98	97	97
query13	1591	466	438	438
query14	10096	7023	7534	7023
query15	258	170	187	170
query16	7981	462	520	462
query17	1630	613	583	583
query18	2067	335	327	327
query19	351	159	149	149
query20	124	113	120	113
query21	221	110	108	108
query22	4894	4379	4629	4379
query23	35394	34440	34104	34104
query24	11065	2867	2874	2867
query25	560	412	394	394
query26	866	161	169	161
query27	2257	306	308	306
query28	7378	2423	2417	2417
query29	689	454	432	432
query30	296	153	153	153
query31	1020	809	822	809
query32	101	53	54	53
query33	770	300	299	299
query34	908	504	515	504
query35	897	737	723	723
query36	1088	972	976	972
query37	153	93	85	85
query38	4021	4070	3895	3895
query39	1494	1489	1409	1409
query40	216	100	110	100
query41	55	47	46	46
query42	123	97	96	96
query43	525	501	480	480
query44	1248	808	842	808
query45	200	168	167	167
query46	1124	719	720	719
query47	1936	1843	1808	1808
query48	442	358	336	336
query49	971	410	409	409
query50	813	417	407	407
query51	7021	6917	6904	6904
query52	102	88	90	88
query53	255	179	179	179
query54	1313	476	472	472
query55	74	75	76	75
query56	283	250	262	250
query57	1267	1187	1169	1169
query58	244	222	225	222
query59	3161	3438	3345	3345
query60	307	266	259	259
query61	104	104	101	101
query62	841	666	665	665
query63	220	182	182	182
query64	4507	638	619	619
query65	3250	3171	3229	3171
query66	1158	307	307	307
query67	15990	15990	15623	15623
query68	4857	559	546	546
query69	572	294	302	294
query70	1187	1165	1112	1112
query71	380	268	269	268
query72	7001	4046	4237	4046
query73	759	344	358	344
query74	10289	9004	9087	9004
query75	3389	2666	2661	2661
query76	3373	930	972	930
query77	434	291	300	291
query78	10415	9657	9532	9532
query79	3054	607	615	607
query80	2235	447	455	447
query81	569	244	233	233
query82	721	137	140	137
query83	286	138	139	138
query84	264	78	76	76
query85	1376	305	293	293
query86	395	300	292	292
query87	4584	4295	4317	4295
query88	4018	2462	2437	2437
query89	399	287	287	287
query90	1987	191	187	187
query91	149	113	109	109
query92	61	54	48	48
query93	1821	561	541	541
query94	1058	303	295	295
query95	348	250	268	250
query96	614	284	277	277
query97	3355	3254	3217	3217
query98	222	197	200	197
query99	1634	1338	1284	1284
Total cold run time: 304207 ms
Total hot run time: 192433 ms

@doris-robot

doris-robot commented Oct 8, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 33.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f7db82b6bef8fcaa4fe70da781601e8206f86529, data reload: false
query1	0.05	0.05	0.04
query2	0.07	0.04	0.05
query3	0.24	0.05	0.05
query4	1.66	0.08	0.10
query5	0.52	0.51	0.50
query6	1.15	0.74	0.76
query7	0.02	0.01	0.01
query8	0.05	0.04	0.06
query9	0.55	0.51	0.49
query10	0.56	0.58	0.55
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.59	0.61
query14	2.68	2.71	2.73
query15	0.91	0.83	0.84
query16	0.37	0.38	0.39
query17	1.00	1.00	0.98
query18	0.19	0.19	0.20
query19	1.96	1.84	2.05
query20	0.01	0.01	0.02
query21	15.36	0.68	0.67
query22	4.34	6.38	2.16
query23	18.29	1.37	1.30
query24	2.10	0.23	0.26
query25	0.15	0.09	0.08
query26	0.27	0.18	0.18
query27	0.07	0.07	0.09
query28	13.22	1.18	1.14
query29	12.60	3.37	3.33
query30	0.24	0.07	0.06
query31	2.86	0.40	0.41
query32	3.23	0.48	0.49
query33	3.00	3.04	3.08
query34	16.78	4.50	4.48
query35	4.54	4.55	4.54
query36	0.66	0.50	0.51
query37	0.19	0.16	0.17
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.07	0.05	0.06
query43	0.05	0.05	0.05
Total cold run time: 111.38 s
Total hot run time: 33.58 s

@RoanHeNaN
RoanHeNaN marked this pull request as ready for review October 9, 2024 01:31
@github-actions

github-actionsBot commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2024
@github-actions

github-actionsBot commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Oct 9, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 2255b18 into apache:masterOct 9, 2024
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@RoanHeNaN@eldenmoon
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
321c867
enable_scan_node_run_serial is not working after
apache#39927
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@RoanHeNaN@cjj2010
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
e9de90d
enable_scan_node_run_serial is not working after
apache#39927
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@RoanHeNaNamorynan
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
d4a4d2b
enable_scan_node_run_serial is not working after
apache#39927
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Oct 17, 2024
@RoanHeNaN
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
0d79145
enable_scan_node_run_serial is not working after
apache#39927
@RoanHeNaNRoanHeNaN mentioned this pull request Oct 17, 2024
Merged
@RoanHeNaN
RoanHeNaN deleted the chore-unused-code branch November 8, 2024 12:37
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Nov 11, 2024
@RoanHeNaNzhiqiang-hhhh
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
cbf0266
enable_scan_node_run_serial is not working after
apache#39927
RoanHeNaN added a commit to RoanHeNaN/doris that referenced this pull request Jan 1, 2025
@RoanHeNaN
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
8c26ee4
enable_scan_node_run_serial is not working after
apache#39927
yiguolei pushed a commit that referenced this pull request Jan 3, 2025
@RoanHeNaNzhiqiang-hhhh
[chore](scan) remove useless enable_scan_node_run_serial#41559(#42013)
b4c36d3
cherry pick from #41559
---------
Co-authored-by: zhiqiang-hhhh <hezhiqiang@flywheels.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@RoanHeNaN@HappenLee
[chore](scan) remove useless enable_scan_node_run_serial (apache#41559)
0e59c65
enable_scan_node_run_serial is not working after
apache#39927
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLeeHappenLeeHappenLee approved these changes
@jacktenggjacktenggjacktengg approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RoanHeNaN@doris-robot@HappenLee@jacktengg@yiguolei