Uh oh!
There was an error while loading. Please reload this page.
[fix](nereids)adjust agg function nullability in PhysicalHashAggregate - #41576
Merged
Conversation
doris-robot
commented
Oct 9, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
starocean999
commented
Oct 9, 2024
ContributorAuthor
run buildall |
starocean999force-pushed
the
nereids_1115
branch
from
October 9, 2024 07:43
d8c4874 to
508b0b2Comparestarocean999
commented
Oct 9, 2024
ContributorAuthor
run buildall |
starocean999
commented
Oct 9, 2024
ContributorAuthor
run buildall |
morrySnow
approved these changes
Oct 11, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
apache#41576) ## Proposed changes `select sum(distinct c1) from t;` assume c1 is not null, because there is no group by, sum(distinct c1)'s nullable is alwasNullable in rewritten phase. But in implementation phase, we may create 3 phase agg with group by key c1. And the sum(distinct c1)'s nullability should be changed depending on if there is any group by expressions. This pr update the agg function's nullability accordingly <!--Describe your changes.-->
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
apache#41943) ## Proposed changes this is a follow up pr of apache#41576 , the previous pr may miss some agg function in AggregateExpression, this pr fix it. <!--Describe your changes.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
select sum(distinct c1) from t;assume c1 is not null, because there is no group by, sum(distinct c1)'s nullable is alwasNullable in rewritten phase. But in implementation phase, we may create 3 phase agg with group by key c1. And the sum(distinct c1)'s nullability should be changed depending on if there is any group by expressions. This pr update the agg function's nullability accordingly