Uh oh!
There was an error while loading. Please reload this page.
[RoutineLoad] Support modify routine load job - #4158
Merged
Conversation
| RoutineLoadJob job = checkPrivAndGetJob(stmt.getDbName(), stmt.getLabel()); | ||
| if (stmt.hasDataSourceProperty() | ||
| && !stmt.getDataSourceProperties().getType().equalsIgnoreCase(job.dataSourceType.name())) { | ||
| throw new DdlException("The spciefied job type is not: " + stmt.getDataSourceProperties().getType()); |
Contributor
There was a problem hiding this comment.
‘spciefied’ Wrong characters
| {: | ||
| RESULT = new AlterDatabaseRename(dbName, newDbName); | ||
| :} | ||
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:properties |
Contributor
There was a problem hiding this comment.
Suggested change
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:properties | |
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:jobProperties |
| {: | ||
| RESULT = new AlterDatabaseRename(dbName, newDbName); | ||
| :} | ||
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:jobProperties |
Contributor
There was a problem hiding this comment.
Maybe KW_ALTER KW_ROUTINE KW_LOAD KW_FOR job_label:jobLabel is better. The other routine load stmt also has KW_FOR.
| } | ||
| } | ||
| abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException; |
Contributor
There was a problem hiding this comment.
The job properties maybe could be modified in here instead of the subclass KafkaRoutineLoad.
ContributorAuthor
There was a problem hiding this comment.
Maybe we could do this when we got second derived class from RoutineLoadJob
| abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException; | ||
| abstract public void replayModifyProperties(AlterRoutineLoadJobOperationLog log); |
| title: "DML", | ||
| directoryPath: "Data Manipulation/", | ||
| children: [ | ||
| "alter-routine-load", |
Contributor
There was a problem hiding this comment.
Put it between pause routine load and stop routine load.
morningmanforce-pushed
the
modify_routine_load
branch
from
August 3, 2020 10:50
a94cb00 to
4b42b7dCompare
Closed
bobhan1 pushed a commit
to bobhan1/doris
that referenced
this pull request
Jul 15, 2025
…pache#4158) Issue Number: close #xxx <!--Describe your changes.-->
csun5285 pushed a commit
to csun5285/doris
that referenced
this pull request
Sep 23, 2025
…pache#4158) ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support ALTER ROUTINE LOAD JOB stmt, for example:
Details can be found in
alter-routine-load.mdTypes of changes
Checklist