Skip to content

Revert "[Improvement](sort) do not sort partitial when spill disabled(#40528)" - #41652

Merged
HappenLee merged 1 commit into
apache:masterfrom
HappenLee:load
Oct 10, 2024
Merged

Revert "[Improvement](sort) do not sort partitial when spill disabled(#40528)"#41652
HappenLee merged 1 commit into
apache:masterfrom
HappenLee:load

Conversation

@HappenLee

@HappenLeeHappenLee commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

Cause mem overflow and use more

Proposed changes

Issue Number: close #xxx

@doris-robot

doris-robot commented Oct 10, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee

HappenLee commented Oct 10, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@github-actions

github-actionsBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 10, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.42% (9663/25826)
Line Coverage: 28.70% (80211/279453)
Region Coverage: 28.13% (41455/147395)
Branch Coverage: 24.73% (21113/85388)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d0861526870c36d95c609828e40e7a8ce9286078_d0861526870c36d95c609828e40e7a8ce9286078/report/index.html

@HappenLee
HappenLee merged commit 0a26ad8 into apache:masterOct 10, 2024
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@HappenLee@cjj2010
Revert "[Improvement](sort) do not sort partitial when spill disabled(a…
40cbc8a
…pache#40528)" (apache#41652)
Cause mem overflow and use more
@yiguoleiyiguolei added usercase Important user case type label dev/3.0.x labels May 27, 2025
github-actionsBot pushed a commit that referenced this pull request May 27, 2025
@HappenLeeYour Name
Revert "[Improvement](sort) do not sort partitial when spill disabled(#…
0398991
…40528)" (#41652)
Cause mem overflow and use more
@github-actionsgithub-actionsBot mentioned this pull request May 27, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 27, 2025
@github-actions@HappenLee
branch-3.0: Revert "[Improvement](sort) do not sort partitial when sp…
50c42d1
…ill disabled(#40528)" #41652 (#51289)
Cherry-picked from #41652
Co-authored-by: HappenLee <happenlee@hotmail.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
@HappenLeeChen Zhang
Revert "[Improvement](sort) do not sort partitial when spill disabled(a…
2b2d49b
…pache#40528)" (apache#41652)
Cause mem overflow and use more
HappenLee added a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@HappenLee
Revert "[Improvement](sort) do not sort partitial when spill disabled(a…
8c62b3e
…pache#40528)" (apache#41652)
Cause mem overflow and use more
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt approved these changes
@MryangeMryangeMryange approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.6-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HappenLee@doris-robot@BiteTheDDDDt@Mryange@yiguolei@dataroaring