Skip to content

[cherry-pick](branch2.1) support escape.delim and serialization.null.format for hive text - #41684

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
suxiaogang223:escape_char_21
Oct 14, 2024
Merged

[cherry-pick](branch2.1) support escape.delim and serialization.null.format for hive text#41684
yiguolei merged 1 commit into
apache:branch-2.1from
suxiaogang223:escape_char_21

Conversation

@suxiaogang223

@suxiaogang223suxiaogang223 commented Oct 11, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

pick from master:
#40291

@suxiaogang223
[fix](hive) support null_format and escape_char for hive text (apache…
cdab0c1
…#40291)
## Proposed changes
related pr: apache#39700
support escape.delim and serialization.null.format for hive text
@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223

suxiaogang223 commented Oct 11, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Oct 11, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/exec/format/csv/csv_reader.cpp
}
}

void HiveCsvTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>* splitted_values) {

@github-actionsgithub-actionsBotOct 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: method 'do_split' can be made const [readability-make-member-function-const]

be/src/vec/exec/format/csv/csv_reader.cpp:177:

- values) {+ values) const {

@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.07% (9341/25895)
Line Coverage: 27.64% (76729/277565)
Region Coverage: 26.45% (39423/149038)
Branch Coverage: 23.23% (20055/86330)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cdab0c193b04db2fc9819d15ab164a61674a803b_cdab0c193b04db2fc9819d15ab164a61674a803b/report/index.html

@yiguolei
yiguolei merged commit 4888c63 into apache:branch-2.1Oct 14, 2024
@suxiaogang223
suxiaogang223 deleted the escape_char_21 branch October 15, 2024 08:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees

No one assigned

Labels

meta-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suxiaogang223@doris-robot@yiguolei