Skip to content

[bugfix](becore) use after free problem when the segment is pop - #41685

Merged
yiguolei merged 1 commit into
apache:masterfrom
yiguolei:fix_segment_cache
Oct 11, 2024
Merged

[bugfix](becore) use after free problem when the segment is pop#41685
yiguolei merged 1 commit into
apache:masterfrom
yiguolei:fix_segment_cache

Conversation

@yiguolei

@yiguoleiyiguolei commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx
introduced by #41608

@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei

yiguolei commented Oct 11, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

eldenmoon
eldenmoon approved these changes Oct 11, 2024
View reviewed changes

@eldenmooneldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

xiaokang
xiaokang approved these changes Oct 11, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.41% (9661/25827)
Line Coverage: 28.68% (80146/279488)
Region Coverage: 28.11% (41447/147455)
Branch Coverage: 24.71% (21105/85420)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2531c90affb01839ccdff12c4997f088c79ee187_2531c90affb01839ccdff12c4997f088c79ee187/report/index.html

@yiguolei
yiguolei merged commit 1f3465f into apache:masterOct 11, 2024
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Oct 11, 2024
@yiguolei@Doris-Extras
[bugfix](becore) use after free problem when the segment is pop (apac…
e459681
…he#41685)
## Proposed changes
Issue Number: close #xxx
introduced by apache#41608
<!--Describe your changes.-->
Co-authored-by: yiguolei <yiguolei@gmail.com>
@yiguoleiyiguolei mentioned this pull request Oct 11, 2024
Merged
yiguolei added a commit that referenced this pull request Oct 11, 2024
@yiguolei@Doris-Extras
[bugfix](becore) use after free problem when the segment is pop (#41685…
e9cfbb5
…) (#41697)
## Proposed changes
pick #41685
Issue Number: close #xxx
introduced by #41608
<!--Describe your changes.-->
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Co-authored-by: yiguolei <yiguolei@gmail.com>
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Oct 15, 2024
@yiguolei@Doris-Extras
[bugfix](becore) use after free problem when the segment is pop (apac…
f8817ee
…he#41685)
## Proposed changes
Issue Number: close #xxx
introduced by apache#41608
<!--Describe your changes.-->
Co-authored-by: yiguolei <yiguolei@gmail.com>
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Oct 19, 2024
@yiguolei@Doris-Extras
[bugfix](becore) use after free problem when the segment is pop (apac…
434ac6c
…he#41685)
## Proposed changes
Issue Number: close #xxx
introduced by apache#41608
<!--Describe your changes.-->
Co-authored-by: yiguolei <yiguolei@gmail.com>
@yiguoleiyiguolei mentioned this pull request Oct 19, 2024
Merged
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@yiguolei@Doris-Extras@HappenLee
[bugfix](becore) use after free problem when the segment is pop (apac…
c520002
…he#41685)
## Proposed changes
Issue Number: close #xxx
introduced by apache#41608
<!--Describe your changes.-->
Co-authored-by: yiguolei <yiguolei@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang approved these changes
@gavinchougavinchougavinchou approved these changes
@eldenmooneldenmooneldenmoon approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedp0_creviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yiguolei@doris-robot@xiaokang@gavinchou@eldenmoon@wm1581066@Doris-Extras