Skip to content

[fix](resize)fix array/map resize impl missing data resize - #41708

Merged
eldenmoon merged 2 commits into
apache:branch-2.0from
amorynan:fix-resize-2.0
Oct 15, 2024
Merged

[fix](resize)fix array/map resize impl missing data resize#41708
eldenmoon merged 2 commits into
apache:branch-2.0from
amorynan:fix-resize-2.0

Conversation

@amorynan

@amorynanamorynan commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

backport: #41595
Issue Number: close #xxx

@amorynan

amorynan commented Oct 11, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.81% (8147/21549)
Line Coverage: 29.54% (67060/226994)
Region Coverage: 29.01% (34561/119129)
Branch Coverage: 24.93% (17808/71442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45d6b44c37f99f347d87d0d04587e3c891fea6be_45d6b44c37f99f347d87d0d04587e3c891fea6be/report/index.html

xiaokang
xiaokang reviewed Oct 12, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pick unit test

@xiaokangxiaokang changed the title [fix](resize)fix array/map resize imp;[fix](resize)fix array/map resize implOct 12, 2024
@xiaokangxiaokang changed the title [fix](resize)fix array/map resize impl[fix](resize)fix array/map resize impl missing data resizeOct 12, 2024
@amorynan

amorynan commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 14, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.83% (8152/21549)
Line Coverage: 29.56% (67100/227004)
Region Coverage: 29.03% (34588/119139)
Branch Coverage: 24.98% (17850/71450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f0a94db28c6118651dff17524154ff5faf67587a_f0a94db28c6118651dff17524154ff5faf67587a/report/index.html

@amorynan

amorynan commented Oct 14, 2024

Copy link
Copy Markdown
ContributorAuthor

pick unit test

rewrite a new test for resize

eldenmoon
eldenmoon approved these changes Oct 15, 2024
View reviewed changes

@eldenmooneldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@github-actions

github-actionsBot commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@eldenmoon
eldenmoon merged commit 3463807 into apache:branch-2.0Oct 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang left review comments
@eldenmooneldenmooneldenmoon approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.kind/testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amorynan@doris-robot@xiaokang@eldenmoon