Skip to content

[Fix](inverted index) fix match null for inverted index - #41746

Merged
airborne12 merged 3 commits into
apache:masterfrom
airborne12:fix-null-index
Oct 14, 2024
Merged

[Fix](inverted index) fix match null for inverted index#41746
airborne12 merged 3 commits into
apache:masterfrom
airborne12:fix-null-index

Conversation

@airborne12

@airborne12airborne12 commented Oct 12, 2024

Copy link
Copy Markdown
Member

Proposed changes

str match null return null , not true event if str is null

@doris-robot

doris-robot commented Oct 12, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@airborne12

airborne12 commented Oct 12, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 12, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.39% (9658/25827)
Line Coverage: 28.68% (80173/279569)
Region Coverage: 28.09% (41438/147504)
Branch Coverage: 24.70% (21108/85454)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca8fe5b4472ed8d633848a47d74c1b2110227451_ca8fe5b4472ed8d633848a47d74c1b2110227451/report/index.html

@airborne12

airborne12 commented Oct 12, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 12, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.39% (9663/25844)
Line Coverage: 28.65% (80149/279789)
Region Coverage: 28.08% (41439/147554)
Branch Coverage: 24.70% (21101/85444)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6f5432be458246848fe3e56d93ad0b3b8e7ac445_6f5432be458246848fe3e56d93ad0b3b8e7ac445/report/index.html

eldenmoon
eldenmoon approved these changes Oct 14, 2024
View reviewed changes

@eldenmooneldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 14, 2024
@github-actions

github-actionsBot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes Oct 14, 2024
View reviewed changes

@csun5285csun5285 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12
airborne12 merged commit 6a6455d into apache:masterOct 14, 2024
@airborne12
airborne12 deleted the fix-null-index branch October 14, 2024 04:17
This was referenced Oct 14, 2024
Merged
Merged
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 14, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index (apache#41746)
e09c636
## Proposed changes
str match null return null , not true event if str is null
airborne12 added a commit that referenced this pull request Oct 14, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index#41746(#41787)
ff52e73
cherry pick from #41746
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 16, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index (apache#41746)
355147c
## Proposed changes
str match null return null , not true event if str is null
qzsee pushed a commit to qzsee/incubator-doris that referenced this pull request Oct 16, 2024
@airborne12garenshi
[Fix](inverted index) fix match null for inverted index (apache#41746)
13d785c
## Proposed changes
str match null return null , not true event if str is null
airborne12 added a commit that referenced this pull request Oct 16, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index#41746(#41786)
eb6e834
cherry pick from #41746
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@airborne12@HappenLee
[Fix](inverted index) fix match null for inverted index (apache#41746)
27b745f
## Proposed changes
str match null return null , not true event if str is null
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmooneldenmooneldenmoon approved these changes
@csun5285csun5285csun5285 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@airborne12@doris-robot@eldenmoon@csun5285