Uh oh!
There was an error while loading. Please reload this page.
[bug](function)fix date_floor function return wrong result - #41948
Merged
Conversation
doris-robot
commented
Oct 16, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zhangstar333
commented
Oct 16, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Oct 16, 2024
TeamCity be ut coverage result: |
zhangstar333
commented
Oct 17, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Oct 17, 2024
TeamCity be ut coverage result: |
Mryange
approved these changes
Oct 17, 2024
Contributor
PR approved by anyone and no changes requested. |
Contributor
PR approved by at least one committer and no changes requested. |
zhangstar333 added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 18, 2024
) ``` void resize_fill(size_t n, const T& value) { size_t old_size = this->size(); if (n > old_size) { this->reserve(n); std::fill(t_end(), t_end() + n - old_size, value); } this->c_end = this->c_start + this->byte_size(n); } ``` if n is not greater than old_size, it's will not fill the data with value. so it's not set the null_map flag to 1, it's can't return NULL ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | | +---------------------+--------------------+ 1 row in set (0.03 se ``` after fix: ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | NULL | +---------------------+--------------------+ 1 row in set (0.03 sec) ```
yiguolei pushed a commit
that referenced
this pull request
Oct 18, 2024
Closed
zhangstar333 added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Nov 11, 2024
) ``` void resize_fill(size_t n, const T& value) { size_t old_size = this->size(); if (n > old_size) { this->reserve(n); std::fill(t_end(), t_end() + n - old_size, value); } this->c_end = this->c_start + this->byte_size(n); } ``` if n is not greater than old_size, it's will not fill the data with value. so it's not set the null_map flag to 1, it's can't return NULL ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | | +---------------------+--------------------+ 1 row in set (0.03 se ``` after fix: ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | NULL | +---------------------+--------------------+ 1 row in set (0.03 sec) ```
zhangstar333 added a commit
that referenced
this pull request
Nov 11, 2024
Closed
Closed
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
) ``` void resize_fill(size_t n, const T& value) { size_t old_size = this->size(); if (n > old_size) { this->reserve(n); std::fill(t_end(), t_end() + n - old_size, value); } this->c_end = this->c_start + this->byte_size(n); } ``` if n is not greater than old_size, it's will not fill the data with value. so it's not set the null_map flag to 1, it's can't return NULL ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | | +---------------------+--------------------+ 1 row in set (0.03 se ``` after fix: ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | NULL | +---------------------+--------------------+ 1 row in set (0.03 sec) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
if n is not greater than old_size,
it's will not fill the data with value.
so it's not set the null_map flag to 1, it's can't return NULL
after fix: