Skip to content

[Opt](flexible partial update) let SegmentWriter do not support flexible partial update - #41950

Merged
dataroaring merged 2 commits into
apache:masterfrom
bobhan1:flexible-partial-update-forbid-segment-writer
Oct 22, 2024
Merged

[Opt](flexible partial update) let SegmentWriter do not support flexible partial update#41950
dataroaring merged 2 commits into
apache:masterfrom
bobhan1:flexible-partial-update-forbid-segment-writer

Conversation

@bobhan1

@bobhan1bobhan1 commented Oct 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Considering that SegmentWriter will be removed in the near future, we stop to support flexible partial update on SegmentWriter to reduce maintenance costs

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1

bobhan1 commented Oct 16, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.48% (9709/25906)
Line Coverage: 28.76% (80632/280320)
Region Coverage: 28.19% (41714/147960)
Branch Coverage: 24.76% (21206/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/268087e1a281900adea2d184ef722f062c5083fb_268087e1a281900adea2d184ef722f062c5083fb/report/index.html

dataroaring
dataroaring reviewed Oct 16, 2024
View reviewed changes
Comment threadbe/src/olap/rowset/segment_v2/segment_writer.cpp Outdated
@bobhan1

bobhan1 commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 17, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25911)
Line Coverage: 28.76% (80618/280328)
Region Coverage: 28.18% (41702/147974)
Branch Coverage: 24.76% (21207/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/01a097d96a5fed33dc03623fe9bcf45740a83ac8_01a097d96a5fed33dc03623fe9bcf45740a83ac8/report/index.html

@bobhan1

bobhan1 commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run p0

@bobhan1

bobhan1 commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run external

zhannngchen
zhannngchen approved these changes Oct 18, 2024
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2024
@github-actions

github-actionsBot commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@bobhan1bobhan1 mentioned this pull request Oct 18, 2024
Closed
dataroaring
dataroaring approved these changes Oct 20, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bobhan1 added a commit to bobhan1/doris that referenced this pull request Oct 21, 2024
@bobhan1
pick fleixble partial update PRs for anta
c7c5dc8
pick the following PRs:
other PR:
- apache#39619
- apache#40062
- apache#40272
- apache#40364
- apache#40736
- apache#41439
main PR:
- apache#39756
- apache#41950
- apache#41701
@dataroaring
dataroaring merged commit 4c09663 into apache:masterOct 22, 2024
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jul 9, 2025
@bobhan1
[Opt](flexible partial update) let SegmentWriter do not support fle…
af7e2e6
…xible partial update (apache#41950)
Considering that `SegmentWriter` will be removed in the near future, we
stop to support flexible partial update on `SegmentWriter` to reduce
maintenance costs
@bobhan1bobhan1 mentioned this pull request Jul 9, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 10, 2025
@bobhan1
branch-3.1: [opt](partial update) use a separate config to control th…
57675f0
…e behavior of newly inserted rows in partial update #41950#41232 (#52998)
pick #41950 and #41232
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@bobhan1@HappenLee
[Opt](flexible partial update) let SegmentWriter do not support fle…
514e9ca
…xible partial update (apache#41950)
Considering that `SegmentWriter` will be removed in the near future, we
stop to support flexible partial update on `SegmentWriter` to reduce
maintenance costs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1@doris-robot@zhannngchen@dataroaring@morrySnow