Skip to content

[fix](nereids) Fix load failed where not set database in session - #41951

Merged
morrySnow merged 4 commits into
apache:masterfrom
zxealous:fix-load
Oct 18, 2024
Merged

[fix](nereids) Fix load failed where not set database in session#41951
morrySnow merged 4 commits into
apache:masterfrom
zxealous:fix-load

Conversation

@zxealous

@zxealouszxealous commented Oct 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

load failed where not set database in session

LOAD LABEL test_db.label_111111 ( DATA INFILE("hdfs://hdfs01:9000/user/") INTO TABLE `test_load_tb`) WITH BROKER "broker" ( "username" = "user", "password" = "");
ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not set.

use label's database if not set database in session

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zxealous

zxealous commented Oct 16, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 41073 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a0097a0fec876f4ec0982bc23caa6c2e5e47d420, data reload: false
------ Round 1 ----------------------------------
q1	17643	7555	7301	7301
q2	2047	284	271	271
q3	12439	1050	1204	1050
q4	10538	818	861	818
q5	7740	3091	3106	3091
q6	236	148	151	148
q7	1041	628	602	602
q8	9364	1941	1995	1941
q9	6627	6488	6429	6429
q10	7071	2396	2424	2396
q11	441	242	241	241
q12	409	226	223	223
q13	17801	2996	2981	2981
q14	246	213	219	213
q15	570	518	521	518
q16	649	571	576	571
q17	979	456	594	456
q18	7357	6809	6657	6657
q19	1353	931	1066	931
q20	473	193	189	189
q21	3990	3049	3159	3049
q22	1128	997	1016	997
Total cold run time: 110142 ms
Total hot run time: 41073 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7278	7258	7440	7258
q2	328	236	233	233
q3	3063	2982	2942	2942
q4	2149	1840	1837	1837
q5	5798	5772	5766	5766
q6	234	143	151	143
q7	2295	1866	1785	1785
q8	3449	3492	3506	3492
q9	8945	9009	8975	8975
q10	3640	3565	3559	3559
q11	621	488	497	488
q12	849	623	584	584
q13	7900	3186	3219	3186
q14	307	293	271	271
q15	575	532	527	527
q16	687	648	640	640
q17	1831	1638	1610	1610
q18	8360	7769	7510	7510
q19	1769	1560	1481	1481
q20	2144	1866	1890	1866
q21	5482	5448	5502	5448
q22	1146	1103	1073	1073
Total cold run time: 68850 ms
Total hot run time: 60674 ms

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192589 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a0097a0fec876f4ec0982bc23caa6c2e5e47d420, data reload: false
query1	909	395	406	395
query2	6249	2118	2038	2038
query3	8681	200	202	200
query4	34212	23791	23628	23628
query5	3354	473	489	473
query6	259	171	154	154
query7	4183	288	298	288
query8	309	238	228	228
query9	9632	2724	2743	2724
query10	462	270	271	270
query11	17844	15344	15317	15317
query12	154	101	101	101
query13	1557	428	410	410
query14	9438	7731	7773	7731
query15	248	173	179	173
query16	7900	485	464	464
query17	1611	595	567	567
query18	2153	297	313	297
query19	357	157	167	157
query20	121	117	113	113
query21	213	113	117	113
query22	4802	4762	4557	4557
query23	35211	34298	35052	34298
query24	11463	2835	2784	2784
query25	651	411	391	391
query26	1626	164	166	164
query27	2559	282	274	274
query28	7772	2434	2409	2409
query29	981	438	422	422
query30	268	151	148	148
query31	1049	812	771	771
query32	94	54	53	53
query33	768	313	308	308
query34	945	511	530	511
query35	887	753	753	753
query36	1134	969	941	941
query37	178	87	87	87
query38	3968	3919	3936	3919
query39	1494	1451	1424	1424
query40	255	96	98	96
query41	47	44	45	44
query42	128	109	101	101
query43	540	492	495	492
query44	1255	806	807	806
query45	194	163	165	163
query46	1146	714	694	694
query47	1909	1856	1849	1849
query48	419	326	322	322
query49	1033	440	423	423
query50	822	385	405	385
query51	7063	6930	6949	6930
query52	103	86	88	86
query53	262	181	183	181
query54	1249	424	430	424
query55	79	82	75	75
query56	285	269	250	250
query57	1309	1145	1140	1140
query58	241	255	224	224
query59	3283	2927	3128	2927
query60	286	268	260	260
query61	104	103	104	103
query62	817	686	665	665
query63	220	193	189	189
query64	5008	641	613	613
query65	3290	3221	3223	3221
query66	1174	304	320	304
query67	15933	15577	15771	15577
query68	4517	581	550	550
query69	548	287	286	286
query70	1107	1130	1113	1113
query71	400	278	285	278
query72	7255	3956	3910	3910
query73	772	350	354	350
query74	9931	8934	8865	8865
query75	3448	2690	2675	2675
query76	3325	884	915	884
query77	462	291	289	289
query78	10629	9551	9556	9551
query79	2728	594	609	594
query80	1204	431	457	431
query81	593	239	236	236
query82	719	137	135	135
query83	261	135	130	130
query84	256	75	72	72
query85	1250	316	294	294
query86	372	295	296	295
query87	4544	4307	4325	4307
query88	3377	2230	2167	2167
query89	423	288	290	288
query90	2000	184	184	184
query91	136	98	98	98
query92	56	48	46	46
query93	1652	542	537	537
query94	865	294	292	292
query95	351	248	248	248
query96	616	276	285	276
query97	3291	3108	3165	3108
query98	227	206	192	192
query99	1660	1322	1309	1309
Total cold run time: 303125 ms
Total hot run time: 192589 ms

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 33.27 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a0097a0fec876f4ec0982bc23caa6c2e5e47d420, data reload: false
query1	0.04	0.03	0.02
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.65	0.10	0.10
query5	0.51	0.50	0.51
query6	1.13	0.74	0.73
query7	0.02	0.02	0.02
query8	0.03	0.03	0.04
query9	0.58	0.49	0.49
query10	0.53	0.54	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.12
query13	0.61	0.59	0.59
query14	2.84	2.77	2.73
query15	0.90	0.81	0.82
query16	0.39	0.41	0.37
query17	0.97	0.97	1.03
query18	0.20	0.20	0.21
query19	1.82	1.82	1.91
query20	0.02	0.00	0.02
query21	15.38	0.59	0.60
query22	2.54	2.17	2.15
query23	17.00	1.00	0.90
query24	3.32	1.31	1.23
query25	0.18	0.25	0.06
query26	0.49	0.14	0.13
query27	0.04	0.04	0.03
query28	10.01	1.09	1.07
query29	12.52	3.20	3.20
query30	0.24	0.06	0.06
query31	2.89	0.40	0.37
query32	3.28	0.46	0.45
query33	2.99	3.04	3.04
query34	16.81	4.48	4.48
query35	4.53	4.56	4.53
query36	0.66	0.47	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.17 s
Total hot run time: 33.27 s

morrySnow
morrySnow reviewed Oct 16, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 Outdated
(propertyClause)?
| ((WITH)? mergeType)? DATA FROM TABLE tableName=multipartIdentifier
INTO TABLE tableName=multipartIdentifier
| ((WITH)? mergeType)? DATA FROM TABLE tableName=identifier

@morrySnowmorrySnowOct 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| ((WITH)? mergeType)? DATAFROMTABLEtableName=identifier
| ((WITH)? mergeType)? DATAFROMTABLEsourceTableName=identifier

Comment threadfe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 Outdated
| ((WITH)? mergeType)? DATA FROM TABLE tableName=multipartIdentifier
INTO TABLE tableName=multipartIdentifier
| ((WITH)? mergeType)? DATA FROM TABLE tableName=identifier
INTO TABLE tableName=identifier

@morrySnowmorrySnowOct 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
INTOTABLEtableName=identifier
INTOTABLEtargetTableName=identifier

Comment threadfe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 Outdated
@zxealous

zxealous commented Oct 16, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@zxealous

zxealous commented Oct 16, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@zxealous

zxealous commented Oct 16, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40949 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 91d8d7187c744d6b6d52af604696459180f62727, data reload: false
------ Round 1 ----------------------------------
q1	17597	7486	7259	7259
q2	2043	158	150	150
q3	10586	1139	1123	1123
q4	10223	853	961	853
q5	7756	3058	3076	3058
q6	244	153	152	152
q7	1022	619	621	619
q8	9381	1884	1938	1884
q9	6554	6389	6464	6389
q10	7026	2403	2424	2403
q11	454	244	248	244
q12	409	221	218	218
q13	17762	3022	2984	2984
q14	248	215	233	215
q15	573	520	518	518
q16	638	573	583	573
q17	962	480	538	480
q18	7278	6696	6727	6696
q19	1336	835	1047	835
q20	480	185	184	184
q21	3938	3250	3105	3105
q22	1122	1007	1024	1007
Total cold run time: 107632 ms
Total hot run time: 40949 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7312	7262	7246	7246
q2	330	239	226	226
q3	2958	2805	2757	2757
q4	1966	1761	1693	1693
q5	5440	5465	5518	5465
q6	226	147	148	147
q7	2149	1709	1719	1709
q8	3224	3374	3408	3374
q9	8552	8526	8523	8523
q10	3513	3457	3427	3427
q11	579	475	483	475
q12	787	605	575	575
q13	9058	3007	3033	3007
q14	300	258	264	258
q15	553	512	528	512
q16	703	654	623	623
q17	1800	1590	1582	1582
q18	7731	7631	7457	7457
q19	1684	1558	1478	1478
q20	2057	1806	1816	1806
q21	5258	5299	5250	5250
q22	1147	1028	1022	1022
Total cold run time: 67327 ms
Total hot run time: 58612 ms

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 191596 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 91d8d7187c744d6b6d52af604696459180f62727, data reload: false
query1	994	382	384	382
query2	6523	2001	1983	1983
query3	6783	213	224	213
query4	34232	23491	23578	23491
query5	4334	481	467	467
query6	265	177	189	177
query7	4594	297	297	297
query8	300	241	229	229
query9	9697	2714	2693	2693
query10	478	292	277	277
query11	18130	15358	15387	15358
query12	148	102	98	98
query13	1653	428	414	414
query14	9907	6793	7669	6793
query15	275	174	176	174
query16	8061	448	479	448
query17	1729	572	589	572
query18	2138	299	302	299
query19	367	178	146	146
query20	119	110	111	110
query21	220	107	107	107
query22	4705	4346	4234	4234
query23	34884	34394	34369	34369
query24	11143	2773	2758	2758
query25	678	412	414	412
query26	1634	165	159	159
query27	2770	282	291	282
query28	7992	2418	2425	2418
query29	978	434	426	426
query30	327	167	154	154
query31	1011	799	831	799
query32	97	56	58	56
query33	787	298	292	292
query34	975	519	539	519
query35	885	731	744	731
query36	1132	952	938	938
query37	165	104	87	87
query38	4171	3912	3964	3912
query39	1483	1488	1430	1430
query40	292	101	101	101
query41	48	47	49	47
query42	125	103	100	100
query43	515	471	490	471
query44	1254	807	809	807
query45	199	165	169	165
query46	1154	695	708	695
query47	1956	1840	1832	1832
query48	414	325	326	325
query49	1275	447	430	430
query50	845	386	388	386
query51	7233	6995	6945	6945
query52	102	90	91	90
query53	270	182	183	182
query54	1308	436	440	436
query55	86	77	82	77
query56	301	278	270	270
query57	1311	1168	1096	1096
query58	246	239	230	230
query59	3129	3001	2988	2988
query60	276	271	262	262
query61	105	104	100	100
query62	879	681	679	679
query63	209	191	181	181
query64	5083	648	612	612
query65	3314	3284	3181	3181
query66	1445	320	313	313
query67	15920	15635	15722	15635
query68	4906	560	563	560
query69	443	293	289	289
query70	1192	1120	1049	1049
query71	328	281	275	275
query72	6358	4005	3968	3968
query73	786	364	364	364
query74	10194	9009	8999	8999
query75	3350	2672	2718	2672
query76	2778	925	928	925
query77	419	296	303	296
query78	11004	9793	9627	9627
query79	2395	596	629	596
query80	1142	444	440	440
query81	572	243	248	243
query82	676	140	134	134
query83	262	140	136	136
query84	260	71	72	71
query85	895	283	283	283
query86	494	288	300	288
query87	4463	4306	4349	4306
query88	3957	2209	2183	2183
query89	403	288	285	285
query90	2152	187	186	186
query91	132	100	101	100
query92	63	48	49	48
query93	1760	549	540	540
query94	1101	280	279	279
query95	373	244	240	240
query96	629	282	288	282
query97	3288	3123	3158	3123
query98	223	197	190	190
query99	1726	1279	1315	1279
Total cold run time: 304782 ms
Total hot run time: 191596 ms

@doris-robot

doris-robot commented Oct 16, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 33.82 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91d8d7187c744d6b6d52af604696459180f62727, data reload: false
query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.64	0.10	0.10
query5	0.52	0.50	0.52
query6	1.13	0.72	0.71
query7	0.01	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.51	0.51
query10	0.55	0.54	0.55
query11	0.14	0.10	0.10
query12	0.13	0.12	0.10
query13	0.61	0.60	0.59
query14	2.74	2.74	2.72
query15	0.88	0.83	0.82
query16	0.39	0.38	0.39
query17	1.06	1.08	0.98
query18	0.23	0.22	0.21
query19	1.89	1.89	2.03
query20	0.01	0.01	0.01
query21	15.38	0.59	0.59
query22	3.02	2.51	2.01
query23	16.93	0.88	0.82
query24	3.20	1.93	2.12
query25	0.30	0.18	0.05
query26	0.71	0.14	0.14
query27	0.04	0.03	0.03
query28	9.23	1.10	1.07
query29	12.57	3.28	3.27
query30	0.25	0.08	0.06
query31	2.86	0.38	0.39
query32	3.27	0.47	0.46
query33	3.00	3.01	3.03
query34	17.09	4.38	4.48
query35	4.52	4.48	4.51
query36	0.68	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.15	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.42 s
Total hot run time: 33.82 s

@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 17, 2024
@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow
morrySnow merged commit dbdfcb3 into apache:masterOct 18, 2024
This was referenced Oct 18, 2024
Closed
Merged
Merged
zxealous added a commit to zxealous/doris that referenced this pull request Oct 18, 2024
@zxealous
[fix](nereids) Fix load failed where not set database in session (apa…
856cd43
…che#41951)
load failed where not set database in session, should use label's database if not set database in session
LOAD LABEL test_db.label_111111 ( DATA INFILE("hdfs://hdfs01:9000/user/") INTO TABLE `test_load_tb`) WITH BROKER "broker" ( "username" = "user", "password" = "");
ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not set.
yiguolei pushed a commit that referenced this pull request Oct 18, 2024
@zxealous
[fix](nereids) Fix load failed where not set database in session (#41951
ba9f8be
) (#42082)
cherry-pick #41951
load failed where not set database in session, should use label's
database if not set database in session
LOAD LABEL test_db.label_111111 ( DATA
INFILE("hdfs://hdfs01:9000/user/") INTO TABLE `test_load_tb`) WITH
BROKER "broker" ( "username" = "user", "password" = "");
ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not
set.
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
morrySnow pushed a commit that referenced this pull request Oct 23, 2024
@zxealous
[fix](nereids) Fix load failed where not set database in session (#41951
7ea1c33
) (#42081)
cherry-pick from master #41951
load failed where not set database in session, should use label's
database if not set database in session
LOAD LABEL test_db.label_111111 ( DATA
INFILE("hdfs://hdfs01:9000/user/") INTO TABLE `test_load_tb`) WITH
BROKER "broker" ( "username" = "user", "password" = "");
ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not set.
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zxealous@HappenLee
[fix](nereids) Fix load failed where not set database in session (apa…
694778a
…che#41951)
load failed where not set database in session, should use label's database if not set database in session
LOAD LABEL test_db.label_111111 ( DATA INFILE("hdfs://hdfs01:9000/user/") INTO TABLE `test_load_tb`) WITH BROKER "broker" ( "username" = "user", "password" = "");
ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not set.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adonis0147adonis0147adonis0147 approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zxealous@doris-robot@adonis0147@morrySnow@yiguolei