Skip to content

[fix](index compaction) base compaction failed after restore indexes - #41966

Closed
cambyzju wants to merge 2 commits into
apache:masterfrom
cambyzju:fix-master-1016
Closed

[fix](index compaction) base compaction failed after restore indexes#41966
cambyzju wants to merge 2 commits into
apache:masterfrom
cambyzju:fix-master-1016

Conversation

@cambyzju

@cambyzjucambyzju commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Problem:
after restore from other cluster, then rowsets got different index_id, and make index compaction in base compaction always failed.

Close this pr:
because of duplicate pr, #41625 already fix it:

 // no inverted index or index id is different from current index id
if (tablet_index == nullptr || tablet_index->index_id() != index.index_id()) {
is_continue = true;
break;
}

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.46% (9708/25919)
Line Coverage: 28.72% (80604/280628)
Region Coverage: 28.17% (41724/148089)
Branch Coverage: 24.74% (21204/85702)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eb471ca2db4b42c3479e4e5b4ea7b30d2ccd4e51_eb471ca2db4b42c3479e4e5b4ea7b30d2ccd4e51/report/index.html

@lide-reedlide-reed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 21, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@cambyzju

Copy link
Copy Markdown
ContributorAuthor

run p0

@cambyzju

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.45% (9696/25891)
Line Coverage: 28.69% (80466/280479)
Region Coverage: 28.14% (41643/147993)
Branch Coverage: 24.71% (21158/85640)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3a342c08fecdfb609dfb3e498d5f6c68ae4ba74c_3a342c08fecdfb609dfb3e498d5f6c68ae4ba74c/report/index.html

@cambyzju

Copy link
Copy Markdown
ContributorAuthor

run External Regression

// from src cluster in be, but in fe, we will generate new index_id,
// different index_id make we can not find index file correctly.
// Here we temporarily skip index compaction.
// (TODO) we should use index_id in rowset schema, not tablet schema.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to specify which part todo this

@cambyzju

Copy link
Copy Markdown
ContributorAuthor

for branch-2.1: #43962

@zzzxl1993

Copy link
Copy Markdown
Contributor

@cambyzju Why was this PR closed on the master branch?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.xreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cambyzju@doris-robot@zzzxl1993@lide-reed@airborne12