Skip to content

[feature](doris compose) diff user use diff start subnet - #41996

Merged
dataroaring merged 2 commits into
apache:masterfrom
yujun777:docker-compose-use-diff-subnet
Oct 20, 2024
Merged

[feature](doris compose) diff user use diff start subnet#41996
dataroaring merged 2 commits into
apache:masterfrom
yujun777:docker-compose-use-diff-subnet

Conversation

@yujun777

Copy link
Copy Markdown
Contributor

If users use different LOCAL_DORIS_PATH, their clusters' network maybe conflict. So let different user use different searched start subnet.

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777

Copy link
Copy Markdown
ContributorAuthor

run buildall

gavinchou
gavinchou previously approved these changes Oct 17, 2024
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Oct 17, 2024

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deardengdeardeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yujun777
yujun777 dismissed stale reviews from dataroaring and gavinchou via 021a88aOctober 17, 2024 02:37
@yujun777
yujun777force-pushed the docker-compose-use-diff-subnet branch from 255328e to 021a88aCompareOctober 17, 2024 02:37
@yujun777

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Oct 17, 2024
@yujun777

Copy link
Copy Markdown
ContributorAuthor

run p0

@yujun777

Copy link
Copy Markdown
ContributorAuthor

run buildall

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 68c28a0 into apache:masterOct 20, 2024
dataroaring pushed a commit that referenced this pull request Nov 8, 2024
 (#43454)
If users use different LOCAL_DORIS_PATH, their clusters' network maybe
conflict. So let different user use different searched start subnet.
cherry-pick: #41996
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
If users use different LOCAL_DORIS_PATH, their clusters' network maybe
conflict. So let different user use different searched start subnet.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@yujun777@doris-robot@deardeng@gavinchou@dataroaring