[fix](exit) stop storage engine in exec_env before exit by dataroaring · Pull Request #42015 · apache/doris

dataroaring · 2024-10-17T06:34:02Z

Proposed changes

Issue Number: close #xxx

doris-robot · 2024-10-17T06:34:07Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

dataroaring · 2024-10-17T06:34:10Z

run buildall

github-actions · 2024-10-17T06:43:08Z

clang-tidy review says "All clean, LGTM! 👍"

dataroaring · 2024-10-17T07:10:13Z

run buildall

github-actions · 2024-10-17T07:17:40Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-10-17T07:50:51Z

TPC-H: Total hot run time: 41323 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 61a16e887262ed0bddbd58339773e41c7aba7451, data reload: false
------ Round 1 ----------------------------------
q1	17569	7418	7298	7298
q2	2035	287	293	287
q3	12222	1063	1125	1063
q4	10571	863	816	816
q5	7779	3084	3061	3061
q6	236	154	152	152
q7	1023	620	608	608
q8	9348	1934	1988	1934
q9	6914	6454	6378	6378
q10	7036	2438	2490	2438
q11	441	250	245	245
q12	419	237	228	228
q13	17819	3015	3026	3015
q14	242	209	210	209
q15	583	519	524	519
q16	662	569	574	569
q17	955	508	544	508
q18	7185	6665	6884	6665
q19	1350	1028	1036	1028
q20	480	185	184	184
q21	4001	3110	3207	3110
q22	1076	1008	1009	1008
Total cold run time: 109946 ms
Total hot run time: 41323 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7233	7226	7207	7207
q2	332	230	229	229
q3	3072	3009	2965	2965
q4	2142	1846	1806	1806
q5	5785	5740	5830	5740
q6	234	149	148	148
q7	2318	1876	1805	1805
q8	3397	3555	3494	3494
q9	8973	8867	8886	8867
q10	3571	3572	3537	3537
q11	587	486	489	486
q12	862	630	600	600
q13	9409	3236	3212	3212
q14	318	269	275	269
q15	587	520	527	520
q16	683	668	646	646
q17	1868	1620	1585	1585
q18	8373	7739	7560	7560
q19	1700	1650	1561	1561
q20	2129	1858	1883	1858
q21	5545	5411	5377	5377
q22	1159	1047	1079	1047
Total cold run time: 70277 ms
Total hot run time: 60519 ms

doris-robot · 2024-10-17T08:02:57Z

TPC-DS: Total hot run time: 192686 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 61a16e887262ed0bddbd58339773e41c7aba7451, data reload: false
query1	934	418	400	400
query2	6244	2143	2061	2061
query3	8684	191	200	191
query4	33654	23701	23577	23577
query5	3540	492	458	458
query6	277	166	169	166
query7	4197	298	291	291
query8	287	236	245	236
query9	9579	2749	2749	2749
query10	457	295	269	269
query11	17852	15256	15297	15256
query12	153	114	106	106
query13	1568	440	419	419
query14	9982	7379	7583	7379
query15	249	172	186	172
query16	7901	455	432	432
query17	1664	616	575	575
query18	1950	308	314	308
query19	397	160	158	158
query20	124	116	115	115
query21	210	107	105	105
query22	5006	4578	4778	4578
query23	36713	34261	34295	34261
query24	10994	2717	2791	2717
query25	529	410	400	400
query26	735	158	164	158
query27	2223	279	289	279
query28	7573	2469	2451	2451
query29	662	420	437	420
query30	271	148	164	148
query31	1033	806	818	806
query32	106	66	59	59
query33	764	290	305	290
query34	911	519	514	514
query35	889	752	754	752
query36	1125	939	971	939
query37	148	86	90	86
query38	4034	3910	3938	3910
query39	1471	1462	1426	1426
query40	205	97	99	97
query41	50	46	52	46
query42	125	104	106	104
query43	529	491	489	489
query44	1264	811	805	805
query45	198	165	166	165
query46	1133	708	721	708
query47	1949	1822	1867	1822
query48	417	343	315	315
query49	933	432	454	432
query50	827	395	405	395
query51	7032	6943	6893	6893
query52	101	91	95	91
query53	266	184	182	182
query54	1217	435	444	435
query55	90	78	80	78
query56	279	294	264	264
query57	1268	1144	1166	1144
query58	245	229	231	229
query59	3248	3134	2925	2925
query60	288	272	266	266
query61	104	104	105	104
query62	852	671	675	671
query63	239	190	187	187
query64	3818	633	627	627
query65	3295	3222	3251	3222
query66	843	312	314	312
query67	16231	15703	15862	15703
query68	4449	585	580	580
query69	499	316	287	287
query70	1200	1122	1122	1122
query71	352	288	277	277
query72	7028	4043	4014	4014
query73	776	359	372	359
query74	10347	9144	9018	9018
query75	3413	2700	2673	2673
query76	2907	859	969	859
query77	641	300	321	300
query78	10834	9770	9583	9583
query79	2065	588	598	588
query80	1297	452	465	452
query81	579	238	234	234
query82	706	141	147	141
query83	302	161	134	134
query84	277	69	71	69
query85	1573	315	282	282
query86	449	308	313	308
query87	4557	4277	4313	4277
query88	2888	2268	2213	2213
query89	405	295	288	288
query90	2074	192	187	187
query91	133	101	98	98
query92	65	46	48	46
query93	2069	533	540	533
query94	1206	293	291	291
query95	358	253	252	252
query96	637	285	280	280
query97	3289	3144	3118	3118
query98	206	203	195	195
query99	1576	1342	1300	1300
Total cold run time: 301293 ms
Total hot run time: 192686 ms

doris-robot · 2024-10-17T08:08:25Z

ClickBench: Total hot run time: 33.72 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 61a16e887262ed0bddbd58339773e41c7aba7451, data reload: false
query1	0.04	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.52	0.50	0.50
query6	1.13	0.72	0.71
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.55	0.55
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.62	0.60	0.59
query14	2.81	2.85	2.73
query15	0.89	0.84	0.83
query16	0.39	0.38	0.38
query17	1.02	1.09	0.97
query18	0.20	0.20	0.20
query19	1.88	1.88	2.02
query20	0.01	0.01	0.01
query21	15.36	0.60	0.57
query22	2.82	2.27	2.49
query23	17.13	0.85	0.90
query24	2.82	1.54	1.56
query25	0.17	0.10	0.12
query26	0.61	0.14	0.14
query27	0.07	0.05	0.04
query28	10.00	1.10	1.06
query29	12.56	3.26	3.23
query30	0.24	0.06	0.06
query31	2.87	0.39	0.38
query32	3.27	0.47	0.46
query33	3.03	3.01	3.05
query34	16.73	4.43	4.45
query35	4.52	4.48	4.54
query36	0.66	0.48	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.22 s
Total hot run time: 33.72 s

dataroaring · 2024-10-20T02:04:51Z

run buildall

github-actions · 2024-10-20T02:08:22Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-10-20T02:41:48Z

TeamCity be ut coverage result:
Function Coverage: 37.47% (9707/25908)
Line Coverage: 28.75% (80636/280500)
Region Coverage: 28.18% (41712/148031)
Branch Coverage: 24.76% (21211/85652)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae47d035e8f6e1034faea22a488b0167cd08deaa_ae47d035e8f6e1034faea22a488b0167cd08deaa/report/index.html

doris-robot · 2024-10-20T02:45:17Z

TPC-H: Total hot run time: 41073 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ae47d035e8f6e1034faea22a488b0167cd08deaa, data reload: false
------ Round 1 ----------------------------------
q1	17581	7423	7254	7254
q2	2027	280	267	267
q3	12183	1071	1192	1071
q4	10584	858	763	763
q5	7767	3071	3042	3042
q6	241	156	160	156
q7	1014	613	608	608
q8	9370	1861	1980	1861
q9	6544	6396	6385	6385
q10	7026	2398	2426	2398
q11	445	247	248	247
q12	417	226	222	222
q13	17788	3002	2989	2989
q14	248	213	221	213
q15	573	511	521	511
q16	652	578	585	578
q17	968	540	540	540
q18	7234	6791	6697	6697
q19	1348	1016	1020	1016
q20	479	186	185	185
q21	3949	3054	3216	3054
q22	1127	1035	1016	1016
Total cold run time: 109565 ms
Total hot run time: 41073 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7284	7276	7239	7239
q2	326	232	229	229
q3	3015	2955	2903	2903
q4	2109	1823	1828	1823
q5	5717	5742	5792	5742
q6	237	149	147	147
q7	2260	1862	1855	1855
q8	3321	3592	3411	3411
q9	8975	8982	8927	8927
q10	3548	3540	3548	3540
q11	597	490	497	490
q12	811	639	629	629
q13	9782	3176	3190	3176
q14	306	271	278	271
q15	562	514	521	514
q16	690	666	634	634
q17	1863	1661	1617	1617
q18	8230	7899	7698	7698
q19	1691	1483	1487	1483
q20	2149	1902	1899	1899
q21	5555	5431	5306	5306
q22	1179	1050	1058	1050
Total cold run time: 70207 ms
Total hot run time: 60583 ms

doris-robot · 2024-10-20T02:57:25Z

TPC-DS: Total hot run time: 192472 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ae47d035e8f6e1034faea22a488b0167cd08deaa, data reload: false
query1	943	397	407	397
query2	6253	2088	2037	2037
query3	8684	195	208	195
query4	34291	23807	23566	23566
query5	3626	495	466	466
query6	268	173	169	169
query7	4195	306	303	303
query8	321	243	228	228
query9	9526	2721	2723	2721
query10	452	274	286	274
query11	18240	15265	15489	15265
query12	154	100	102	100
query13	1554	451	409	409
query14	9307	7323	7316	7316
query15	246	172	184	172
query16	7655	468	443	443
query17	1606	601	585	585
query18	1470	319	309	309
query19	257	173	159	159
query20	134	116	120	116
query21	211	108	115	108
query22	4870	4618	4580	4580
query23	35001	34344	35075	34344
query24	10997	2787	2775	2775
query25	559	411	396	396
query26	761	156	168	156
query27	2273	282	296	282
query28	7360	2424	2417	2417
query29	677	434	431	431
query30	271	153	168	153
query31	1058	778	810	778
query32	94	55	57	55
query33	771	303	306	303
query34	932	506	520	506
query35	907	750	761	750
query36	1124	925	945	925
query37	146	91	85	85
query38	4032	3934	3962	3934
query39	1525	1422	1419	1419
query40	214	100	102	100
query41	50	50	47	47
query42	124	101	101	101
query43	537	503	495	495
query44	1215	828	798	798
query45	202	167	167	167
query46	1139	709	694	694
query47	1914	1853	1812	1812
query48	426	317	339	317
query49	960	443	441	441
query50	836	389	406	389
query51	7237	6974	6971	6971
query52	104	96	96	96
query53	258	182	184	182
query54	1136	423	426	423
query55	79	80	80	80
query56	296	274	281	274
query57	1308	1171	1144	1144
query58	272	237	253	237
query59	3171	2907	2855	2855
query60	293	258	270	258
query61	106	106	103	103
query62	843	666	685	666
query63	216	192	185	185
query64	3870	652	621	621
query65	3306	3214	3223	3214
query66	825	298	308	298
query67	15985	15558	16045	15558
query68	4768	569	567	567
query69	571	300	300	300
query70	1205	1140	1087	1087
query71	388	279	279	279
query72	7519	4015	3959	3959
query73	785	357	363	357
query74	10433	9059	9001	9001
query75	4073	2671	2679	2671
query76	3233	930	866	866
query77	671	296	303	296
query78	10478	9673	9677	9673
query79	2836	608	614	608
query80	1031	439	477	439
query81	558	238	236	236
query82	699	136	144	136
query83	352	136	137	136
query84	275	67	70	67
query85	1450	314	290	290
query86	454	298	303	298
query87	4512	4377	4281	4281
query88	4091	2221	2172	2172
query89	401	297	289	289
query90	2013	190	192	190
query91	132	103	111	103
query92	72	47	46	46
query93	2449	565	558	558
query94	1098	290	285	285
query95	356	245	248	245
query96	626	279	287	279
query97	3302	3131	3112	3112
query98	216	197	195	195
query99	1583	1298	1314	1298
Total cold run time: 302303 ms
Total hot run time: 192472 ms

doris-robot · 2024-10-20T03:02:53Z

ClickBench: Total hot run time: 32.84 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ae47d035e8f6e1034faea22a488b0167cd08deaa, data reload: false
query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.22	0.06	0.07
query4	1.65	0.11	0.10
query5	0.50	0.51	0.51
query6	1.13	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.56	0.55	0.54
query11	0.13	0.10	0.10
query12	0.13	0.11	0.11
query13	0.61	0.58	0.59
query14	2.73	2.84	2.73
query15	0.89	0.84	0.84
query16	0.38	0.41	0.38
query17	0.98	1.06	1.00
query18	0.20	0.21	0.20
query19	1.98	1.87	2.03
query20	0.01	0.01	0.01
query21	15.36	0.61	0.58
query22	2.47	2.40	2.01
query23	17.06	1.18	0.79
query24	2.60	1.26	0.99
query25	0.23	0.09	0.05
query26	0.47	0.14	0.14
query27	0.05	0.04	0.03
query28	11.29	1.08	1.07
query29	12.60	3.28	3.23
query30	0.25	0.06	0.06
query31	2.88	0.38	0.37
query32	3.28	0.47	0.46
query33	2.99	3.03	3.05
query34	16.94	4.44	4.44
query35	4.54	4.50	4.47
query36	0.66	0.48	0.49
query37	0.08	0.06	0.05
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.15	0.14	0.12
query41	0.06	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.93 s
Total hot run time: 32.84 s

dataroaring · 2024-10-30T02:58:19Z

run buildall

github-actions · 2024-10-30T02:59:17Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-10-30T03:51:15Z

TPC-H: Total hot run time: 41439 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f7a0d0002cfd7708c8503615d24bbc34f2d54d56, data reload: false
------ Round 1 ----------------------------------
q1	17590	7527	7405	7405
q2	2039	158	151	151
q3	10582	1154	1129	1129
q4	10226	801	955	801
q5	7741	3117	3085	3085
q6	238	147	146	146
q7	1012	605	608	605
q8	9346	1985	2030	1985
q9	6667	6460	6471	6460
q10	7069	2390	2437	2390
q11	437	252	248	248
q12	411	222	209	209
q13	17775	3015	2963	2963
q14	249	213	210	210
q15	569	520	520	520
q16	635	577	596	577
q17	995	526	581	526
q18	7382	6702	6803	6702
q19	1340	1032	1115	1032
q20	493	185	184	184
q21	4100	3117	3245	3117
q22	1133	994	1020	994
Total cold run time: 108029 ms
Total hot run time: 41439 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7363	7318	7287	7287
q2	327	240	227	227
q3	2923	2822	2813	2813
q4	1951	1670	1681	1670
q5	5463	5502	5504	5502
q6	236	142	146	142
q7	2187	1692	1706	1692
q8	3311	3432	3449	3432
q9	8559	8657	8688	8657
q10	3491	3517	3472	3472
q11	591	483	484	483
q12	806	565	581	565
q13	9943	2993	3024	2993
q14	289	260	262	260
q15	549	515	513	513
q16	673	637	661	637
q17	1843	1606	1578	1578
q18	7854	7463	7406	7406
q19	1689	1548	1480	1480
q20	2057	1828	1826	1826
q21	5525	5157	5190	5157
q22	1122	1011	1003	1003
Total cold run time: 68752 ms
Total hot run time: 58795 ms

doris-robot · 2024-10-30T03:57:38Z

TeamCity be ut coverage result:
Function Coverage: 37.94% (9845/25949)
Line Coverage: 29.21% (81979/280629)
Region Coverage: 28.56% (42276/148049)
Branch Coverage: 25.08% (21487/85660)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f7a0d0002cfd7708c8503615d24bbc34f2d54d56_f7a0d0002cfd7708c8503615d24bbc34f2d54d56/report/index.html

doris-robot · 2024-10-30T04:03:22Z

TPC-DS: Total hot run time: 191751 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f7a0d0002cfd7708c8503615d24bbc34f2d54d56, data reload: false
query1	996	372	372	372
query2	6530	2159	2096	2096
query3	6790	212	219	212
query4	34002	23842	23527	23527
query5	4353	464	425	425
query6	260	178	162	162
query7	4590	301	308	301
query8	301	234	236	234
query9	9585	2696	2688	2688
query10	438	245	246	245
query11	18081	15293	15293	15293
query12	150	101	100	100
query13	1657	431	408	408
query14	10305	6938	7084	6938
query15	252	178	187	178
query16	8041	433	417	417
query17	1663	566	556	556
query18	2079	293	293	293
query19	356	153	155	153
query20	118	109	104	104
query21	205	102	101	101
query22	4382	4381	4503	4381
query23	35232	34107	34106	34106
query24	11108	2769	2780	2769
query25	658	409	400	400
query26	1381	162	157	157
query27	2847	279	286	279
query28	8123	2453	2429	2429
query29	882	423	416	416
query30	319	168	160	160
query31	1019	799	821	799
query32	94	58	58	58
query33	794	275	270	270
query34	981	507	516	507
query35	1015	882	875	875
query36	1094	966	974	966
query37	143	76	82	76
query38	4369	4346	4216	4216
query39	1480	1427	1417	1417
query40	271	104	101	101
query41	51	47	48	47
query42	113	102	100	100
query43	562	508	514	508
query44	1235	801	817	801
query45	188	171	165	165
query46	1119	672	696	672
query47	1970	1850	1877	1850
query48	411	327	325	325
query49	1176	415	400	400
query50	816	377	390	377
query51	7150	7016	7016	7016
query52	99	90	88	88
query53	253	182	177	177
query54	1207	426	412	412
query55	79	83	79	79
query56	261	249	252	249
query57	1345	1208	1200	1200
query58	250	211	213	211
query59	3335	2895	3056	2895
query60	293	243	252	243
query61	106	103	103	103
query62	870	696	672	672
query63	210	184	180	180
query64	5347	638	627	627
query65	3285	3234	3211	3211
query66	1442	310	300	300
query67	16242	15894	15735	15735
query68	4972	575	549	549
query69	432	259	261	259
query70	1182	1137	1169	1137
query71	429	259	260	259
query72	6689	4103	3992	3992
query73	769	365	355	355
query74	10538	8963	8902	8902
query75	3427	2657	2661	2657
query76	3104	949	970	949
query77	459	268	274	268
query78	10418	9594	9538	9538
query79	1834	597	603	597
query80	1034	442	420	420
query81	552	248	244	244
query82	938	120	116	116
query83	211	151	146	146
query84	229	71	69	69
query85	1323	295	280	280
query86	430	308	307	307
query87	4932	4732	4596	4596
query88	3450	2200	2156	2156
query89	397	297	287	287
query90	2079	185	186	185
query91	133	102	105	102
query92	61	48	47	47
query93	1770	548	529	529
query94	962	258	294	258
query95	348	241	237	237
query96	613	273	281	273
query97	2888	2725	2723	2723
query98	222	200	199	199
query99	1531	1318	1287	1287
Total cold run time: 304715 ms
Total hot run time: 191751 ms

doris-robot · 2024-10-30T04:08:51Z

ClickBench: Total hot run time: 32.08 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f7a0d0002cfd7708c8503615d24bbc34f2d54d56, data reload: false
query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.64	0.10	0.10
query5	0.41	0.40	0.41
query6	1.15	0.66	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.50	0.49
query10	0.55	0.58	0.55
query11	0.14	0.11	0.12
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.79	2.70	2.72
query15	0.90	0.84	0.83
query16	0.37	0.36	0.37
query17	0.99	1.06	1.00
query18	0.23	0.22	0.22
query19	1.94	1.77	1.91
query20	0.02	0.01	0.02
query21	15.41	0.59	0.58
query22	2.53	2.12	1.90
query23	16.92	1.09	0.81
query24	3.30	0.54	1.11
query25	0.29	0.08	0.18
query26	0.37	0.14	0.13
query27	0.04	0.04	0.04
query28	10.97	1.10	1.06
query29	12.64	3.32	3.31
query30	0.24	0.06	0.07
query31	2.85	0.38	0.38
query32	3.27	0.46	0.45
query33	2.96	3.04	3.01
query34	16.93	4.45	4.42
query35	4.49	4.47	4.46
query36	0.70	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 107.22 s
Total hot run time: 32.08 s

github-actions · 2024-10-31T13:05:36Z

PR approved by anyone and no changes requested.

github-actions · 2024-10-31T13:20:33Z

PR approved by at least one committer and no changes requested.

) ### What problem does this PR solve?   Issue Number: close #xxx  Related PR: #xxx Problem Summary: ### Check List (For Committer) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No colde files have been changed. - [x] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  - Release note   None ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

gavinchou reviewed Oct 22, 2024
View reviewed changes

Comment threadbe/src/runtime/exec_env_init.cpp

dataroaring added 4 commits October 30, 2024 10:33

[fix](exit) stop storage engine in exec_env before exit
4f07eaa

fix
f2735f4

fix
f1d81e8

fix
f7a0d00

dataroaring force-pushed the storage_engine_exit branch from ae47d03 to f7a0d00Compare October 30, 2024 02:54

Yukang-Lian approved these changes Oct 31, 2024
View reviewed changes

github-actionsBot added the reviewed label Oct 31, 2024

w41ter approved these changes Oct 31, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024

dataroaring merged commit 7e3a976 into apache:masterOct 31, 2024

dataroaring added the dev/3.0.x label Oct 31, 2024

dataroaring added a commit to dataroaring/incubator-doris that referenced this pull request Nov 2, 2024
[fix](exit) stop storage engine in exec_env before exit (apache#42015)
f56d747

dataroaring added dev/3.0.3-merged and removed dev/3.0.x labels Nov 2, 2024

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[fix](exit) stop storage engine in exec_env before exit (apache#42015)
ce4e92a

Uh oh!

Conversation

dataroaring commented Oct 17, 2024

Proposed changes

Uh oh!

doris-robot commented Oct 17, 2024

Uh oh!

dataroaring commented Oct 17, 2024

Uh oh!

github-actionsBot commented Oct 17, 2024

Uh oh!

dataroaring commented Oct 17, 2024

Uh oh!

github-actionsBot commented Oct 17, 2024

Uh oh!

doris-robot commented Oct 17, 2024

Uh oh!

doris-robot commented Oct 17, 2024

Uh oh!

doris-robot commented Oct 17, 2024

Uh oh!

dataroaring commented Oct 20, 2024

Uh oh!

github-actionsBot commented Oct 20, 2024

Uh oh!

doris-robot commented Oct 20, 2024

Uh oh!

doris-robot commented Oct 20, 2024

Uh oh!

doris-robot commented Oct 20, 2024

Uh oh!

doris-robot commented Oct 20, 2024

Uh oh!

Uh oh!

dataroaring commented Oct 30, 2024

Uh oh!

github-actionsBot commented Oct 30, 2024

Uh oh!

doris-robot commented Oct 30, 2024

Uh oh!

doris-robot commented Oct 30, 2024

Uh oh!

doris-robot commented Oct 30, 2024

Uh oh!

doris-robot commented Oct 30, 2024

Uh oh!

github-actionsBot commented Oct 31, 2024

Uh oh!

github-actionsBot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants