Skip to content

[fix](cloud) Fix tablet_id is zero when txn lazy commit - #42043

Merged
dataroaring merged 3 commits into
apache:masterfrom
swjtu-zhanglei:master-fix8
Oct 28, 2024
Merged

[fix](cloud) Fix tablet_id is zero when txn lazy commit#42043
dataroaring merged 3 commits into
apache:masterfrom
swjtu-zhanglei:master-fix8

Conversation

@swjtu-zhanglei

@swjtu-zhangleiswjtu-zhanglei commented Oct 17, 2024•
edited by gavinchou
Loading

Copy link
Copy Markdown
Contributor
  • when recycler and ms convert tmp rowsets at the same times, and finish convert task with different partitions severally, may cause tablet_id variable is zero

@doris-robot

doris-robot commented Oct 17, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@swjtu-zhangleiswjtu-zhanglei changed the title [fix](cloud) Fix tablet_id is zere when txn lazy commit[fix](cloud) Fix tablet_id is zero when txn lazy commitOct 17, 2024
@swjtu-zhanglei

swjtu-zhanglei commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@swjtu-zhanglei

swjtu-zhanglei commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@swjtu-zhanglei

swjtu-zhanglei commented Oct 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Oct 21, 2024
View reviewed changes
Comment threadcloud/src/meta-service/txn_lazy_committer.cpp Outdated
@swjtu-zhanglei

swjtu-zhanglei commented Oct 22, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Oct 24, 2024
View reviewed changes
Comment threadcloud/src/meta-service/txn_lazy_committer.cpp Outdated
tmp_rowset_pb;
}

int64_t table_id = -1;

@gavinchougavinchouOct 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-stream-multi-table load?

@swjtu-zhangleiswjtu-zhangleiOct 24, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-stream-multi-table load?

done

@swjtu-zhanglei
[fix](cloud) Fix tablet_id is zero when txn lazy commit
ba38259
* when ry and ms convert tmp rowsets at the same times, and finish convert task
with different partitions severally, may cause tablet_id variable is zero
@swjtu-zhanglei
fix some comments
135dff8
@swjtu-zhanglei
fix some comments
86cf70d
@swjtu-zhanglei

swjtu-zhanglei commented Oct 24, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2024
@github-actions

github-actionsBot commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

deardeng
deardeng approved these changes Oct 25, 2024
View reviewed changes

@deardengdeardeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 4bb7139 into apache:masterOct 28, 2024
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Oct 30, 2024
@swjtu-zhanglei
[fix](cloud) Fix tablet_id is zero when txn lazy commit (apache#42043)
39cfd72
* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero
@swjtu-zhangleiswjtu-zhanglei mentioned this pull request Oct 30, 2024
Merged
dataroaring pushed a commit that referenced this pull request Oct 31, 2024
@swjtu-zhanglei
[fix](cloud) Fix tablet_id is zero when txn lazy commit (#42043) (#42905
79b6a99
)
* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@swjtu-zhanglei@HappenLee
[fix](cloud) Fix tablet_id is zero when txn lazy commit (apache#42043)
6b6163a
* when recycler and ms convert tmp rowsets at the same times, and finish
convert task with different partitions severally, may cause tablet_id
variable is zero
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deardengdeardengdeardeng approved these changes
@gavinchougavinchougavinchou approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swjtu-zhanglei@doris-robot@deardeng@gavinchou@dataroaring