Skip to content

Compaction rules optimization - #4212

Merged
morningman merged 10 commits into
apache:masterfrom
ZhangYu0123:compaction_rules_optimization
Aug 19, 2020
Merged

Compaction rules optimization#4212
morningman merged 10 commits into
apache:masterfrom
ZhangYu0123:compaction_rules_optimization

Conversation

@ZhangYu0123

Copy link
Copy Markdown
Contributor

Proposed changes

Compaction rules optimization, the detail problem description and design to see #4164.
This pr commits 2 functions:
(1) add the cumulative policy configable, and implement original policy.
(2) implement universal policy, the optimization version in #4164.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on #ISSUE, and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

@morningmanmorningman self-assigned this Jul 30, 2020
@morningmanmorningman added area/compact Issues or PRs related to the compact branch-0.13 PR which need to merge to branch 0.13 kind/improvement labels Jul 30, 2020
Comment threadbe/src/common/config.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.cpp Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.cpp Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.cpp Outdated
Comment threadbe/src/olap/tablet.cpp Outdated
Comment threadbe/src/common/config.h Outdated
@ZhangYu0123
ZhangYu0123force-pushed the compaction_rules_optimization branch 2 times, most recently from f44fc4f to 3c3d441CompareAugust 7, 2020 02:08
Comment threadbe/src/common/config.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/cumulative_compaction_policy.h
Comment threadbe/src/olap/cumulative_compaction_policy.h Outdated
Comment threadbe/src/olap/olap_server.cpp Outdated
@ZhangYu0123
ZhangYu0123force-pushed the compaction_rules_optimization branch from 3c3d441 to 0d2a83bCompareAugust 18, 2020 08:15

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadbe/src/olap/cumulative_compaction_policy.h
Comment threadbe/src/olap/cumulative_compaction_policy.h
@morningman
morningman merged commit dc3ed1c into apache:masterAug 19, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Aug 21, 2020
Compaction rules optimization, the detail problem description and design to see apache#4164.
This pr commits 2 functions:
(1) add the cumulative policy configable, and implement original policy.
(2) implement universal policy, the optimization version in apache#4164.
@EmmyMiao87EmmyMiao87 mentioned this pull request Sep 1, 2020
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compactIssues or PRs related to the compactbranch-0.13PR which need to merge to branch 0.13kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ZhangYu0123@morningman@yangzhg@kangkaisen