Skip to content

[fix](config) change segment_cache_fd_percentage and inverted_index_fd_number_limit_percent default value - #42224

Merged
dataroaring merged 2 commits into
apache:masterfrom
xiaokang:change_fd_default
Oct 24, 2024
Merged

[fix](config) change segment_cache_fd_percentage and inverted_index_fd_number_limit_percent default value#42224
dataroaring merged 2 commits into
apache:masterfrom
xiaokang:change_fd_default

Conversation

@xiaokang

@xiaokangxiaokang commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

change segment_cache_fd_percentage and inverted_index_fd_number_limit_percent default value from 40% to 20% to avoid too many open files.

@doris-robot

doris-robot commented Oct 21, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xiaokang

xiaokang commented Oct 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 21, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.46% (9699/25891)
Line Coverage: 28.70% (80491/280472)
Region Coverage: 28.14% (41644/147990)
Branch Coverage: 24.71% (21161/85638)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a539c41c3aa3cfbf81e428d04f95fba5cf714603_a539c41c3aa3cfbf81e428d04f95fba5cf714603/report/index.html

airborne12
airborne12 approved these changes Oct 21, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 21, 2024
@github-actions

github-actionsBot commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@xiaokang

xiaokang commented Oct 23, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 23, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.47% (9708/25910)
Line Coverage: 28.73% (80534/280271)
Region Coverage: 28.16% (41647/147884)
Branch Coverage: 24.72% (21154/85562)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f4c6714a0219bd573d89f7990d7e427e5d4a18e7_f4c6714a0219bd573d89f7990d7e427e5d4a18e7/report/index.html

dataroaring
dataroaring approved these changes Oct 24, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit afd9c09 into apache:masterOct 24, 2024
@xiaokangxiaokang mentioned this pull request Oct 24, 2024
Merged
xiaokang added a commit to xiaokang/doris that referenced this pull request Oct 24, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
24b0e03
…d_number_limit_percent default value (apache#42224)
change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
@xiaokangxiaokang mentioned this pull request Oct 24, 2024
Merged
xiaokang added a commit to xiaokang/doris that referenced this pull request Oct 24, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
58a22bd
…d_number_limit_percent default value (apache#42224)
change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
@xiaokangxiaokang mentioned this pull request Oct 24, 2024
Merged
xiaokang added a commit to xiaokang/doris that referenced this pull request Oct 24, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
5bf5bb8
…d_number_limit_percent default value (apache#42224)
change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
xiaokang added a commit that referenced this pull request Oct 25, 2024
@xiaokang
[fix](config) change inverted_index_fd_number_limit_percent default v…
45608e7
…alue #42224 (#42426)
xiaokang added a commit that referenced this pull request Oct 28, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
c387816
…d_number_limit_percent default value #42224 (#42423)
@xiaokangxiaokang added dev/2.0.16-merged-deprecated 2.0.16 is NOT and will NOT be released dev/2.1.7-merged labels Oct 28, 2024
xiaokang added a commit that referenced this pull request Oct 28, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
cea29ac
…d_number_limit_percent default value #42224 (#42424)
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@xiaokang@HappenLee
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
95cf53d
…d_number_limit_percent default value (apache#42224)
change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.16-merged-deprecated2.0.16 is NOT and will NOT be releaseddev/2.1.7-mergeddev/3.0.3-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaokang@doris-robot@airborne12@dataroaring