Uh oh!
There was an error while loading. Please reload this page.
[fix](load) Fix potential data loss during disk migration - #42296
Merged
Conversation
doris-robot
commented
Oct 22, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
liaoxin01
commented
Oct 22, 2024
ContributorAuthor
run buildall |
liaoxin01
commented
Oct 22, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Oct 22, 2024
TeamCity be ut coverage result: |
liaoxin01
commented
Oct 23, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Oct 23, 2024
TeamCity be ut coverage result: |
liaoxin01
commented
Oct 23, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
liaoxin01
commented
Oct 23, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Oct 23, 2024
TeamCity be ut coverage result: |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
This was referenced Oct 24, 2024
liaoxin01 added a commit
to liaoxin01/doris
that referenced
this pull request
Oct 24, 2024
The following operations may trigger this issue. 1. migration start 2. load start using old tablet，but wait migration lock in `RowsetBuilder::prepare_txn`. 3. migration finish, old tablet -> new tablet 4. obtained migration lock and commit successfully using old tablet. 5. publish failed using old tablet, because old tablet has been dropped. It cause the data loss. Therefore, after acquiring the migration lock, check if the tablet has already been shut down. If it has, it indicates that it is an old tablet, and data should not be imported into the old tablet.
liaoxin01 added a commit
to liaoxin01/doris
that referenced
this pull request
Oct 24, 2024
The following operations may trigger this issue. 1. migration start 2. load start using old tablet，but wait migration lock in `RowsetBuilder::prepare_txn`. 3. migration finish, old tablet -> new tablet 4. obtained migration lock and commit successfully using old tablet. 5. publish failed using old tablet, because old tablet has been dropped. It cause the data loss. Therefore, after acquiring the migration lock, check if the tablet has already been shut down. If it has, it indicates that it is an old tablet, and data should not be imported into the old tablet.
liaoxin01 added a commit
that referenced
this pull request
Oct 24, 2024
liaoxin01 added a commit
that referenced
this pull request
Oct 24, 2024
liaoxin01 added a commit
that referenced
this pull request
Oct 24, 2024
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
The following operations may trigger this issue. 1. migration start 2. load start using old tablet，but wait migration lock in `RowsetBuilder::prepare_txn`. 3. migration finish, old tablet -> new tablet 4. obtained migration lock and commit successfully using old tablet. 5. publish failed using old tablet, because old tablet has been dropped. It cause the data loss. Therefore, after acquiring the migration lock, check if the tablet has already been shut down. If it has, it indicates that it is an old tablet, and data should not be imported into the old tablet.
16 tasks
deardeng added a commit
that referenced
this pull request
Aug 5, 2026
Cause: PR #54124 moved the migration and push locks from RowsetBuilder into Tablet::prepare_txn. During that refactor, the call to TxnManager::prepare_txn changed from the const Tablet& overload to the raw tablet_id/tablet_uid overload. This silently bypassed the TABLET_SHUTDOWN guard introduced by PR #42296. Impact: A load thread holding an old Tablet instance could resume after migration and register the stale tablet UID in the transaction map. Publish would then operate on the reloaded Tablet with a new UID and leave the transaction in an E-909 state. Fix: Call the const Tablet& overload with *this while the migration and push locks are held. This preserves the lock encapsulation from PR #54124 and restores the shutdown-tablet protection from PR #42296. Test: Add a deterministic unit test that marks a Tablet as TABLET_SHUTDOWN, verifies Tablet::prepare_txn fails, and verifies no stale tablet entry is registered. TxnManagerTest.* passes 16/16.
github-actionsBot
pushed a commit
that referenced
this pull request
Aug 5, 2026
Cause: PR #54124 moved the migration and push locks from RowsetBuilder into Tablet::prepare_txn. During that refactor, the call to TxnManager::prepare_txn changed from the const Tablet& overload to the raw tablet_id/tablet_uid overload. This silently bypassed the TABLET_SHUTDOWN guard introduced by PR #42296. Impact: A load thread holding an old Tablet instance could resume after migration and register the stale tablet UID in the transaction map. Publish would then operate on the reloaded Tablet with a new UID and leave the transaction in an E-909 state. Fix: Call the const Tablet& overload with *this while the migration and push locks are held. This preserves the lock encapsulation from PR #54124 and restores the shutdown-tablet protection from PR #42296. Test: Add a deterministic unit test that marks a Tablet as TABLET_SHUTDOWN, verifies Tablet::prepare_txn fails, and verifies no stale tablet entry is registered. TxnManagerTest.* passes 16/16.
github-actionsBot
pushed a commit
that referenced
this pull request
Aug 5, 2026
Cause: PR #54124 moved the migration and push locks from RowsetBuilder into Tablet::prepare_txn. During that refactor, the call to TxnManager::prepare_txn changed from the const Tablet& overload to the raw tablet_id/tablet_uid overload. This silently bypassed the TABLET_SHUTDOWN guard introduced by PR #42296. Impact: A load thread holding an old Tablet instance could resume after migration and register the stale tablet UID in the transaction map. Publish would then operate on the reloaded Tablet with a new UID and leave the transaction in an E-909 state. Fix: Call the const Tablet& overload with *this while the migration and push locks are held. This preserves the lock encapsulation from PR #54124 and restores the shutdown-tablet protection from PR #42296. Test: Add a deterministic unit test that marks a Tablet as TABLET_SHUTDOWN, verifies Tablet::prepare_txn fails, and verifies no stale tablet entry is registered. TxnManagerTest.* passes 16/16.
wyxxxcat pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 17, 2026
Cause: PR apache#54124 moved the migration and push locks from RowsetBuilder into Tablet::prepare_txn. During that refactor, the call to TxnManager::prepare_txn changed from the const Tablet& overload to the raw tablet_id/tablet_uid overload. This silently bypassed the TABLET_SHUTDOWN guard introduced by PR apache#42296. Impact: A load thread holding an old Tablet instance could resume after migration and register the stale tablet UID in the transaction map. Publish would then operate on the reloaded Tablet with a new UID and leave the transaction in an E-909 state. Fix: Call the const Tablet& overload with *this while the migration and push locks are held. This preserves the lock encapsulation from PR apache#54124 and restores the shutdown-tablet protection from PR apache#42296. Test: Add a deterministic unit test that marks a Tablet as TABLET_SHUTDOWN, verifies Tablet::prepare_txn fails, and verifies no stale tablet entry is registered. TxnManagerTest.* passes 16/16.
morrySnow pushed a commit
that referenced
this pull request
Aug 31, 2026
Cause: PR #54124 moved the migration and push locks from RowsetBuilder into Tablet::prepare_txn. During that refactor, the call to TxnManager::prepare_txn changed from the const Tablet& overload to the raw tablet_id/tablet_uid overload. This silently bypassed the TABLET_SHUTDOWN guard introduced by PR #42296. Impact: A load thread holding an old Tablet instance could resume after migration and register the stale tablet UID in the transaction map. Publish would then operate on the reloaded Tablet with a new UID and leave the transaction in an E-909 state. Fix: Call the const Tablet& overload with *this while the migration and push locks are held. This preserves the lock encapsulation from PR #54124 and restores the shutdown-tablet protection from PR #42296. Test: Add a deterministic unit test that marks a Tablet as TABLET_SHUTDOWN, verifies Tablet::prepare_txn fails, and verifies no stale tablet entry is registered. TxnManagerTest.* passes 16/16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following operations may trigger this issue.
RowsetBuilder::prepare_txn.Therefore, after acquiring the migration lock, check if the tablet has already been shut down. If it has, it indicates that it is an old tablet, and data should not be imported into the old tablet.