Skip to content

[Opt](config) adjust segment cache - #42308

Merged
eldenmoon merged 1 commit into
apache:masterfrom
eldenmoon:master
Oct 24, 2024
Merged

[Opt](config) adjust segment cache#42308
eldenmoon merged 1 commit into
apache:masterfrom
eldenmoon:master

Conversation

@eldenmoon

@eldenmooneldenmoon commented Oct 23, 2024

Copy link
Copy Markdown
Member

For wide tables the default segment cache capacity is relatively small and lead to many cache eviction in high compaction/query load

@doris-robot

doris-robot commented Oct 23, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

xiaokang
xiaokang previously approved these changes Oct 23, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@github-actions

github-actionsBot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon

eldenmoon commented Oct 23, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Oct 23, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.48% (9707/25902)
Line Coverage: 28.73% (80486/280189)
Region Coverage: 28.16% (41627/147832)
Branch Coverage: 24.72% (21148/85562)
Coverage Report: http://coverage.selectdb-in.cc/coverage/72a8cfd77d77476881869b1ca3bf637bf8826805_72a8cfd77d77476881869b1ca3bf637bf8826805/report/index.html

dataroaring
dataroaring previously approved these changes Oct 24, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qidaye
qidaye previously approved these changes Oct 24, 2024
View reviewed changes

@qidayeqidaye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon
[Opt](config) adjust segment cache
96a9f94
For wide tables the default segment cache capacity is relatively small and lead to many cache eviction in high compaction/query load
@eldenmoon
eldenmoon dismissed stale reviews from qidaye, dataroaring, and xiaokang via 96a9f94October 24, 2024 03:26
@eldenmoon

eldenmoon commented Oct 24, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
@github-actions

github-actionsBot commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 24, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.30% (9665/25913)
Line Coverage: 28.54% (79992/280248)
Region Coverage: 28.00% (41395/147837)
Branch Coverage: 24.62% (21060/85538)
Coverage Report: http://coverage.selectdb-in.cc/coverage/96a9f9491c4ce5e759faa05c6b7fc3fcbc178bc9_96a9f9491c4ce5e759faa05c6b7fc3fcbc178bc9/report/index.html

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
@github-actions

github-actionsBot commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

airborne12
airborne12 approved these changes Oct 24, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon
eldenmoon merged commit 220744e into apache:masterOct 24, 2024
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
39c4987
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
This was referenced Oct 24, 2024
Merged
Merged
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
c2fb6c1
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
8cc28ae
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
6bde6d3
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
eldenmoon added a commit that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (#42308) (#42436)
ecbd135
(#42308)
eldenmoon added a commit that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (#42308) (#42431)
e6bc8ab
#42308
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@eldenmoon@HappenLee
[Opt](config) adjust segment cache (apache#42308)
ae4c4d3
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@qidayeqidayeqidaye approved these changes
@xiaokangxiaokangxiaokang left review comments
@dataroaringdataroaringdataroaring left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eldenmoon@doris-robot@xiaokang@airborne12@qidaye@dataroaring