Skip to content

[BUG] Using attachement strategy of brpc to send packet with big size. - #4237

Merged
chaoyli merged 3 commits into
apache:masterfrom
chaoyli:master
Aug 5, 2020
Merged

[BUG] Using attachement strategy of brpc to send packet with big size.#4237
chaoyli merged 3 commits into
apache:masterfrom
chaoyli:master

Conversation

@chaoyli

@chaoylichaoyli commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

BRPC send packet should serialize it first and then send it.
If we send one batch with big size, it will encounter a connection failed.
So we can use attachment strategy to bypass the problem and eliminate
the serialization cost.

@chaoylichaoyli self-assigned this Aug 3, 2020
@chaoylichaoyli added the kind/fix Categorizes issue or PR as related to a bug. label Aug 3, 2020
@chaoylichaoyli linked an issue Aug 3, 2020 that may be closed by this pull request
Big packet will send failed on BRPC #4238
Closed
@chaoyli
[BUG] Using attachement strategy of brpc to send packet with big size.
00f4d35
BRPC send packet should serialize it first and then send it.
If we send one batch with big size, it will encounter a connection failed.
So we can use attachment strategy to bypass the problem and eliminate
the serialization cost.
imay
imay requested changes Aug 3, 2020
View reviewed changes
Comment threadbe/src/common/config.h Outdated
Comment threadbe/src/runtime/data_stream_sender.cpp
Comment threadbe/src/runtime/data_stream_sender.cpp Outdated
imay
imay approved these changes Aug 4, 2020
View reviewed changes

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imayimay added the approved Indicates a PR has been approved by one committer. label Aug 4, 2020
@chaoyli
chaoyli merged commit 120f30b into apache:masterAug 5, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Aug 6, 2020
@morningman-cmy
Revert "[BUG] Using attachement strategy of brpc to send packet with …
4b7e97d
…big size. (apache#4237)"
This reverts commit 120f30b.
morningman pushed a commit to morningman/doris that referenced this pull request Aug 6, 2020
@morningman-cmy
Revert "Revert "[BUG] Using attachement strategy of brpc to send pack…
853d8d0
…et with big size. (apache#4237)""
This reverts commit 4b7e97d.
chaoyli pushed a commit that referenced this pull request Aug 6, 2020
lichaoyong
Revert "[BUG] Using attachement strategy of brpc to send packet with …
5d9c6b9
…big size. (#4237)"
This reverts commit 120f30b.
@chaoylichaoyli mentioned this pull request Aug 6, 2020
Merged
morningman pushed a commit that referenced this pull request Aug 6, 2020
@chaoyli
Revert "[BUG] Using attachement strategy of brpc to send packet with …
b62ff85
…big size. (#4237)" (#4267)
This reverts commit 120f30b.
@morningmanmorningman mentioned this pull request Aug 6, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imayimayimay approved these changes

Assignees

@chaoylichaoyli

Labels

approvedIndicates a PR has been approved by one committer.kind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Big packet will send failed on BRPC

2 participants

@chaoyli@imay