Skip to content

[Bug] fix after making MemTracker shared - #4243

Merged
morningman merged 4 commits into
apache:masterfrom
vagetablechicken:shared_fix
Aug 4, 2020
Merged

[Bug] fix after making MemTracker shared#4243
morningman merged 4 commits into
apache:masterfrom
vagetablechicken:shared_fix

Conversation

@vagetablechicken

@vagetablechickenvagetablechicken commented Aug 4, 2020

Copy link
Copy Markdown
Member

after making MemTracker shared(#4135), some code haven't been fixed, and add some useless ut back to build. Fixed in this pr.

ADD_BE_TEST(buffered_tuple_stream2_test)
#ADD_BE_TEST(tmp_file_mgr_test)
#ADD_BE_TEST(disk_io_mgr_test)
#ADD_BE_TEST(mem_limit_test)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment these three unit tests ?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a mistake uncomment of pr 4135

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added approved Indicates a PR has been approved by one committer. kind/test kind/fix Categorizes issue or PR as related to a bug. branch-0.13 PR which need to merge to branch 0.13 labels Aug 4, 2020
@morningman
morningman merged commit bfb8c65 into apache:masterAug 4, 2020
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 8, 2025
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.branch-0.13PR which need to merge to branch 0.13kind/fixCategorizes issue or PR as related to a bug.kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vagetablechicken@morningman@EmmyMiao87