Skip to content

Do not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr) - #4245

Merged
imay merged 1 commit into
apache:masterfrom
liutang123:4241
Aug 11, 2020
Merged

Do not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr)#4245
imay merged 1 commit into
apache:masterfrom
liutang123:4241

Conversation

@liutang123

@liutang123liutang123 commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

for #4241

@liutang123liutang123 changed the title Do not wrap NULL type tupleDo not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr)Aug 4, 2020
imay
imay previously approved these changes Aug 6, 2020
View reviewed changes

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imayimay added approved Indicates a PR has been approved by one committer. area/sql Issues or PRs related to SQL area/planner Issues or PRs related to the query planner labels Aug 6, 2020
morningman
morningman reviewed Aug 6, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java Outdated
imay
imay approved these changes Aug 11, 2020
View reviewed changes

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay
imay merged commit a480dec into apache:masterAug 11, 2020
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 8, 2025
@mrhhsg
[fix](test) Avoid the configuration item disable_datev1 affecting oth…
3b5b2fb
…er test cases (apache#52915) (apache#4245)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman left review comments
@imayimayimay approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerarea/sqlIssues or PRs related to SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liutang123@imay@morningman