[improve](cloud) support arm compilation in cloud mode by luwei16 · Pull Request #42467 · apache/doris

luwei16 · 2024-10-25T06:13:16Z

Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

doris-robot · 2024-10-25T06:13:20Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-10-25T06:13:59Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors


'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/fdb/fdb_ctl.sh line 84:
arch=`uname -m`
^--------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean: arch=$(uname -m)
In tools/fdb/fdb_ctl.sh line 85:
if [ $arch == "x86_64" ]; then
^-------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean: if [[ "${arch}" == "x86_64" ]]; then
In tools/fdb/fdb_ctl.sh line 97:
elif [ $arch == "aarch64" ]; then
^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean: elif [[ "${arch}" == "aarch64" ]]; then
In tools/fdb/fdb_ctl.sh line 110:
echo "Unsupported architecture: "$arch
^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean: echo "Unsupported architecture: ""${arch}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.

shfmt errors


'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/fdb/fdb_ctl.sh.orig
+++ tools/fdb/fdb_ctl.sh
@@ -81,7 +81,7 @@
return
fi
- arch=`uname -m`
+ arch=$(uname -m)
if [ $arch == "x86_64" ]; then
local URL="https://github.com/apple/foundationdb/releases/download/${FDB_VERSION}/"
local TMP="${FDB_PKG_DIR}-tmp"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename

github-actions · 2024-10-25T06:17:54Z

clang-tidy review says "All clean, LGTM! 👍"

luwei16 · 2024-10-25T06:25:30Z

run buildall

github-actions · 2024-10-25T06:27:12Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-10-25T06:52:09Z

TPC-H: Total hot run time: 41454 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95795116d4cbfbaee34594aa6f0ee10ee3e6adc6, data reload: false
------ Round 1 ----------------------------------
q1	17565	7443	7298	7298
q2	2035	279	274	274
q3	12068	1070	1178	1070
q4	10577	877	866	866
q5	7748	3095	3093	3093
q6	229	150	148	148
q7	1033	634	595	595
q8	9370	1987	1976	1976
q9	6598	6508	6438	6438
q10	7044	2408	2449	2408
q11	450	247	245	245
q12	407	223	222	222
q13	17788	3015	3017	3015
q14	239	218	233	218
q15	570	509	518	509
q16	640	594	587	587
q17	963	524	524	524
q18	7276	6871	6608	6608
q19	1338	1026	1019	1019
q20	465	186	186	186
q21	4008	3286	3164	3164
q22	1097	1006	991	991
Total cold run time: 109508 ms
Total hot run time: 41454 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7332	7326	7296	7296
q2	337	223	226	223
q3	3080	3024	2969	2969
q4	2126	1831	1809	1809
q5	5782	5766	5809	5766
q6	220	139	139	139
q7	2281	1856	1784	1784
q8	3451	3511	3536	3511
q9	8924	8879	8880	8879
q10	3598	3560	3538	3538
q11	597	487	496	487
q12	827	642	592	592
q13	10976	3214	3182	3182
q14	307	274	276	274
q15	579	541	524	524
q16	688	654	642	642
q17	1851	1631	1611	1611
q18	8280	7827	7596	7596
q19	1736	1686	1527	1527
q20	2144	1855	1869	1855
q21	5478	5395	5416	5395
q22	1179	1055	1042	1042
Total cold run time: 71773 ms
Total hot run time: 60641 ms

doris-robot · 2024-10-25T07:04:07Z

TPC-DS: Total hot run time: 191623 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95795116d4cbfbaee34594aa6f0ee10ee3e6adc6, data reload: false
query1	874	439	411	411
query2	6232	2087	2023	2023
query3	8682	193	196	193
query4	35122	23642	23607	23607
query5	4972	457	456	456
query6	273	165	171	165
query7	4208	296	299	296
query8	292	238	233	233
query9	9451	2665	2658	2658
query10	496	249	250	249
query11	18088	15322	15234	15234
query12	150	103	100	100
query13	1567	436	407	407
query14	9386	6732	6774	6732
query15	250	169	176	169
query16	7928	476	482	476
query17	1501	590	555	555
query18	2136	317	312	312
query19	254	157	157	157
query20	123	116	112	112
query21	211	106	108	106
query22	4927	4538	4532	4532
query23	34897	34268	34125	34125
query24	10718	2724	2749	2724
query25	596	403	395	395
query26	723	160	161	160
query27	2085	284	295	284
query28	6489	2433	2417	2417
query29	757	415	424	415
query30	278	158	156	156
query31	1000	811	789	789
query32	96	54	56	54
query33	658	280	273	273
query34	904	512	530	512
query35	995	875	865	865
query36	1098	949	968	949
query37	121	73	78	73
query38	4344	4236	4295	4236
query39	1486	1427	1423	1423
query40	196	101	111	101
query41	50	45	48	45
query42	110	96	95	95
query43	527	477	492	477
query44	1167	816	820	816
query45	180	167	167	167
query46	1140	701	696	696
query47	1987	1831	1883	1831
query48	415	320	324	320
query49	914	408	411	408
query50	809	384	386	384
query51	7101	7042	7012	7012
query52	97	90	91	90
query53	257	175	178	175
query54	1076	401	406	401
query55	84	80	77	77
query56	263	265	237	237
query57	1331	1165	1159	1159
query58	214	195	210	195
query59	3130	2895	2875	2875
query60	268	246	250	246
query61	108	99	107	99
query62	830	680	669	669
query63	213	187	177	177
query64	3775	637	611	611
query65	3284	3205	3250	3205
query66	790	301	316	301
query67	16099	15753	15819	15753
query68	4465	557	560	557
query69	420	252	292	252
query70	1209	1172	1164	1164
query71	354	265	254	254
query72	6238	4022	3961	3961
query73	758	357	353	353
query74	10128	8955	8989	8955
query75	3413	2626	2664	2626
query76	2865	981	932	932
query77	367	275	272	272
query78	10588	9534	9615	9534
query79	1742	586	590	586
query80	1094	425	433	425
query81	574	238	242	238
query82	632	116	115	115
query83	239	148	138	138
query84	245	69	70	69
query85	1276	317	279	279
query86	403	305	297	297
query87	4755	4710	4638	4638
query88	3446	2222	2195	2195
query89	410	289	297	289
query90	2026	186	188	186
query91	136	102	104	102
query92	59	49	48	48
query93	1865	543	543	543
query94	915	297	253	253
query95	359	245	239	239
query96	626	274	274	274
query97	2877	2713	2745	2713
query98	217	194	193	193
query99	1568	1288	1317	1288
Total cold run time: 297052 ms
Total hot run time: 191623 ms

doris-robot · 2024-10-25T07:09:38Z

ClickBench: Total hot run time: 32.36 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95795116d4cbfbaee34594aa6f0ee10ee3e6adc6, data reload: false
query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.09
query5	0.40	0.38	0.39
query6	1.13	0.68	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.49	0.50
query10	0.56	0.54	0.55
query11	0.15	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.60	0.59
query14	2.71	2.74	2.73
query15	0.89	0.82	0.82
query16	0.39	0.39	0.37
query17	1.07	1.05	1.04
query18	0.20	0.19	0.20
query19	1.97	1.88	1.90
query20	0.02	0.01	0.01
query21	15.38	0.59	0.59
query22	2.75	1.82	1.76
query23	17.10	0.84	0.85
query24	3.30	0.72	1.41
query25	0.20	0.16	0.15
query26	0.49	0.13	0.14
query27	0.05	0.04	0.05
query28	10.54	1.09	1.07
query29	12.59	3.31	3.30
query30	0.24	0.06	0.06
query31	2.92	0.40	0.38
query32	3.26	0.47	0.45
query33	3.00	3.05	3.07
query34	17.16	4.46	4.43
query35	4.55	4.46	4.44
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.48 s
Total hot run time: 32.36 s

luwei16 · 2024-10-29T14:44:35Z

run buildall

github-actions · 2024-10-29T14:47:28Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-10-29T15:52:53Z

TPC-H: Total hot run time: 41880 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 82a320a99f69d73db3e0549cc10ae535c67a7fe0, data reload: false
------ Round 1 ----------------------------------
q1	17792	7746	7488	7488
q2	2047	156	164	156
q3	10843	1109	1188	1109
q4	10415	840	845	840
q5	7743	3116	3096	3096
q6	240	151	151	151
q7	1027	628	613	613
q8	9355	1997	2018	1997
q9	6625	6506	6503	6503
q10	7072	2457	2447	2447
q11	457	245	252	245
q12	416	218	208	208
q13	17791	3012	3053	3012
q14	242	211	218	211
q15	565	519	515	515
q16	685	575	583	575
q17	1010	526	541	526
q18	7375	6789	6740	6740
q19	1433	1098	1052	1052
q20	470	181	188	181
q21	4051	3235	3180	3180
q22	1094	1044	1035	1035
Total cold run time: 108748 ms
Total hot run time: 41880 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7351	7335	7321	7321
q2	328	230	227	227
q3	3089	3000	2969	2969
q4	2126	1860	1846	1846
q5	5774	5813	5818	5813
q6	231	146	147	146
q7	2297	1788	1827	1788
q8	3390	3462	3510	3462
q9	8984	8919	8953	8919
q10	3614	3561	3543	3543
q11	582	495	495	495
q12	811	629	618	618
q13	9131	3160	3227	3160
q14	305	292	294	292
q15	575	530	517	517
q16	694	655	626	626
q17	1881	1667	1635	1635
q18	8362	8003	7610	7610
q19	1745	1656	1523	1523
q20	2135	1856	1878	1856
q21	5631	5538	5392	5392
q22	1150	1079	1060	1060
Total cold run time: 70186 ms
Total hot run time: 60818 ms

doris-robot · 2024-10-29T16:05:08Z

TPC-DS: Total hot run time: 197508 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 82a320a99f69d73db3e0549cc10ae535c67a7fe0, data reload: false
query1	1262	1007	994	994
query2	6227	2146	2090	2090
query3	11589	4800	4916	4800
query4	33455	23681	23708	23681
query5	4899	462	440	440
query6	278	182	172	172
query7	3992	295	300	295
query8	293	239	238	238
query9	9404	2750	2747	2747
query10	489	250	246	246
query11	18101	15154	15400	15154
query12	161	105	102	102
query13	1578	420	416	416
query14	9511	6933	7135	6933
query15	243	186	175	175
query16	7871	480	495	480
query17	1528	560	561	560
query18	1866	296	293	293
query19	268	152	149	149
query20	129	116	109	109
query21	204	99	100	99
query22	4940	4571	4678	4571
query23	34838	34111	34347	34111
query24	11020	2747	2765	2747
query25	612	377	378	377
query26	1284	153	156	153
query27	2550	278	274	274
query28	7669	2447	2428	2428
query29	843	391	393	391
query30	256	158	158	158
query31	1014	769	826	769
query32	88	60	53	53
query33	946	269	266	266
query34	1122	515	520	515
query35	1058	915	875	875
query36	1094	963	958	958
query37	136	71	73	71
query38	4385	4361	4278	4278
query39	1452	1426	1411	1411
query40	250	97	93	93
query41	44	44	42	42
query42	110	99	97	97
query43	538	477	494	477
query44	1300	806	796	796
query45	182	165	165	165
query46	1135	686	702	686
query47	1955	1868	1901	1868
query48	419	323	320	320
query49	902	387	378	378
query50	832	375	389	375
query51	7083	7021	6881	6881
query52	98	84	87	84
query53	253	185	179	179
query54	1115	405	401	401
query55	75	76	77	76
query56	258	230	237	230
query57	1322	1147	1152	1147
query58	220	203	197	197
query59	3317	2948	2907	2907
query60	294	257	244	244
query61	120	119	116	116
query62	850	679	684	679
query63	215	190	186	186
query64	4235	708	673	673
query65	3270	3192	3198	3192
query66	933	320	311	311
query67	16029	15856	15872	15856
query68	3716	574	562	562
query69	426	268	267	267
query70	1223	1134	1117	1117
query71	318	266	282	266
query72	6178	4052	4105	4052
query73	763	361	359	359
query74	10029	9052	9008	9008
query75	3643	2678	2715	2678
query76	2462	1080	1038	1038
query77	385	265	271	265
query78	10539	9621	9570	9570
query79	1331	588	601	588
query80	1072	417	421	417
query81	560	247	243	243
query82	1016	119	117	117
query83	241	138	134	134
query84	239	72	69	69
query85	1233	299	284	284
query86	360	300	310	300
query87	4802	4737	4604	4604
query88	3401	2225	2213	2213
query89	414	286	289	286
query90	2033	185	183	183
query91	128	102	96	96
query92	59	48	47	47
query93	1423	533	551	533
query94	906	289	300	289
query95	347	236	242	236
query96	623	272	297	272
query97	2916	2695	2735	2695
query98	206	197	192	192
query99	1515	1293	1319	1293
Total cold run time: 300516 ms
Total hot run time: 197508 ms

doris-robot · 2024-10-29T16:10:38Z

ClickBench: Total hot run time: 32.8 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 82a320a99f69d73db3e0549cc10ae535c67a7fe0, data reload: false
query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.64	0.10	0.10
query5	0.41	0.39	0.39
query6	1.16	0.65	0.67
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.49
query10	0.54	0.55	0.55
query11	0.13	0.11	0.11
query12	0.13	0.10	0.10
query13	0.60	0.60	0.60
query14	2.72	2.83	2.74
query15	0.90	0.81	0.83
query16	0.39	0.37	0.38
query17	1.08	1.06	1.01
query18	0.20	0.20	0.20
query19	1.93	1.79	1.96
query20	0.01	0.02	0.01
query21	15.38	0.60	0.59
query22	2.70	2.77	1.91
query23	16.86	1.07	0.85
query24	3.28	1.09	1.54
query25	0.17	0.10	0.07
query26	0.58	0.14	0.14
query27	0.04	0.03	0.07
query28	10.03	1.09	1.07
query29	12.63	3.33	3.36
query30	0.25	0.06	0.05
query31	2.87	0.37	0.38
query32	3.29	0.47	0.46
query33	2.98	3.01	3.01
query34	16.68	4.52	4.46
query35	4.57	4.51	4.63
query36	0.66	0.48	0.51
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.03	0.02
Total cold run time: 106.22 s
Total hot run time: 32.8 s

dataroaring

LGTM

github-actions · 2024-10-30T04:12:38Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-10-30T04:12:40Z

PR approved by anyone and no changes requested.

Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

pick master #42467 Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

[selectdb-cloud] support arm compilation in cloud mode
303b247

luwei16 changed the title ~~[selectdb-cloud] support arm compilation in cloud mode~~[improve](cloud) support arm compilation in cloud modeOct 25, 2024

fix code style
9579511

change url
82a320a

dataroaring approved these changes Oct 30, 2024
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 30, 2024

gavinchou approved these changes Oct 30, 2024
View reviewed changes

gavinchou self-requested a review October 30, 2024 09:25

gavinchou approved these changes Oct 30, 2024
View reviewed changes

gavinchou added the dev/3.0.x label Oct 30, 2024

gavinchou merged commit 11d2940 into apache:masterOct 30, 2024

github-actionsBot pushed a commit that referenced this pull request Oct 30, 2024
[improve](cloud) support arm compilation in cloud mode (#42467)
8d46d38
Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

github-actionsBot mentioned this pull request Oct 30, 2024
branch-3.0: [improve](cloud) support arm compilation in cloud mode #42912
Closed

hello-stephen mentioned this pull request Nov 6, 2024
[chore](fix) fix compile cloud bug #42555
Closed

luwei16 added a commit to luwei16/Doris that referenced this pull request Nov 6, 2024
[improve](cloud) support arm compilation in cloud mode (apache#42467)
7fd71cc
Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

luwei16 mentioned this pull request Nov 6, 2024
[improve](cloud) support arm compilation in cloud mode (#42467) #43377
Merged

dataroaring pushed a commit that referenced this pull request Nov 7, 2024
[improve](cloud) support arm compilation in cloud mode (#42467) (#43377)
da61d29
pick master #42467 Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

dataroaring added dev/3.0.3-merged and removed dev/3.0.x labels Nov 7, 2024

gavinchou mentioned this pull request Nov 26, 2024
Release Note 3.0.3 #44522
Closed

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[improve](cloud) support arm compilation in cloud mode (apache#42467)
6b90734
Azure is not supported yet. You need to export DISABLE_BUILD_AZURE=ON && sh build.sh --cloud when compiling.

Uh oh!

Conversation

luwei16 commented Oct 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented Oct 25, 2024

Uh oh!

github-actionsBot commented Oct 25, 2024

sh-checker report

Uh oh!

github-actionsBot commented Oct 25, 2024

Uh oh!

luwei16 commented Oct 25, 2024

Uh oh!

github-actionsBot commented Oct 25, 2024

Uh oh!

doris-robot commented Oct 25, 2024

Uh oh!

doris-robot commented Oct 25, 2024

Uh oh!

doris-robot commented Oct 25, 2024

Uh oh!

luwei16 commented Oct 29, 2024

Uh oh!

github-actionsBot commented Oct 29, 2024

Uh oh!

doris-robot commented Oct 29, 2024

Uh oh!

doris-robot commented Oct 29, 2024

Uh oh!

doris-robot commented Oct 29, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Oct 30, 2024

Uh oh!

github-actionsBot commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

luwei16 commented Oct 25, 2024•
edited
Loading

`sh-checker report`