Skip to content

[feature](function)support url domain functions - #42488

Merged
zhangstar333 merged 3 commits into
apache:masterfrom
zhangstar333:topurl_function
Oct 30, 2024
Merged

[feature](function)support url domain functions#42488
zhangstar333 merged 3 commits into
apache:masterfrom
zhangstar333:topurl_function

Conversation

@zhangstar333

@zhangstar333zhangstar333 commented Oct 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

support top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain functions
doc: apache/doris-website#1230

@doris-robot

doris-robot commented Oct 25, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01

LiBinfeng-01 commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

need to add fe fold const when adding new scalar function to fe, which can refer to: https://selectdb.feishu.cn/wiki/BGfGwgY2uiQrK7krGUVcYJFknVg?from=from_copylink

github-actions[bot]
github-actionsBot reviewed Oct 25, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 39. Check the log or trigger a new build to see more.

Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
@zhangstar333

zhangstar333 commented Oct 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@zhangstar333

zhangstar333 commented Oct 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Oct 25, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/tldLookup.generated.cpp
Comment threadbe/src/vec/functions/url/tldLookup.generated.cpp
Comment threadbe/src/vec/functions/url/tldLookup.generated.cpp
Comment threadbe/src/vec/functions/url/tldLookup.generated.cpp
Comment threadbe/src/vec/functions/url/tldLookup.generated.cpp
@doris-robot

doris-robot commented Oct 25, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.41% (9713/25964)
Line Coverage: 28.68% (80572/280967)
Region Coverage: 28.11% (41654/148156)
Branch Coverage: 24.67% (21158/85778)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1fddbae0c025fc94f2ee358047cdc094f0bbcc3f_1fddbae0c025fc94f2ee358047cdc094f0bbcc3f/report/index.html

HappenLee
HappenLee reviewed Oct 25, 2024
View reviewed changes
Comment threadbe/src/vec/functions/url/domain.h
@zhangstar333

zhangstar333 commented Oct 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 25, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.42% (9716/25966)
Line Coverage: 28.70% (80606/280875)
Region Coverage: 28.13% (41668/148124)
Branch Coverage: 24.70% (21177/85748)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1fddbae0c025fc94f2ee358047cdc094f0bbcc3f_1fddbae0c025fc94f2ee358047cdc094f0bbcc3f/report/index.html

HappenLee
HappenLee reviewed Oct 26, 2024
View reviewed changes
Comment threadbe/src/vec/functions/url/find_symbols.h Outdated
HappenLee
HappenLee reviewed Oct 26, 2024
View reviewed changes
Comment threadbe/src/vec/functions/url/domain.h
HappenLee
HappenLee reviewed Oct 26, 2024
View reviewed changes
Comment threadbe/src/vec/functions/url/domain.h Outdated
HappenLee
HappenLee reviewed Oct 26, 2024
View reviewed changes
Comment threadbe/src/vec/functions/url/domain.h Outdated
@zhangstar333

zhangstar333 commented Oct 29, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Oct 29, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/find_symbols.h
Comment threadbe/src/vec/functions/url/tldLookup.generated.cpp
@doris-robot

doris-robot commented Oct 29, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.40% (9718/25986)
Line Coverage: 28.67% (80603/281107)
Region Coverage: 28.11% (41674/148233)
Branch Coverage: 24.67% (21167/85798)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69abebbac54482416a59fe5d4e42f058f6572060_69abebbac54482416a59fe5d4e42f058f6572060/report/index.html

HappenLee
HappenLee approved these changes Oct 30, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 30, 2024
@github-actions

github-actionsBot commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

zclllyybb
zclllyybb approved these changes Oct 30, 2024
View reviewed changes

@zclllyybbzclllyybb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread.../apache/doris/nereids/trees/expressions/functions/scalar/CutToFirstSignificantSubdomain.java
@zhangstar333
zhangstar333 merged commit 8843efc into apache:masterOct 30, 2024
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Oct 30, 2024
@zhangstar333
[feature](function)support url domain functions (apache#42488)
a36755a
support
top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain
functions
doc: apache/doris-website#1230
<!--Describe your changes.-->
yiguolei pushed a commit that referenced this pull request Oct 31, 2024
@zhangstar333
[cherry-pick](branch-21) cherry-pick pr about (#42488) (#42099) (#42055…
6c3d42e
…) (#42916)
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
@zy-kkkzy-kkk mentioned this pull request Oct 31, 2024
Merged
zy-kkk added a commit that referenced this pull request Oct 31, 2024
@zy-kkk
[fix](build) Fix Mac compilation error caused by namespace conflict i…
c1c9420
…n find_symbols.h (#43004)
From #42488
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Nov 13, 2024
@zy-kkk
[fix](build) Fix Mac compilation error caused by namespace conflict i…
581f065
…n find_symbols.h (apache#43004)
From apache#42488
@zy-kkkzy-kkk mentioned this pull request Nov 13, 2024
Merged
16 tasks
cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Nov 14, 2024
@zy-kkk@cambyzju
[fix](build) Fix Mac compilation error caused by namespace conflict i…
fe83c18
…n find_symbols.h (apache#43004)
From apache#42488
github-actionsBot pushed a commit that referenced this pull request Jan 17, 2025
@zhangstar333Your Name
[feature](function)support url domain functions (#42488)
bc1e46c
## Proposed changes
support
top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain
functions
doc: apache/doris-website#1230
<!--Describe your changes.-->
@github-actionsgithub-actionsBot mentioned this pull request Jan 17, 2025
Merged
dataroaring pushed a commit that referenced this pull request Feb 25, 2025
@zhangstar333@dataroaring
[feature](function)support url domain functions (#42488)
13628ab
## Proposed changes
support
top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain
functions
doc: apache/doris-website#1230
<!--Describe your changes.-->
@zhangstar333zhangstar333 added the usercase Important user case type label label Feb 26, 2025
dataroaring pushed a commit that referenced this pull request Feb 27, 2025
@github-actions@zhangstar333
branch-3.0: [feature](function)support url domain functions#42488(#…
ae90c3c
…47188)
Cherry-picked from #42488
Co-authored-by: zhangstar333 <87313068+zhangstar333@users.noreply.github.com>
github-actionsBot pushed a commit that referenced this pull request Mar 14, 2025
@zy-kkkYour Name
[fix](build) Fix Mac compilation error caused by namespace conflict i…
eee58c7
…n find_symbols.h (#43004)
From #42488
@gavinchougavinchou mentioned this pull request Apr 23, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zhangstar333@HappenLee
[feature](function)support url domain functions (apache#42488)
e21d302
## Proposed changes
support
top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain
functions
doc: apache/doris-website#1230
<!--Describe your changes.-->
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zy-kkk@HappenLee
[fix](build) Fix Mac compilation error caused by namespace conflict i…
6b7cef6
…n find_symbols.h (apache#43004)
From apache#42488
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@morrySnowmorrySnowmorrySnow left review comments
@HappenLeeHappenLeeHappenLee approved these changes
@zclllyybbzclllyybbzclllyybb approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.5-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@zhangstar333@doris-robot@LiBinfeng-01@HappenLee@zclllyybb@morrySnow@yiguolei@wm1581066@dataroaring