Skip to content

Support sequence column for UNIQUE_KEYS Table - #4256

Merged
yangzhg merged 6 commits into
apache:masterfrom
Youngwb:sequence_col
Sep 4, 2020
Merged

Support sequence column for UNIQUE_KEYS Table#4256
yangzhg merged 6 commits into
apache:masterfrom
Youngwb:sequence_col

Conversation

@Youngwb

@YoungwbYoungwb commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

For #3930

yangzhg
yangzhg reviewed Aug 10, 2020
View reviewed changes
Comment threadbe/src/olap/tablet_schema.h Outdated
yangzhg
yangzhg reviewed Aug 10, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java Outdated
yangzhg
yangzhg reviewed Aug 10, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/common/FeMetaVersion.java
yangzhg
yangzhg reviewed Aug 11, 2020
View reviewed changes

@yangzhgyangzhg left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You pr may cause CREATE EXTERNAL TABLE from hdfs failed and query failed after create materialize view. Please check it

@Youngwb
Youngwb requested a review from yangzhgAugust 17, 2020 02:41
@Youngwb
Youngwbforce-pushed the sequence_col branch 3 times, most recently from 9d04603 to 7f278fdCompareAugust 27, 2020 15:20
@morningmanmorningman self-assigned this Aug 27, 2020
@morningmanmorningman added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2020
yangzhg
yangzhg reviewed Aug 28, 2020
View reviewed changes
Comment threadbe/test/olap/test_data/header.txt Outdated
yangzhg
yangzhg reviewed Aug 28, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java Outdated
yangzhg
yangzhg previously approved these changes Aug 28, 2020
View reviewed changes

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yangzhg
yangzhg approved these changes Aug 31, 2020
View reviewed changes

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Sep 1, 2020
@yangzhg
yangzhg merged commit 0687074 into apache:masterSep 4, 2020
@YoungwbYoungwb mentioned this pull request Sep 8, 2020
Closed
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhgyangzhgyangzhg approved these changes

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.kind/featureCategorizes issue or PR as related to a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Youngwb@yangzhg@morningman