Uh oh!
There was an error while loading. Please reload this page.
[Opt](Variant) merge schema in sync_rowsets to prevents from CPU overhead each time describe table - #42856
Merged
Merged
Conversation
…head each time describe table Should prevent from merge schema each time calling `merged_tablet_schema`. So this pr put the merge logic in `sync_rowsets` stage.
doris-robot
commented
Oct 29, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
eldenmoon
commented
Oct 29, 2024
MemberAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Oct 29, 2024
TeamCity be ut coverage result: |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
github-actionsBot
pushed a commit
that referenced
this pull request
Nov 1, 2024
…head each time describe table (#42856) Should prevent from merge schema each time calling `merged_tablet_schema`. So this pr put the merge logic in `sync_rowsets` stage.
eldenmoon added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 4, 2024
…head each time describe table (apache#42856) Should prevent from merge schema each time calling `merged_tablet_schema`. So this pr put the merge logic in `sync_rowsets` stage.
16 tasks
zzzxl1993 pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Nov 12, 2024
…to make schema more accurate (apache#43580) Related PR: apache#42856 previous PR only merge schema in `CloudTablet::sync_rowsets` but `CloudTablet:: sync_tablet_rowsets ` may already done by other logic Co-authored-by: eldenmoon <lihangyu@selectdb.com>
924060929 pushed a commit
to 924060929/incubator-doris
that referenced
this pull request
Nov 12, 2024
…to make schema more accurate (apache#43580) Related PR: apache#42856 previous PR only merge schema in `CloudTablet::sync_rowsets` but `CloudTablet:: sync_tablet_rowsets ` may already done by other logic Co-authored-by: eldenmoon <lihangyu@selectdb.com>
py023 pushed a commit
to py023/doris
that referenced
this pull request
Nov 13, 2024
…to make schema more accurate (apache#43580) Related PR: apache#42856 previous PR only merge schema in `CloudTablet::sync_rowsets` but `CloudTablet:: sync_tablet_rowsets ` may already done by other logic Co-authored-by: eldenmoon <lihangyu@selectdb.com>
Closed
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…head each time describe table (apache#42856) Should prevent from merge schema each time calling `merged_tablet_schema`. So this pr put the merge logic in `sync_rowsets` stage.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…to make schema more accurate (apache#43580) Related PR: apache#42856 previous PR only merge schema in `CloudTablet::sync_rowsets` but `CloudTablet:: sync_tablet_rowsets ` may already done by other logic Co-authored-by: eldenmoon <lihangyu@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should prevent from merge schema each time calling
merged_tablet_schema. So this pr put the merge logic insync_rowsetsstage.