Skip to content

[fix](regression-test) fix test_hive_serde_prop - #42886

Merged
morningman merged 2 commits into
apache:masterfrom
suxiaogang223:fix_serde_prop_case
Nov 1, 2024
Merged

[fix](regression-test) fix test_hive_serde_prop#42886
morningman merged 2 commits into
apache:masterfrom
suxiaogang223:fix_serde_prop_case

Conversation

@suxiaogang223

Copy link
Copy Markdown
Member

Proposed changes

fellow #42200

Null values ​​in text tables are now correctly recognized now.

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223

Copy link
Copy Markdown
MemberAuthor

run buildall

@suxiaogang223
suxiaogang223 marked this pull request as ready for review October 31, 2024 11:10
@suxiaogang223

Copy link
Copy Markdown
MemberAuthor

run buildall

@suxiaogang223

suxiaogang223 commented Oct 31, 2024

Copy link
Copy Markdown
MemberAuthor

There are inconsistencies between hive2 and hive3 regarding whether to print false values.

hive> select * from test_open_csv_default_prop;
OK
1 John Doe 28 50000.75 TRUE 2022-01-15 2023-10-21 14:30:00 4.5 Senior Developer
2 Jane,Smith 2020-05-20 "Project Manager"
Time taken: 0.053 seconds, Fetched: 2 row(s)
hive> select * from serde_test7;
OK
1 NULL
2 |||
3 aaa
4 "null"
Time taken: 0.05 seconds, Fetched: 4 row(s)

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit beef40f into apache:masterNov 1, 2024
morningman pushed a commit to morningman/doris that referenced this pull request Nov 1, 2024
## Proposed changes
fellow apache#42200
Null values ​​in text tables are now correctly recognized now.
morningman pushed a commit to morningman/doris that referenced this pull request Nov 1, 2024
## Proposed changes
fellow apache#42200
Null values ​​in text tables are now correctly recognized now.
github-actionsBot pushed a commit that referenced this pull request Nov 1, 2024
## Proposed changes
fellow #42200
Null values ​​in text tables are now correctly recognized now.
yiguolei pushed a commit that referenced this pull request Nov 1, 2024
cherry pick from #42886
Co-authored-by: Socrates <suxiaogang223@icloud.com>
morningman added a commit that referenced this pull request Nov 1, 2024
cherry pick from #42886
Co-authored-by: Socrates <suxiaogang223@icloud.com>
@suxiaogang223
suxiaogang223 deleted the fix_serde_prop_case branch November 5, 2024 03:00
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
## Proposed changes
fellow apache#42200
Null values ​​in text tables are now correctly recognized now.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@suxiaogang223@doris-robot@morningman@wuwenchi@yiguolei