[Fix](Authenticator)defaultAuthenticator not init by CalvinKirs · Pull Request #43057 · apache/doris

CalvinKirs · 2024-11-01T06:20:58Z

What problem does this PR solve?

The defaultAuthenticator is not initialized. When a configured authentication plugin implements the canDeal method and returns false, the defaultAuthenticator will be used, resulting in a login failure. The client exception message is RROR 2013 (HY000): Lost connection to MySQL server at 'reading authorization packet', system error: 2. This issue only affects users who use non-built-in authentication plugins that implement canDeal and return false under certain circumstances.

#40113 introduced this issue

1： The `defaultAuthenticator` is not initialized. When a configured authentication plugin implements the `canDea`l method and returns `false`, the `defaultAuthenticator` will be used, resulting in a login failure. The client exception message is `RROR 2013 (HY000): Lost connection to MySQL server at 'reading authorization packet', system error: 2`. This issue only affects users who use non-built-in authentication plugins that implement `canDeal` and return false under certain circumstances. apache#40113 introduced this issue

doris-robot · 2024-11-01T06:21:02Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

CalvinKirs · 2025-02-17T03:27:54Z

run buildall

doris-robot · 2025-02-17T03:48:27Z

TPC-H: Total hot run time: 31695 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 26b6a51cb635c04c1233f0afe554a41c2683269c, data reload: false
------ Round 1 ----------------------------------
q1	17702	5229	5129	5129
q2	2049	307	190	190
q3	10768	1324	716	716
q4	10320	1005	532	532
q5	9320	2340	2416	2340
q6	230	171	135	135
q7	915	753	621	621
q8	9316	1329	1100	1100
q9	5629	4742	4698	4698
q10	6820	2326	1931	1931
q11	477	270	242	242
q12	345	351	216	216
q13	17780	3697	3037	3037
q14	223	237	226	226
q15	512	463	455	455
q16	629	599	582	582
q17	570	889	344	344
q18	7484	6171	6285	6171
q19	1305	965	556	556
q20	318	319	197	197
q21	3239	2257	1975	1975
q22	367	332	302	302
Total cold run time: 106318 ms
Total hot run time: 31695 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5455	5156	5183	5156
q2	236	332	228	228
q3	2198	2678	2318	2318
q4	1503	1875	1422	1422
q5	4257	4172	4153	4153
q6	218	160	124	124
q7	1968	1947	1789	1789
q8	2688	2631	2516	2516
q9	7314	7085	7164	7085
q10	2986	3189	2733	2733
q11	577	513	481	481
q12	673	766	632	632
q13	3522	3862	3238	3238
q14	299	295	295	295
q15	508	475	464	464
q16	626	674	622	622
q17	1152	1599	1387	1387
q18	7590	7415	7235	7235
q19	834	869	977	869
q20	1940	2025	1865	1865
q21	5459	5049	4809	4809
q22	625	559	557	557
Total cold run time: 52628 ms
Total hot run time: 49978 ms

doris-robot · 2025-02-17T03:59:47Z

TPC-DS: Total hot run time: 184155 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 26b6a51cb635c04c1233f0afe554a41c2683269c, data reload: false
query1	1001	378	396	378
query2	6534	1847	1860	1847
query3	6794	212	219	212
query4	26763	23708	23751	23708
query5	4662	705	506	506
query6	312	209	195	195
query7	4608	513	293	293
query8	302	247	225	225
query9	8648	2507	2501	2501
query10	468	311	251	251
query11	15461	15194	15094	15094
query12	156	114	104	104
query13	1644	531	383	383
query14	9713	6910	6118	6118
query15	206	192	170	170
query16	7337	638	479	479
query17	1149	688	547	547
query18	1949	392	299	299
query19	194	191	154	154
query20	124	115	112	112
query21	205	121	101	101
query22	4346	4501	4238	4238
query23	33854	32978	33118	32978
query24	7677	2395	2419	2395
query25	538	457	388	388
query26	1219	273	151	151
query27	2130	521	342	342
query28	3907	2381	2371	2371
query29	728	547	413	413
query30	232	194	153	153
query31	963	879	784	784
query32	77	67	63	63
query33	552	347	315	315
query34	798	853	509	509
query35	801	818	742	742
query36	956	983	892	892
query37	123	94	75	75
query38	4179	4237	4197	4197
query39	1455	1376	1394	1376
query40	204	115	127	115
query41	55	52	54	52
query42	126	108	103	103
query43	490	510	480	480
query44	1281	787	771	771
query45	175	168	164	164
query46	942	1034	651	651
query47	1762	1819	1722	1722
query48	363	407	294	294
query49	776	519	410	410
query50	676	749	402	402
query51	4203	4237	4122	4122
query52	102	109	94	94
query53	225	271	181	181
query54	492	473	408	408
query55	88	81	83	81
query56	259	259	297	259
query57	1136	1143	1067	1067
query58	259	242	252	242
query59	2618	2776	2507	2507
query60	285	299	263	263
query61	144	143	142	142
query62	834	727	654	654
query63	227	197	189	189
query64	4385	995	651	651
query65	3249	3123	3137	3123
query66	1124	411	323	323
query67	15963	15666	15499	15499
query68	3230	782	514	514
query69	468	309	267	267
query70	1205	1065	1089	1065
query71	404	284	268	268
query72	5116	3628	3783	3628
query73	735	737	342	342
query74	9032	9062	8903	8903
query75	3142	3152	2680	2680
query76	3198	1180	771	771
query77	476	373	287	287
query78	9905	10166	9359	9359
query79	1004	857	582	582
query80	1179	539	465	465
query81	550	278	236	236
query82	410	132	96	96
query83	274	171	158	158
query84	235	98	76	76
query85	785	351	306	306
query86	372	310	296	296
query87	4490	4434	4361	4361
query88	2822	2250	2152	2152
query89	385	329	287	287
query90	1709	208	193	193
query91	137	138	109	109
query92	60	59	54	54
query93	1129	997	578	578
query94	661	412	315	315
query95	348	271	250	250
query96	486	564	269	269
query97	2779	2830	2756	2756
query98	228	209	204	204
query99	1290	1422	1300	1300
Total cold run time: 263452 ms
Total hot run time: 184155 ms

doris-robot · 2025-02-17T04:05:06Z

ClickBench: Total hot run time: 30.34 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 26b6a51cb635c04c1233f0afe554a41c2683269c, data reload: false
query1	0.03	0.03	0.05
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.11	0.11
query5	0.41	0.42	0.40
query6	1.15	0.66	0.66
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.55	0.52
query10	0.57	0.58	0.56
query11	0.15	0.11	0.12
query12	0.14	0.11	0.12
query13	0.61	0.60	0.62
query14	2.75	2.72	2.72
query15	0.92	0.87	0.86
query16	0.38	0.38	0.38
query17	1.05	1.01	1.03
query18	0.22	0.20	0.19
query19	1.84	1.80	1.92
query20	0.01	0.01	0.01
query21	15.36	0.90	0.53
query22	0.74	1.20	0.63
query23	14.98	1.39	0.62
query24	11.17	1.29	0.52
query25	0.34	0.14	0.17
query26	0.89	0.19	0.14
query27	0.05	0.05	0.05
query28	6.20	0.75	0.42
query29	12.52	3.95	3.27
query30	0.24	0.09	0.06
query31	2.81	0.58	0.39
query32	3.24	0.54	0.47
query33	3.05	2.95	3.13
query34	15.78	5.11	4.57
query35	4.58	4.56	4.54
query36	0.67	0.50	0.50
query37	0.10	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.97 s
Total hot run time: 30.34 s

github-actions · 2025-02-18T14:09:22Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-02-18T14:09:24Z

PR approved by anyone and no changes requested.

### What problem does this PR solve? The `defaultAuthenticator` is not initialized. When a configured authentication plugin implements the `canDea`l method and returns `false`, the `defaultAuthenticator` will be used, resulting in a login failure. The client exception message is `RROR 2013 (HY000): Lost connection to MySQL server at 'reading authorization packet', system error: 2`. This issue only affects users who use non-built-in authentication plugins that implement `canDeal` and return false under certain circumstances. apache#40113 introduced this issue

### What problem does this PR solve? The `defaultAuthenticator` is not initialized. When a configured authentication plugin implements the `canDea`l method and returns `false`, the `defaultAuthenticator` will be used, resulting in a login failure. The client exception message is `RROR 2013 (HY000): Lost connection to MySQL server at 'reading authorization packet', system error: 2`. This issue only affects users who use non-built-in authentication plugins that implement `canDeal` and return false under certain circumstances. apache#40113 introduced this issue (cherry picked from commit dd0c2d8)

CalvinKirs changed the title ~~[Fix](Authenticator)defaultAuthenticator not init~~[WIP][Fix](Authenticator)defaultAuthenticator not initNov 1, 2024

CalvinKirs marked this pull request as draft November 21, 2024 07:54

CalvinKirs changed the title ~~[WIP][Fix](Authenticator)defaultAuthenticator not init~~[Fix](Authenticator)defaultAuthenticator not initFeb 17, 2025

CalvinKirs marked this pull request as ready for review February 17, 2025 03:27

Merge branch 'master' into master-default-auth
26b6a51

morningman added the dev/2.1.x-experimental label Feb 18, 2025

morningman approved these changes Feb 18, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 18, 2025

github-actionsBot added the reviewed label Feb 18, 2025

wuwenchi approved these changes Feb 18, 2025
View reviewed changes

morningman merged commit dd0c2d8 into apache:masterFeb 18, 2025

Navigation Menu

Uh oh!

[Fix](Authenticator)defaultAuthenticator not init - #43057

[Fix](Authenticator)defaultAuthenticator not init#43057
morningman merged 2 commits into
apache:masterfrom
CalvinKirs:master-default-auth

CalvinKirs commented Nov 1, 2024

Uh oh!

doris-robot commented Nov 1, 2024

Uh oh!

CalvinKirs commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

github-actionsBot commented Feb 18, 2025

Uh oh!

github-actionsBot commented Feb 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

CalvinKirs commented Nov 1, 2024

What problem does this PR solve?

Uh oh!

doris-robot commented Nov 1, 2024

Uh oh!

CalvinKirs commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

github-actionsBot commented Feb 18, 2025

Uh oh!

github-actionsBot commented Feb 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants