Skip to content

[fix](test) fix clickhouse jdbc catalog func push down case - #43196

Merged
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:fix_ck_test
Nov 5, 2024
Merged

[fix](test) fix clickhouse jdbc catalog func push down case#43196
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:fix_ck_test

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Nov 4, 2024

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #42102

Problem Summary:

Because we previously disabled the pushdown of cast, a test case error occurred when checking the pushdown of the clickhosue function. Because the column type is largeint, a cast will be generated when using from_unixtime, causing the function to fail to be pushed down. So we changed the column type to bigint.

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 4, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@zy-kkk
zy-kkk merged commit 90e49d2 into apache:masterNov 5, 2024
@zy-kkk
zy-kkk deleted the fix_ck_test branch November 5, 2024 07:30
github-actionsBot pushed a commit that referenced this pull request Nov 5, 2024
Related PR: #42102
Because we previously disabled the pushdown of cast, a test case error occurred when checking the pushdown of the clickhosue function. Because the column type is largeint, a cast will be generated when using from_unixtime, causing the function to fail to be pushed down. So we changed the column type to bigint.
github-actionsBot pushed a commit that referenced this pull request Nov 5, 2024
Related PR: #42102
Because we previously disabled the pushdown of cast, a test case error occurred when checking the pushdown of the clickhosue function. Because the column type is largeint, a cast will be generated when using from_unixtime, causing the function to fail to be pushed down. So we changed the column type to bigint.
morningman pushed a commit to morningman/doris that referenced this pull request Nov 6, 2024
…3196)
Related PR: apache#42102
Because we previously disabled the pushdown of cast, a test case error occurred when checking the pushdown of the clickhosue function. Because the column type is largeint, a cast will be generated when using from_unixtime, causing the function to fail to be pushed down. So we changed the column type to bigint.
morningman added a commit that referenced this pull request Nov 6, 2024
…43315)
cherry pick from #43196
Co-authored-by: zy-kkk <zhongyk10@gmail.com>
morningman pushed a commit to morningman/doris that referenced this pull request Nov 18, 2024
…3196)
Related PR: apache#42102
Because we previously disabled the pushdown of cast, a test case error occurred when checking the pushdown of the clickhosue function. Because the column type is largeint, a cast will be generated when using from_unixtime, causing the function to fail to be pushed down. So we changed the column type to bigint.
morningman added a commit that referenced this pull request Nov 18, 2024
…44151)
cherry pick from #43196
Co-authored-by: zy-kkk <zhongyk10@gmail.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
…3196)
Related PR: apache#42102
Because we previously disabled the pushdown of cast, a test case error occurred when checking the pushdown of the clickhosue function. Because the column type is largeint, a cast will be generated when using from_unixtime, causing the function to fail to be pushed down. So we changed the column type to bigint.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zy-kkk@doris-robot@morningman@CalvinKirs