[fix](cloud) Check instance_id valid when use cloud_unique_id degrade format by deardeng · Pull Request #43253 · apache/doris

deardeng · 2024-11-05T06:32:37Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No colde files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.
Release note
None

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-05T06:32:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-11-05T06:37:06Z

clang-tidy review says "All clean, LGTM! 👍"

… format

deardeng · 2024-11-05T06:39:50Z

run buildall

github-actions · 2024-11-05T06:42:08Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

deardeng · 2024-11-05T13:03:12Z

run builldall

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-05T13:06:04Z

+ if (c0 != TxnErrorCode::TXN_OK) {
+ LOG(WARNING) << "check instance instance_id=" << instance_id
+ << " failed, code=" << format_as(c0) << ", info=" + m0;
+ return false;


warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
cloud/src/resource-manager/resource_manager.cpp:227:
- if (c0 != TxnErrorCode::TXN_OK) {- LOG(WARNING) << "check instance instance_id=" << instance_id- << " failed, code=" << format_as(c0) << ", info=" + m0;- return false;- }- return true;+ return !c0 != TxnErrorCode::TXN_OK;

deardeng · 2024-11-06T09:03:53Z

run buildall

github-actions · 2024-11-08T09:39:22Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-08T09:39:24Z

PR approved by anyone and no changes requested.

deardeng · 2024-11-08T11:15:30Z

run buildall

deardeng · 2024-11-08T11:23:42Z

run cloudut

deardeng · 2024-11-08T11:33:33Z

run buildall

github-actions · 2024-11-11T15:15:02Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

… format (apache#43253)

… format #43253 (#43832) cherry pick from #43253

… format (apache#43253)

[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
43b2fde
… format

deardeng force-pushed the add-check branch from 649fb67 to 43b2fdeCompare November 5, 2024 06:37

fix
59206f3

github-actionsBot reviewed Nov 5, 2024
View reviewed changes

Comment threadcloud/src/resource-manager/resource_manager.cpp
Comment threadcloud/src/resource-manager/resource_manager.cpp
Comment threadcloud/src/resource-manager/resource_manager.cpp Outdated

fix
6d73870

github-actionsBot reviewed Nov 5, 2024
View reviewed changes

dataroaring reviewed Nov 6, 2024
View reviewed changes

Comment threadcloud/src/common/config.h Outdated

dataroaring reviewed Nov 6, 2024
View reviewed changes

Comment threadcloud/src/resource-manager/resource_manager.cpp Outdated

gavinchou requested changes Nov 6, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated
Comment threadcloud/src/resource-manager/resource_manager.h Outdated
Comment threadcloud/src/resource-manager/resource_manager.cpp Outdated
Comment threadcloud/src/resource-manager/resource_manager.h Outdated

fix review
7f173bc

deardeng force-pushed the add-check branch from 290408f to 7f173bcCompare November 6, 2024 09:03

gavinchou previously approved these changes Nov 8, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 8, 2024

github-actionsBot added the reviewed label Nov 8, 2024

add log
ae2fc37

deardeng dismissed gavinchou’s stale review via ae2fc37November 8, 2024 11:15

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 8, 2024

fix ut
ade5b0f

dataroaring added the dev/3.0.x label Nov 11, 2024

gavinchou approved these changes Nov 11, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024

gavinchou changed the title ~~[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…~~[fix](cloud) Check instance_id valid when use cloud_unique_id degrade formatNov 11, 2024

dataroaring approved these changes Nov 11, 2024
View reviewed changes

dataroaring merged commit d05487c into apache:masterNov 12, 2024

github-actionsBot added the cherry-pick-conflict-in-3.0 label Nov 12, 2024

zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Nov 12, 2024
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
0200e57
… format (apache#43253)

924060929 pushed a commit to 924060929/incubator-doris that referenced this pull request Nov 12, 2024
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
bfb0964
… format (apache#43253)

deardeng mentioned this pull request Nov 13, 2024
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade format #43253 #43832
Merged

deardeng added a commit to deardeng/incubator-doris that referenced this pull request Nov 13, 2024
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
7bfd038
… format (apache#43253)

py023 pushed a commit to py023/doris that referenced this pull request Nov 13, 2024
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
7d3b917
… format (apache#43253)

dataroaring pushed a commit that referenced this pull request Nov 13, 2024
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
ae09157
… format #43253 (#43832) cherry pick from #43253

dataroaring added dev/3.0.3-merged and removed dev/3.0.x cherry-pick-conflict-in-3.0 labels Nov 13, 2024

gavinchou mentioned this pull request Nov 26, 2024
Release Note 3.0.3 #44522
Closed

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[fix](cloud) Check instance_id valid when use cloud_unique_id degrade…
69ae775
… format (apache#43253)

Uh oh!

Conversation

deardeng commented Nov 5, 2024• edited by gavinchou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Check List (For Committer)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Nov 5, 2024

Uh oh!

github-actionsBot commented Nov 5, 2024

Uh oh!

deardeng commented Nov 5, 2024

Uh oh!

github-actionsBot commented Nov 5, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deardeng commented Nov 5, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotNov 5, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deardeng commented Nov 6, 2024

Uh oh!

Uh oh!

github-actionsBot commented Nov 8, 2024

Uh oh!

github-actionsBot commented Nov 8, 2024

Uh oh!

deardeng commented Nov 8, 2024

Uh oh!

deardeng commented Nov 8, 2024

Uh oh!

deardeng commented Nov 8, 2024

Uh oh!

github-actionsBot commented Nov 11, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deardeng commented Nov 5, 2024•
edited by gavinchou
Loading